All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] python3-pluggy: upgrade 0.13.1 -> 1.0.0
@ 2021-08-25 20:28 Tim Orling
  2021-08-26 16:12 ` [OE-core] " Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Tim Orling @ 2021-08-25 20:28 UTC (permalink / raw)
  To: openembedded-core; +Cc: Tim Orling

* All ptests pass on qemux86-64

pluggy 1.0.0 (2021-08-25)

Deprecations and Removals

    #116: Remove deprecated implprefix support. Decorate hook
	  implementations using an instance of HookimplMarker instead.
The deprecation was announced in release 0.7.0.
    #120: Remove the deprecated proc argument to call_historic. Use
	  result_callback instead, which has the same behavior. The
deprecation was announced in release 0.7.0.
    #265: Remove the _Result.result property. Use _Result.get_result()
	  instead. Note that unlike result, get_result() raises the
exception if the hook raised. The deprecation was announced in release
0.6.0.
    #267: Remove official support for Python 3.4.
    #272: Dropped support for Python 2. Continue to use pluggy 0.13.x
	  for Python 2 support.
    #308: Remove official support for Python 3.5.
    #313: The internal pluggy.callers, pluggy.manager and pluggy.hooks
	  are now explicitly marked private by a _ prefix (e.g.
pluggy._callers). Only API exported by the top-level pluggy module is
considered public.
    #59: Remove legacy __multicall__ recursive hook calling system. The
	 deprecation was announced in release 0.5.0.

Features

    #282: When registering a hookimpl which is declared as
	  hookwrapper=True but whose function is not a generator
function, a PluggyValidationError exception is now raised.

    Previously this problem would cause an error only later, when
calling the hook.

    In the unlikely case that you have a hookwrapper that returns a
generator instead of yielding directly, for example:

    def my_hook_real_implementation(arg):
        print("before")
        yield
        print("after")

    @hookimpl(hookwrapper=True)
    def my_hook(arg):
        return my_hook_implementation(arg)

    change it to use yield from instead:

    @hookimpl(hookwrapper=True)
    def my_hook(arg):
        yield from my_hook_implementation(arg)

    #309: Add official support for Python 3.9.

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
---
 .../{python3-pluggy_0.13.1.bb => python3-pluggy_1.0.0.bb}      | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
 rename meta/recipes-devtools/python/{python3-pluggy_0.13.1.bb => python3-pluggy_1.0.0.bb} (80%)

diff --git a/meta/recipes-devtools/python/python3-pluggy_0.13.1.bb b/meta/recipes-devtools/python/python3-pluggy_1.0.0.bb
similarity index 80%
rename from meta/recipes-devtools/python/python3-pluggy_0.13.1.bb
rename to meta/recipes-devtools/python/python3-pluggy_1.0.0.bb
index 479c10fcdc..14a7ccb0b0 100644
--- a/meta/recipes-devtools/python/python3-pluggy_0.13.1.bb
+++ b/meta/recipes-devtools/python/python3-pluggy_1.0.0.bb
@@ -3,8 +3,7 @@ HOMEPAGE = "https://github.com/pytest-dev/pluggy"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=1c8206d16fd5cc02fa9b0bb98955e5c2"
 
-SRC_URI[md5sum] = "7f610e28b8b34487336b585a3dfb803d"
-SRC_URI[sha256sum] = "15b2acde666561e1298d71b523007ed7364de07029219b604cf808bfa1c765b0"
+SRC_URI[sha256sum] = "4224373bacce55f955a878bf9cfa763c1e360858e330072059e10bad68531159"
 
 DEPENDS += "${PYTHON_PN}-setuptools-scm-native"
 RDEPENDS:${PN} += "${PYTHON_PN}-importlib-metadata \
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [OE-core] [PATCH] python3-pluggy: upgrade 0.13.1 -> 1.0.0
  2021-08-25 20:28 [PATCH] python3-pluggy: upgrade 0.13.1 -> 1.0.0 Tim Orling
@ 2021-08-26 16:12 ` Richard Purdie
  2021-08-26 16:53   ` Tim Orling
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2021-08-26 16:12 UTC (permalink / raw)
  To: Tim Orling, openembedded-core; +Cc: Tim Orling

On Wed, 2021-08-25 at 20:28 +0000, Tim Orling wrote:
> * All ptests pass on qemux86-64
> 
> pluggy 1.0.0 (2021-08-25)
> 
> Deprecations and Removals
> 
>     #116: Remove deprecated implprefix support. Decorate hook
> 	  implementations using an instance of HookimplMarker instead.
> The deprecation was announced in release 0.7.0.
>     #120: Remove the deprecated proc argument to call_historic. Use
> 	  result_callback instead, which has the same behavior. The
> deprecation was announced in release 0.7.0.
>     #265: Remove the _Result.result property. Use _Result.get_result()
> 	  instead. Note that unlike result, get_result() raises the
> exception if the hook raised. The deprecation was announced in release
> 0.6.0.
>     #267: Remove official support for Python 3.4.
>     #272: Dropped support for Python 2. Continue to use pluggy 0.13.x
> 	  for Python 2 support.
>     #308: Remove official support for Python 3.5.
>     #313: The internal pluggy.callers, pluggy.manager and pluggy.hooks
> 	  are now explicitly marked private by a _ prefix (e.g.
> pluggy._callers). Only API exported by the top-level pluggy module is
> considered public.
>     #59: Remove legacy __multicall__ recursive hook calling system. The
> 	 deprecation was announced in release 0.5.0.
> 
> Features
> 
>     #282: When registering a hookimpl which is declared as
> 	  hookwrapper=True but whose function is not a generator
> function, a PluggyValidationError exception is now raised.
> 
>     Previously this problem would cause an error only later, when
> calling the hook.
> 
>     In the unlikely case that you have a hookwrapper that returns a
> generator instead of yielding directly, for example:
> 
>     def my_hook_real_implementation(arg):
>         print("before")
>         yield
>         print("after")
> 
>     @hookimpl(hookwrapper=True)
>     def my_hook(arg):
>         return my_hook_implementation(arg)
> 
>     change it to use yield from instead:
> 
>     @hookimpl(hookwrapper=True)
>     def my_hook(arg):
>         yield from my_hook_implementation(arg)
> 
>     #309: Add official support for Python 3.9.
> 
> Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
> ---
>  .../{python3-pluggy_0.13.1.bb => python3-pluggy_1.0.0.bb}      | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>  rename meta/recipes-devtools/python/{python3-pluggy_0.13.1.bb => python3-pluggy_1.0.0.bb} (80%)

I haven't proof but I suspect this has caused python3-jinja2's ptests to
regress:

https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/2433/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/2152/steps/12/logs/stdio

I didn't spot this before it merged unfortunately.

Cheers,

Richard


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [OE-core] [PATCH] python3-pluggy: upgrade 0.13.1 -> 1.0.0
  2021-08-26 16:12 ` [OE-core] " Richard Purdie
@ 2021-08-26 16:53   ` Tim Orling
  0 siblings, 0 replies; 3+ messages in thread
From: Tim Orling @ 2021-08-26 16:53 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core, Tim Orling

[-- Attachment #1: Type: text/plain, Size: 3146 bytes --]

On Thu, Aug 26, 2021 at 9:12 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Wed, 2021-08-25 at 20:28 +0000, Tim Orling wrote:
> > * All ptests pass on qemux86-64
> >
> > pluggy 1.0.0 (2021-08-25)
> >
> > Deprecations and Removals
> >
> >     #116: Remove deprecated implprefix support. Decorate hook
> >         implementations using an instance of HookimplMarker instead.
> > The deprecation was announced in release 0.7.0.
> >     #120: Remove the deprecated proc argument to call_historic. Use
> >         result_callback instead, which has the same behavior. The
> > deprecation was announced in release 0.7.0.
> >     #265: Remove the _Result.result property. Use _Result.get_result()
> >         instead. Note that unlike result, get_result() raises the
> > exception if the hook raised. The deprecation was announced in release
> > 0.6.0.
> >     #267: Remove official support for Python 3.4.
> >     #272: Dropped support for Python 2. Continue to use pluggy 0.13.x
> >         for Python 2 support.
> >     #308: Remove official support for Python 3.5.
> >     #313: The internal pluggy.callers, pluggy.manager and pluggy.hooks
> >         are now explicitly marked private by a _ prefix (e.g.
> > pluggy._callers). Only API exported by the top-level pluggy module is
> > considered public.
> >     #59: Remove legacy __multicall__ recursive hook calling system. The
> >        deprecation was announced in release 0.5.0.
> >
> > Features
> >
> >     #282: When registering a hookimpl which is declared as
> >         hookwrapper=True but whose function is not a generator
> > function, a PluggyValidationError exception is now raised.
> >
> >     Previously this problem would cause an error only later, when
> > calling the hook.
> >
> >     In the unlikely case that you have a hookwrapper that returns a
> > generator instead of yielding directly, for example:
> >
> >     def my_hook_real_implementation(arg):
> >         print("before")
> >         yield
> >         print("after")
> >
> >     @hookimpl(hookwrapper=True)
> >     def my_hook(arg):
> >         return my_hook_implementation(arg)
> >
> >     change it to use yield from instead:
> >
> >     @hookimpl(hookwrapper=True)
> >     def my_hook(arg):
> >         yield from my_hook_implementation(arg)
> >
> >     #309: Add official support for Python 3.9.
> >
> > Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
> > ---
> >  .../{python3-pluggy_0.13.1.bb => python3-pluggy_1.0.0.bb}      | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >  rename meta/recipes-devtools/python/{python3-pluggy_0.13.1.bb =>
> python3-pluggy_1.0.0.bb} (80%)
>
> I haven't proof but I suspect this has caused python3-jinja2's ptests to
> regress:
>
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/2433/steps/12/logs/stdio
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/2152/steps/12/logs/stdio
>
> I didn't spot this before it merged unfortunately.
>

Replicated locally. Looking into fix.

>
> Cheers,
>
> Richard
>
>

[-- Attachment #2: Type: text/html, Size: 4773 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-26 16:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 20:28 [PATCH] python3-pluggy: upgrade 0.13.1 -> 1.0.0 Tim Orling
2021-08-26 16:12 ` [OE-core] " Richard Purdie
2021-08-26 16:53   ` Tim Orling

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.