* [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"
@ 2021-08-25 21:05 Tom Rini
2021-09-10 6:42 ` Z.Q. Hou
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2021-08-25 21:05 UTC (permalink / raw)
To: u-boot; +Cc: Hou Zhiqiang, Priyanka Jain
Ad-hoc bindings that are not part of the upstream device tree / bindings
are not allowed in-tree. Only bindings that are in-progress with
upstream and then re-synced once agreed upon are.
This reverts commit af288cb291da3abef6be0875527729296f7de7a0.
Cc: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Cc: Priyanka Jain <priyanka.jain@nxp.com>
Reported-by: Michael Walle <michael@walle.cc>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
arch/arm/cpu/armv8/fsl-layerscape/soc.c | 17 +----------------
arch/arm/dts/fsl-ls1028a.dtsi | 6 ------
arch/arm/dts/fsl-ls1088a.dtsi | 6 ------
arch/arm/dts/fsl-ls2080a.dtsi | 6 ------
arch/arm/dts/fsl-lx2160a.dtsi | 6 ------
5 files changed, 1 insertion(+), 40 deletions(-)
diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
index 42a096854629..166662a64baf 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
+++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
@@ -43,22 +43,7 @@ DECLARE_GLOBAL_DATA_PTR;
#ifdef CONFIG_GIC_V3_ITS
int ls_gic_rd_tables_init(void *blob)
{
- struct fdt_memory lpi_base;
- fdt_addr_t addr;
- fdt_size_t size;
- int offset, ret;
-
- offset = fdt_path_offset(gd->fdt_blob, "/syscon@0x80000000");
- addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, offset, "reg",
- 0, &size, false);
-
- lpi_base.start = addr;
- lpi_base.end = addr + size - 1;
- ret = fdtdec_add_reserved_memory(blob, "lpi_rd_table", &lpi_base, NULL, false);
- if (ret) {
- debug("%s: failed to add reserved memory\n", __func__);
- return ret;
- }
+ int ret;
ret = gic_lpi_tables_init();
if (ret)
diff --git a/arch/arm/dts/fsl-ls1028a.dtsi b/arch/arm/dts/fsl-ls1028a.dtsi
index 50f9b527cde1..53b052ed3271 100644
--- a/arch/arm/dts/fsl-ls1028a.dtsi
+++ b/arch/arm/dts/fsl-ls1028a.dtsi
@@ -44,12 +44,6 @@
IRQ_TYPE_LEVEL_LOW)>;
};
- gic_lpi_base: syscon@0x80000000 {
- compatible = "gic-lpi-base";
- reg = <0x0 0x80000000 0x0 0x100000>;
- max-gic-redistributors = <2>;
- };
-
timer {
compatible = "arm,armv8-timer";
interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) |
diff --git a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi
index 64caa600ad77..3a5a50fb8313 100644
--- a/arch/arm/dts/fsl-ls1088a.dtsi
+++ b/arch/arm/dts/fsl-ls1088a.dtsi
@@ -27,12 +27,6 @@
interrupts = <1 9 0x4>;
};
- gic_lpi_base: syscon@0x80000000 {
- compatible = "gic-lpi-base";
- reg = <0x0 0x80000000 0x0 0x100000>;
- max-gic-redistributors = <8>;
- };
-
timer {
compatible = "arm,armv8-timer";
interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
diff --git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi
index 7374d580e07e..278daeeb6eea 100644
--- a/arch/arm/dts/fsl-ls2080a.dtsi
+++ b/arch/arm/dts/fsl-ls2080a.dtsi
@@ -27,12 +27,6 @@
interrupts = <1 9 0x4>;
};
- gic_lpi_base: syscon@0x80000000 {
- compatible = "gic-lpi-base";
- reg = <0x0 0x80000000 0x0 0x100000>;
- max-gic-redistributors = <8>;
- };
-
timer {
compatible = "arm,armv8-timer";
interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
diff --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi
index a6f0e9bc56be..3b5f0d119e76 100644
--- a/arch/arm/dts/fsl-lx2160a.dtsi
+++ b/arch/arm/dts/fsl-lx2160a.dtsi
@@ -43,12 +43,6 @@
interrupts = <1 9 0x4>;
};
- gic_lpi_base: syscon@0x80000000 {
- compatible = "gic-lpi-base";
- reg = <0x0 0x80000000 0x0 0x200000>;
- max-gic-redistributors = <16>;
- };
-
timer {
compatible = "arm,armv8-timer";
interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"
2021-08-25 21:05 [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround" Tom Rini
@ 2021-09-10 6:42 ` Z.Q. Hou
2021-09-13 5:59 ` Priyanka Jain (OSS)
0 siblings, 1 reply; 6+ messages in thread
From: Z.Q. Hou @ 2021-09-10 6:42 UTC (permalink / raw)
To: Tom Rini, u-boot, rayagonda.kokatanur; +Cc: Priyanka Jain
+ author of gic_lpi_syscon driver
Hi Rayagonda,
Please add the binding for gic_lpi_syscon driver.
Thanks,
Zhiqiang
> -----Original Message-----
> From: Tom Rini <trini@konsulko.com>
> Sent: 2021年8月26日 5:05
> To: u-boot@lists.denx.de
> Cc: Z.Q. Hou <zhiqiang.hou@nxp.com>; Priyanka Jain
> <priyanka.jain@nxp.com>
> Subject: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset
> workaround"
>
> Ad-hoc bindings that are not part of the upstream device tree / bindings are
> not allowed in-tree. Only bindings that are in-progress with upstream and
> then re-synced once agreed upon are.
>
> This reverts commit af288cb291da3abef6be0875527729296f7de7a0.
>
> Cc: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Cc: Priyanka Jain <priyanka.jain@nxp.com>
> Reported-by: Michael Walle <michael@walle.cc>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> arch/arm/cpu/armv8/fsl-layerscape/soc.c | 17 +----------------
> arch/arm/dts/fsl-ls1028a.dtsi | 6 ------
> arch/arm/dts/fsl-ls1088a.dtsi | 6 ------
> arch/arm/dts/fsl-ls2080a.dtsi | 6 ------
> arch/arm/dts/fsl-lx2160a.dtsi | 6 ------
> 5 files changed, 1 insertion(+), 40 deletions(-)
>
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> index 42a096854629..166662a64baf 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> @@ -43,22 +43,7 @@ DECLARE_GLOBAL_DATA_PTR; #ifdef
> CONFIG_GIC_V3_ITS int ls_gic_rd_tables_init(void *blob) {
> - struct fdt_memory lpi_base;
> - fdt_addr_t addr;
> - fdt_size_t size;
> - int offset, ret;
> -
> - offset = fdt_path_offset(gd->fdt_blob, "/syscon@0x80000000");
> - addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, offset,
> "reg",
> - 0, &size, false);
> -
> - lpi_base.start = addr;
> - lpi_base.end = addr + size - 1;
> - ret = fdtdec_add_reserved_memory(blob, "lpi_rd_table", &lpi_base,
> NULL, false);
> - if (ret) {
> - debug("%s: failed to add reserved memory\n", __func__);
> - return ret;
> - }
> + int ret;
>
> ret = gic_lpi_tables_init();
> if (ret)
> diff --git a/arch/arm/dts/fsl-ls1028a.dtsi b/arch/arm/dts/fsl-ls1028a.dtsi
> index 50f9b527cde1..53b052ed3271 100644
> --- a/arch/arm/dts/fsl-ls1028a.dtsi
> +++ b/arch/arm/dts/fsl-ls1028a.dtsi
> @@ -44,12 +44,6 @@
> IRQ_TYPE_LEVEL_LOW)>;
> };
>
> - gic_lpi_base: syscon@0x80000000 {
> - compatible = "gic-lpi-base";
> - reg = <0x0 0x80000000 0x0 0x100000>;
> - max-gic-redistributors = <2>;
> - };
> -
> timer {
> compatible = "arm,armv8-timer";
> interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | diff --git
> a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi index
> 64caa600ad77..3a5a50fb8313 100644
> --- a/arch/arm/dts/fsl-ls1088a.dtsi
> +++ b/arch/arm/dts/fsl-ls1088a.dtsi
> @@ -27,12 +27,6 @@
> interrupts = <1 9 0x4>;
> };
>
> - gic_lpi_base: syscon@0x80000000 {
> - compatible = "gic-lpi-base";
> - reg = <0x0 0x80000000 0x0 0x100000>;
> - max-gic-redistributors = <8>;
> - };
> -
> timer {
> compatible = "arm,armv8-timer";
> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
> --git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi index
> 7374d580e07e..278daeeb6eea 100644
> --- a/arch/arm/dts/fsl-ls2080a.dtsi
> +++ b/arch/arm/dts/fsl-ls2080a.dtsi
> @@ -27,12 +27,6 @@
> interrupts = <1 9 0x4>;
> };
>
> - gic_lpi_base: syscon@0x80000000 {
> - compatible = "gic-lpi-base";
> - reg = <0x0 0x80000000 0x0 0x100000>;
> - max-gic-redistributors = <8>;
> - };
> -
> timer {
> compatible = "arm,armv8-timer";
> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
> --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi index
> a6f0e9bc56be..3b5f0d119e76 100644
> --- a/arch/arm/dts/fsl-lx2160a.dtsi
> +++ b/arch/arm/dts/fsl-lx2160a.dtsi
> @@ -43,12 +43,6 @@
> interrupts = <1 9 0x4>;
> };
>
> - gic_lpi_base: syscon@0x80000000 {
> - compatible = "gic-lpi-base";
> - reg = <0x0 0x80000000 0x0 0x200000>;
> - max-gic-redistributors = <16>;
> - };
> -
> timer {
> compatible = "arm,armv8-timer";
> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
> --
> 2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"
2021-09-10 6:42 ` Z.Q. Hou
@ 2021-09-13 5:59 ` Priyanka Jain (OSS)
2021-09-13 7:52 ` Rayagonda Kokatanur
0 siblings, 1 reply; 6+ messages in thread
From: Priyanka Jain (OSS) @ 2021-09-13 5:59 UTC (permalink / raw)
To: Z.Q. Hou, Tom Rini, u-boot, rayagonda.kokatanur
>-----Original Message-----
>From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Z.Q. Hou
>Sent: Friday, September 10, 2021 12:13 PM
>To: Tom Rini <trini@konsulko.com>; u-boot@lists.denx.de;
>rayagonda.kokatanur@broadcom.com
>Cc: Priyanka Jain <priyanka.jain@nxp.com>
>Subject: RE: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset
>workaround"
>
>+ author of gic_lpi_syscon driver
>
>Hi Rayagonda,
>
>Please add the binding for gic_lpi_syscon driver.
>
>Thanks,
>Zhiqiang
>
>> -----Original Message-----
>> From: Tom Rini <trini@konsulko.com>
>> Sent: 2021年8月26日 5:05
>> To: u-boot@lists.denx.de
>> Cc: Z.Q. Hou <zhiqiang.hou@nxp.com>; Priyanka Jain
>> <priyanka.jain@nxp.com>
>> Subject: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way
>> reset workaround"
>>
>> Ad-hoc bindings that are not part of the upstream device tree /
>> bindings are not allowed in-tree. Only bindings that are in-progress
>> with upstream and then re-synced once agreed upon are.
>>
>> This reverts commit af288cb291da3abef6be0875527729296f7de7a0.
>>
>> Cc: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>> Cc: Priyanka Jain <priyanka.jain@nxp.com>
>> Reported-by: Michael Walle <michael@walle.cc>
>> Signed-off-by: Tom Rini <trini@konsulko.com>
>> ---
>> arch/arm/cpu/armv8/fsl-layerscape/soc.c | 17 +----------------
>> arch/arm/dts/fsl-ls1028a.dtsi | 6 ------
>> arch/arm/dts/fsl-ls1088a.dtsi | 6 ------
>> arch/arm/dts/fsl-ls2080a.dtsi | 6 ------
>> arch/arm/dts/fsl-lx2160a.dtsi | 6 ------
>> 5 files changed, 1 insertion(+), 40 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>> index 42a096854629..166662a64baf 100644
>> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>> @@ -43,22 +43,7 @@ DECLARE_GLOBAL_DATA_PTR; #ifdef
>CONFIG_GIC_V3_ITS
>> int ls_gic_rd_tables_init(void *blob) {
>> - struct fdt_memory lpi_base;
>> - fdt_addr_t addr;
>> - fdt_size_t size;
>> - int offset, ret;
>> -
>> - offset = fdt_path_offset(gd->fdt_blob, "/syscon@0x80000000");
>> - addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, offset,
>> "reg",
>> - 0, &size, false);
>> -
>> - lpi_base.start = addr;
>> - lpi_base.end = addr + size - 1;
>> - ret = fdtdec_add_reserved_memory(blob, "lpi_rd_table", &lpi_base,
>> NULL, false);
>> - if (ret) {
>> - debug("%s: failed to add reserved memory\n", __func__);
>> - return ret;
>> - }
>> + int ret;
>>
>> ret = gic_lpi_tables_init();
>> if (ret)
>> diff --git a/arch/arm/dts/fsl-ls1028a.dtsi
>> b/arch/arm/dts/fsl-ls1028a.dtsi index 50f9b527cde1..53b052ed3271
>> 100644
>> --- a/arch/arm/dts/fsl-ls1028a.dtsi
>> +++ b/arch/arm/dts/fsl-ls1028a.dtsi
>> @@ -44,12 +44,6 @@
>> IRQ_TYPE_LEVEL_LOW)>;
>> };
>>
>> - gic_lpi_base: syscon@0x80000000 {
>> - compatible = "gic-lpi-base";
>> - reg = <0x0 0x80000000 0x0 0x100000>;
>> - max-gic-redistributors = <2>;
>> - };
>> -
>> timer {
>> compatible = "arm,armv8-timer";
>> interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | diff --git
>> a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi index
>> 64caa600ad77..3a5a50fb8313 100644
>> --- a/arch/arm/dts/fsl-ls1088a.dtsi
>> +++ b/arch/arm/dts/fsl-ls1088a.dtsi
>> @@ -27,12 +27,6 @@
>> interrupts = <1 9 0x4>;
>> };
>>
>> - gic_lpi_base: syscon@0x80000000 {
>> - compatible = "gic-lpi-base";
>> - reg = <0x0 0x80000000 0x0 0x100000>;
>> - max-gic-redistributors = <8>;
>> - };
>> -
>> timer {
>> compatible = "arm,armv8-timer";
>> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
>> --git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi
>> index 7374d580e07e..278daeeb6eea 100644
>> --- a/arch/arm/dts/fsl-ls2080a.dtsi
>> +++ b/arch/arm/dts/fsl-ls2080a.dtsi
>> @@ -27,12 +27,6 @@
>> interrupts = <1 9 0x4>;
>> };
>>
>> - gic_lpi_base: syscon@0x80000000 {
>> - compatible = "gic-lpi-base";
>> - reg = <0x0 0x80000000 0x0 0x100000>;
>> - max-gic-redistributors = <8>;
>> - };
>> -
>> timer {
>> compatible = "arm,armv8-timer";
>> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
>> --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi
>> index
>> a6f0e9bc56be..3b5f0d119e76 100644
>> --- a/arch/arm/dts/fsl-lx2160a.dtsi
>> +++ b/arch/arm/dts/fsl-lx2160a.dtsi
>> @@ -43,12 +43,6 @@
>> interrupts = <1 9 0x4>;
>> };
>>
>> - gic_lpi_base: syscon@0x80000000 {
>> - compatible = "gic-lpi-base";
>> - reg = <0x0 0x80000000 0x0 0x200000>;
>> - max-gic-redistributors = <16>;
>> - };
>> -
>> timer {
>> compatible = "arm,armv8-timer";
>> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
>> --
>> 2.17.1
Tom,
I agree that bindings patch is essential for device-tree changes.
But merging this patch will break Layerscape Platforms.
We have requested Rayagonda to submit Binding patch to upstream for review.
If first patch of binding gets submitted timely, can we defer this patch.
Regards
Priyanka
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"
2021-09-13 5:59 ` Priyanka Jain (OSS)
@ 2021-09-13 7:52 ` Rayagonda Kokatanur
2021-09-13 13:13 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Rayagonda Kokatanur @ 2021-09-13 7:52 UTC (permalink / raw)
To: Priyanka Jain (OSS), Bharat Gooty, Roman Bacik, Henrik Christensen
Cc: Z.Q. Hou, Tom Rini, u-boot
[-- Attachment #1: Type: text/plain, Size: 6092 bytes --]
On Mon, Sep 13, 2021 at 11:29 AM Priyanka Jain (OSS)
<priyanka.jain@oss.nxp.com> wrote:
>
>
>
> >-----Original Message-----
> >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Z.Q. Hou
> >Sent: Friday, September 10, 2021 12:13 PM
> >To: Tom Rini <trini@konsulko.com>; u-boot@lists.denx.de;
> >rayagonda.kokatanur@broadcom.com
> >Cc: Priyanka Jain <priyanka.jain@nxp.com>
> >Subject: RE: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset
> >workaround"
> >
> >+ author of gic_lpi_syscon driver
> >
> >Hi Rayagonda,
> >
> >Please add the binding for gic_lpi_syscon driver.
> >
> >Thanks,
> >Zhiqiang
> >
> >> -----Original Message-----
> >> From: Tom Rini <trini@konsulko.com>
> >> Sent: 2021年8月26日 5:05
> >> To: u-boot@lists.denx.de
> >> Cc: Z.Q. Hou <zhiqiang.hou@nxp.com>; Priyanka Jain
> >> <priyanka.jain@nxp.com>
> >> Subject: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way
> >> reset workaround"
> >>
> >> Ad-hoc bindings that are not part of the upstream device tree /
> >> bindings are not allowed in-tree. Only bindings that are in-progress
> >> with upstream and then re-synced once agreed upon are.
> >>
> >> This reverts commit af288cb291da3abef6be0875527729296f7de7a0.
> >>
> >> Cc: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >> Cc: Priyanka Jain <priyanka.jain@nxp.com>
> >> Reported-by: Michael Walle <michael@walle.cc>
> >> Signed-off-by: Tom Rini <trini@konsulko.com>
> >> ---
> >> arch/arm/cpu/armv8/fsl-layerscape/soc.c | 17 +----------------
> >> arch/arm/dts/fsl-ls1028a.dtsi | 6 ------
> >> arch/arm/dts/fsl-ls1088a.dtsi | 6 ------
> >> arch/arm/dts/fsl-ls2080a.dtsi | 6 ------
> >> arch/arm/dts/fsl-lx2160a.dtsi | 6 ------
> >> 5 files changed, 1 insertion(+), 40 deletions(-)
> >>
> >> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> >> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> >> index 42a096854629..166662a64baf 100644
> >> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> >> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> >> @@ -43,22 +43,7 @@ DECLARE_GLOBAL_DATA_PTR; #ifdef
> >CONFIG_GIC_V3_ITS
> >> int ls_gic_rd_tables_init(void *blob) {
> >> - struct fdt_memory lpi_base;
> >> - fdt_addr_t addr;
> >> - fdt_size_t size;
> >> - int offset, ret;
> >> -
> >> - offset = fdt_path_offset(gd->fdt_blob, "/syscon@0x80000000");
> >> - addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, offset,
> >> "reg",
> >> - 0, &size, false);
> >> -
> >> - lpi_base.start = addr;
> >> - lpi_base.end = addr + size - 1;
> >> - ret = fdtdec_add_reserved_memory(blob, "lpi_rd_table", &lpi_base,
> >> NULL, false);
> >> - if (ret) {
> >> - debug("%s: failed to add reserved memory\n", __func__);
> >> - return ret;
> >> - }
> >> + int ret;
> >>
> >> ret = gic_lpi_tables_init();
> >> if (ret)
> >> diff --git a/arch/arm/dts/fsl-ls1028a.dtsi
> >> b/arch/arm/dts/fsl-ls1028a.dtsi index 50f9b527cde1..53b052ed3271
> >> 100644
> >> --- a/arch/arm/dts/fsl-ls1028a.dtsi
> >> +++ b/arch/arm/dts/fsl-ls1028a.dtsi
> >> @@ -44,12 +44,6 @@
> >> IRQ_TYPE_LEVEL_LOW)>;
> >> };
> >>
> >> - gic_lpi_base: syscon@0x80000000 {
> >> - compatible = "gic-lpi-base";
> >> - reg = <0x0 0x80000000 0x0 0x100000>;
> >> - max-gic-redistributors = <2>;
> >> - };
> >> -
> >> timer {
> >> compatible = "arm,armv8-timer";
> >> interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | diff --git
> >> a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi index
> >> 64caa600ad77..3a5a50fb8313 100644
> >> --- a/arch/arm/dts/fsl-ls1088a.dtsi
> >> +++ b/arch/arm/dts/fsl-ls1088a.dtsi
> >> @@ -27,12 +27,6 @@
> >> interrupts = <1 9 0x4>;
> >> };
> >>
> >> - gic_lpi_base: syscon@0x80000000 {
> >> - compatible = "gic-lpi-base";
> >> - reg = <0x0 0x80000000 0x0 0x100000>;
> >> - max-gic-redistributors = <8>;
> >> - };
> >> -
> >> timer {
> >> compatible = "arm,armv8-timer";
> >> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
> >> --git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi
> >> index 7374d580e07e..278daeeb6eea 100644
> >> --- a/arch/arm/dts/fsl-ls2080a.dtsi
> >> +++ b/arch/arm/dts/fsl-ls2080a.dtsi
> >> @@ -27,12 +27,6 @@
> >> interrupts = <1 9 0x4>;
> >> };
> >>
> >> - gic_lpi_base: syscon@0x80000000 {
> >> - compatible = "gic-lpi-base";
> >> - reg = <0x0 0x80000000 0x0 0x100000>;
> >> - max-gic-redistributors = <8>;
> >> - };
> >> -
> >> timer {
> >> compatible = "arm,armv8-timer";
> >> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
> >> --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi
> >> index
> >> a6f0e9bc56be..3b5f0d119e76 100644
> >> --- a/arch/arm/dts/fsl-lx2160a.dtsi
> >> +++ b/arch/arm/dts/fsl-lx2160a.dtsi
> >> @@ -43,12 +43,6 @@
> >> interrupts = <1 9 0x4>;
> >> };
> >>
> >> - gic_lpi_base: syscon@0x80000000 {
> >> - compatible = "gic-lpi-base";
> >> - reg = <0x0 0x80000000 0x0 0x200000>;
> >> - max-gic-redistributors = <16>;
> >> - };
> >> -
> >> timer {
> >> compatible = "arm,armv8-timer";
> >> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
> >> --
> >> 2.17.1
>
>
> Tom,
>
> I agree that bindings patch is essential for device-tree changes.
> But merging this patch will break Layerscape Platforms.
> We have requested Rayagonda to submit Binding patch to upstream for review.
>
> If first patch of binding gets submitted timely, can we defer this patch.
>
> Regards
> Priyanka
>
++Bharat, Roman and Henrik.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4230 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"
2021-09-13 7:52 ` Rayagonda Kokatanur
@ 2021-09-13 13:13 ` Tom Rini
2021-10-24 18:02 ` [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset Michael Walle
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2021-09-13 13:13 UTC (permalink / raw)
To: Rayagonda Kokatanur
Cc: Priyanka Jain (OSS),
Bharat Gooty, Roman Bacik, Henrik Christensen, Z.Q. Hou, u-boot
[-- Attachment #1: Type: text/plain, Size: 6953 bytes --]
On Mon, Sep 13, 2021 at 01:22:10PM +0530, Rayagonda Kokatanur wrote:
> On Mon, Sep 13, 2021 at 11:29 AM Priyanka Jain (OSS)
> <priyanka.jain@oss.nxp.com> wrote:
> >
> >
> >
> > >-----Original Message-----
> > >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Z.Q. Hou
> > >Sent: Friday, September 10, 2021 12:13 PM
> > >To: Tom Rini <trini@konsulko.com>; u-boot@lists.denx.de;
> > >rayagonda.kokatanur@broadcom.com
> > >Cc: Priyanka Jain <priyanka.jain@nxp.com>
> > >Subject: RE: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset
> > >workaround"
> > >
> > >+ author of gic_lpi_syscon driver
> > >
> > >Hi Rayagonda,
> > >
> > >Please add the binding for gic_lpi_syscon driver.
> > >
> > >Thanks,
> > >Zhiqiang
> > >
> > >> -----Original Message-----
> > >> From: Tom Rini <trini@konsulko.com>
> > >> Sent: 2021年8月26日 5:05
> > >> To: u-boot@lists.denx.de
> > >> Cc: Z.Q. Hou <zhiqiang.hou@nxp.com>; Priyanka Jain
> > >> <priyanka.jain@nxp.com>
> > >> Subject: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way
> > >> reset workaround"
> > >>
> > >> Ad-hoc bindings that are not part of the upstream device tree /
> > >> bindings are not allowed in-tree. Only bindings that are in-progress
> > >> with upstream and then re-synced once agreed upon are.
> > >>
> > >> This reverts commit af288cb291da3abef6be0875527729296f7de7a0.
> > >>
> > >> Cc: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > >> Cc: Priyanka Jain <priyanka.jain@nxp.com>
> > >> Reported-by: Michael Walle <michael@walle.cc>
> > >> Signed-off-by: Tom Rini <trini@konsulko.com>
> > >> ---
> > >> arch/arm/cpu/armv8/fsl-layerscape/soc.c | 17 +----------------
> > >> arch/arm/dts/fsl-ls1028a.dtsi | 6 ------
> > >> arch/arm/dts/fsl-ls1088a.dtsi | 6 ------
> > >> arch/arm/dts/fsl-ls2080a.dtsi | 6 ------
> > >> arch/arm/dts/fsl-lx2160a.dtsi | 6 ------
> > >> 5 files changed, 1 insertion(+), 40 deletions(-)
> > >>
> > >> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> > >> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> > >> index 42a096854629..166662a64baf 100644
> > >> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> > >> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> > >> @@ -43,22 +43,7 @@ DECLARE_GLOBAL_DATA_PTR; #ifdef
> > >CONFIG_GIC_V3_ITS
> > >> int ls_gic_rd_tables_init(void *blob) {
> > >> - struct fdt_memory lpi_base;
> > >> - fdt_addr_t addr;
> > >> - fdt_size_t size;
> > >> - int offset, ret;
> > >> -
> > >> - offset = fdt_path_offset(gd->fdt_blob, "/syscon@0x80000000");
> > >> - addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, offset,
> > >> "reg",
> > >> - 0, &size, false);
> > >> -
> > >> - lpi_base.start = addr;
> > >> - lpi_base.end = addr + size - 1;
> > >> - ret = fdtdec_add_reserved_memory(blob, "lpi_rd_table", &lpi_base,
> > >> NULL, false);
> > >> - if (ret) {
> > >> - debug("%s: failed to add reserved memory\n", __func__);
> > >> - return ret;
> > >> - }
> > >> + int ret;
> > >>
> > >> ret = gic_lpi_tables_init();
> > >> if (ret)
> > >> diff --git a/arch/arm/dts/fsl-ls1028a.dtsi
> > >> b/arch/arm/dts/fsl-ls1028a.dtsi index 50f9b527cde1..53b052ed3271
> > >> 100644
> > >> --- a/arch/arm/dts/fsl-ls1028a.dtsi
> > >> +++ b/arch/arm/dts/fsl-ls1028a.dtsi
> > >> @@ -44,12 +44,6 @@
> > >> IRQ_TYPE_LEVEL_LOW)>;
> > >> };
> > >>
> > >> - gic_lpi_base: syscon@0x80000000 {
> > >> - compatible = "gic-lpi-base";
> > >> - reg = <0x0 0x80000000 0x0 0x100000>;
> > >> - max-gic-redistributors = <2>;
> > >> - };
> > >> -
> > >> timer {
> > >> compatible = "arm,armv8-timer";
> > >> interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | diff --git
> > >> a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi index
> > >> 64caa600ad77..3a5a50fb8313 100644
> > >> --- a/arch/arm/dts/fsl-ls1088a.dtsi
> > >> +++ b/arch/arm/dts/fsl-ls1088a.dtsi
> > >> @@ -27,12 +27,6 @@
> > >> interrupts = <1 9 0x4>;
> > >> };
> > >>
> > >> - gic_lpi_base: syscon@0x80000000 {
> > >> - compatible = "gic-lpi-base";
> > >> - reg = <0x0 0x80000000 0x0 0x100000>;
> > >> - max-gic-redistributors = <8>;
> > >> - };
> > >> -
> > >> timer {
> > >> compatible = "arm,armv8-timer";
> > >> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
> > >> --git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi
> > >> index 7374d580e07e..278daeeb6eea 100644
> > >> --- a/arch/arm/dts/fsl-ls2080a.dtsi
> > >> +++ b/arch/arm/dts/fsl-ls2080a.dtsi
> > >> @@ -27,12 +27,6 @@
> > >> interrupts = <1 9 0x4>;
> > >> };
> > >>
> > >> - gic_lpi_base: syscon@0x80000000 {
> > >> - compatible = "gic-lpi-base";
> > >> - reg = <0x0 0x80000000 0x0 0x100000>;
> > >> - max-gic-redistributors = <8>;
> > >> - };
> > >> -
> > >> timer {
> > >> compatible = "arm,armv8-timer";
> > >> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
> > >> --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi
> > >> index
> > >> a6f0e9bc56be..3b5f0d119e76 100644
> > >> --- a/arch/arm/dts/fsl-lx2160a.dtsi
> > >> +++ b/arch/arm/dts/fsl-lx2160a.dtsi
> > >> @@ -43,12 +43,6 @@
> > >> interrupts = <1 9 0x4>;
> > >> };
> > >>
> > >> - gic_lpi_base: syscon@0x80000000 {
> > >> - compatible = "gic-lpi-base";
> > >> - reg = <0x0 0x80000000 0x0 0x200000>;
> > >> - max-gic-redistributors = <16>;
> > >> - };
> > >> -
> > >> timer {
> > >> compatible = "arm,armv8-timer";
> > >> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
> >
> > Tom,
> >
> > I agree that bindings patch is essential for device-tree changes.
> > But merging this patch will break Layerscape Platforms.
> > We have requested Rayagonda to submit Binding patch to upstream for review.
> >
> > If first patch of binding gets submitted timely, can we defer this patch.
> >
> > Regards
> > Priyanka
> >
>
> ++Bharat, Roman and Henrik.
Yes, please keep me in the loop on this binding being reviewed upstream.
Also, please check the tree for other bindings that haven't been
submitted, but also haven't been noticed yet. There is not supposed to
be anything outside of the -u-boot.dtsi files that can't be replaced by
dropping in a newer set of upstream dts files. And the -u-boot.dtsi
files are for u-boot specific bindings (that we're working on
upstreaming) or actively in-review bindings upstream.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset
2021-09-13 13:13 ` Tom Rini
@ 2021-10-24 18:02 ` Michael Walle
0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2021-10-24 18:02 UTC (permalink / raw)
To: trini
Cc: bharat.gooty, henrik.christensen, priyanka.jain,
rayagonda.kokatanur, roman.bacik, u-boot, zhiqiang.hou,
Michael Walle
>On Mon, Sep 13, 2021 at 01:22:10PM +0530, Rayagonda Kokatanur wrote:
>> On Mon, Sep 13, 2021 at 11:29 AM Priyanka Jain (OSS)
>> <priyanka.jain@oss.nxp.com> wrote:
..
>> > Tom,
>> >
>> > I agree that bindings patch is essential for device-tree changes.
>> > But merging this patch will break Layerscape Platforms.
>> > We have requested Rayagonda to submit Binding patch to upstream for review.
>> >
>> > If first patch of binding gets submitted timely, can we defer this patch.
>> >
>> > Regards
>> > Priyanka
>> >
>> ++Bharat, Roman and Henrik.
>
> Yes, please keep me in the loop on this binding being reviewed upstream.
> Also, please check the tree for other bindings that haven't been
> submitted, but also haven't been noticed yet. There is not supposed to
> be anything outside of the -u-boot.dtsi files that can't be replaced by
> dropping in a newer set of upstream dts files. And the -u-boot.dtsi
> files are for u-boot specific bindings (that we're working on
> upstreaming) or actively in-review bindings upstream.
Are there any news on this topic? Was there a submission to linux for the
binding in the meantime? Unfortunately, I wasn't in the loop here (albeit
being the Reported-by: one). Until now, this patch is a prerequisite for my
ls1028a device tree sync series [1].
-michael
[1] https://lore.kernel.org/u-boot/20211013161427.612033-1-michael@walle.cc/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-24 18:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 21:05 [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround" Tom Rini
2021-09-10 6:42 ` Z.Q. Hou
2021-09-13 5:59 ` Priyanka Jain (OSS)
2021-09-13 7:52 ` Rayagonda Kokatanur
2021-09-13 13:13 ` Tom Rini
2021-10-24 18:02 ` [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset Michael Walle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.