[linux-next:master 1605/10320] sound/pci/via82xx_modem.c:1102 snd_via82xx_create() warn: 'pci' not released on lines: 1086.

[linux-next:master 1605/10320] sound/pci/via82xx_modem.c:1102 snd_via82xx_create() warn: 'pci' not released on lines: 1086.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4687 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Takashi Iwai <tiwai@suse.de>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   7636510f976d75b860848884169ba985c8f844d8
commit: afaf99751d0c906914fd958432b648db2ccdf1bb [1605/10320] ALSA: via82xx: Allocate resources with device-managed APIs
:::::: branch date: 7 hours ago
:::::: commit date: 5 weeks ago
config: x86_64-randconfig-m001-20210825 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
sound/pci/via82xx_modem.c:1102 snd_via82xx_create() warn: 'pci' not released on lines: 1086.
sound/pci/via82xx.c:2370 snd_via82xx_create() warn: 'pci' not released on lines: 2354.

vim +/pci +1102 sound/pci/via82xx_modem.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  1060  
e23e7a14362072 Bill Pemberton 2012-12-06  1061  static int snd_via82xx_create(struct snd_card *card,
^1da177e4c3f41 Linus Torvalds 2005-04-16  1062  			      struct pci_dev *pci,
^1da177e4c3f41 Linus Torvalds 2005-04-16  1063  			      int chip_type,
^1da177e4c3f41 Linus Torvalds 2005-04-16  1064  			      int revision,
afaf99751d0c90 Takashi Iwai   2021-07-15  1065  			      unsigned int ac97_clock)
^1da177e4c3f41 Linus Torvalds 2005-04-16  1066  {
afaf99751d0c90 Takashi Iwai   2021-07-15  1067  	struct via82xx_modem *chip = card->private_data;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1068  	int err;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1069  
afaf99751d0c90 Takashi Iwai   2021-07-15  1070  	err = pcim_enable_device(pci);
afb342f02241a9 Takashi Iwai   2021-06-08  1071  	if (err < 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16  1072  		return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1073  
^1da177e4c3f41 Linus Torvalds 2005-04-16  1074  	spin_lock_init(&chip->reg_lock);
^1da177e4c3f41 Linus Torvalds 2005-04-16  1075  	chip->card = card;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1076  	chip->pci = pci;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1077  	chip->irq = -1;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1078  
afb342f02241a9 Takashi Iwai   2021-06-08  1079  	err = pci_request_regions(pci, card->driver);
afaf99751d0c90 Takashi Iwai   2021-07-15  1080  	if (err < 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16  1081  		return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1082  	chip->port = pci_resource_start(pci, 0);
afaf99751d0c90 Takashi Iwai   2021-07-15  1083  	if (devm_request_irq(&pci->dev, pci->irq, snd_via82xx_interrupt,
afaf99751d0c90 Takashi Iwai   2021-07-15  1084  			     IRQF_SHARED, KBUILD_MODNAME, chip)) {
473439e06a2562 Takashi Iwai   2014-02-25  1085  		dev_err(card->dev, "unable to grab IRQ %d\n", pci->irq);
^1da177e4c3f41 Linus Torvalds 2005-04-16  1086  		return -EBUSY;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1087  	}
^1da177e4c3f41 Linus Torvalds 2005-04-16  1088  	chip->irq = pci->irq;
c47583b0eb6847 Takashi Iwai   2019-12-10  1089  	card->sync_irq = chip->irq;
afaf99751d0c90 Takashi Iwai   2021-07-15  1090  	card->private_free = snd_via82xx_free;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1091  	if (ac97_clock >= 8000 && ac97_clock <= 48000)
^1da177e4c3f41 Linus Torvalds 2005-04-16  1092  		chip->ac97_clock = ac97_clock;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1093  
afb342f02241a9 Takashi Iwai   2021-06-08  1094  	err = snd_via82xx_chip_init(chip);
afaf99751d0c90 Takashi Iwai   2021-07-15  1095  	if (err < 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16  1096  		return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1097  
^1da177e4c3f41 Linus Torvalds 2005-04-16  1098  	/* The 8233 ac97 controller does not implement the master bit
^1da177e4c3f41 Linus Torvalds 2005-04-16  1099  	 * in the pci command register. IMHO this is a violation of the PCI spec.
^1da177e4c3f41 Linus Torvalds 2005-04-16  1100  	 * We call pci_set_master here because it does not hurt. */
^1da177e4c3f41 Linus Torvalds 2005-04-16  1101  	pci_set_master(pci);
^1da177e4c3f41 Linus Torvalds 2005-04-16 @1102  	return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  1103  }
^1da177e4c3f41 Linus Torvalds 2005-04-16  1104  

:::::: The code@line 1102 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32896 bytes --]