[linux-next:master 1616/10320] sound/pci/ice1712/ice1724.c:2512 snd_vt1724_create() warn: 'pci' not released on lines: 2499.

[linux-next:master 1616/10320] sound/pci/ice1712/ice1724.c:2512 snd_vt1724_create() warn: 'pci' not released on lines: 2499.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 5708 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Takashi Iwai <tiwai@suse.de>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   7636510f976d75b860848884169ba985c8f844d8
commit: 272d6efa0b43f34c435937ad99db5289e460b05e [1616/10320] ALSA: ice1724: Allocate resources with device-managed APIs
:::::: branch date: 9 hours ago
:::::: commit date: 5 weeks ago
config: x86_64-randconfig-m001-20210825 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
sound/pci/ice1712/ice1724.c:2512 snd_vt1724_create() warn: 'pci' not released on lines: 2499.

Old smatch warnings:
sound/pci/ice1712/ice1724.c:2473 snd_vt1724_create() error: potentially dereferencing uninitialized 'ice'.

vim +/pci +2512 sound/pci/ice1712/ice1724.c

^1da177e4c3f41 Linus Torvalds      2005-04-16  2460  
e23e7a14362072 Bill Pemberton      2012-12-06  2461  static int snd_vt1724_create(struct snd_card *card,
^1da177e4c3f41 Linus Torvalds      2005-04-16  2462  			     struct pci_dev *pci,
272d6efa0b43f3 Takashi Iwai        2021-07-15  2463  			     const char *modelname)
^1da177e4c3f41 Linus Torvalds      2005-04-16  2464  {
ab0c7d72c32d70 Takashi Iwai        2005-11-17  2465  	struct snd_ice1712 *ice;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2466  	int err;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2467  
^1da177e4c3f41 Linus Torvalds      2005-04-16  2468  	/* enable PCI device */
272d6efa0b43f3 Takashi Iwai        2021-07-15  2469  	err = pcim_enable_device(pci);
1de9fdc24b0186 Alexander Beregalov 2008-09-07  2470  	if (err < 0)
^1da177e4c3f41 Linus Torvalds      2005-04-16  2471  		return err;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2472  
^1da177e4c3f41 Linus Torvalds      2005-04-16  2473  	ice->vt1724 = 1;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2474  	spin_lock_init(&ice->reg_lock);
62932df8fb20ba Ingo Molnar         2006-01-16  2475  	mutex_init(&ice->gpio_mutex);
62932df8fb20ba Ingo Molnar         2006-01-16  2476  	mutex_init(&ice->open_mutex);
62932df8fb20ba Ingo Molnar         2006-01-16  2477  	mutex_init(&ice->i2c_mutex);
^1da177e4c3f41 Linus Torvalds      2005-04-16  2478  	ice->gpio.set_mask = snd_vt1724_set_gpio_mask;
494703062b6e6e Pavel Hofman        2009-09-16  2479  	ice->gpio.get_mask = snd_vt1724_get_gpio_mask;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2480  	ice->gpio.set_dir = snd_vt1724_set_gpio_dir;
494703062b6e6e Pavel Hofman        2009-09-16  2481  	ice->gpio.get_dir = snd_vt1724_get_gpio_dir;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2482  	ice->gpio.set_data = snd_vt1724_set_gpio_data;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2483  	ice->gpio.get_data = snd_vt1724_get_gpio_data;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2484  	ice->card = card;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2485  	ice->pci = pci;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2486  	ice->irq = -1;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2487  	pci_set_master(pci);
^1da177e4c3f41 Linus Torvalds      2005-04-16  2488  	snd_vt1724_proc_init(ice);
^1da177e4c3f41 Linus Torvalds      2005-04-16  2489  
1de9fdc24b0186 Alexander Beregalov 2008-09-07  2490  	err = pci_request_regions(pci, "ICE1724");
272d6efa0b43f3 Takashi Iwai        2021-07-15  2491  	if (err < 0)
^1da177e4c3f41 Linus Torvalds      2005-04-16  2492  		return err;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2493  	ice->port = pci_resource_start(pci, 0);
^1da177e4c3f41 Linus Torvalds      2005-04-16  2494  	ice->profi_port = pci_resource_start(pci, 1);
^1da177e4c3f41 Linus Torvalds      2005-04-16  2495  
272d6efa0b43f3 Takashi Iwai        2021-07-15  2496  	if (devm_request_irq(&pci->dev, pci->irq, snd_vt1724_interrupt,
934c2b6d0cb50f Takashi Iwai        2011-06-10  2497  			     IRQF_SHARED, KBUILD_MODNAME, ice)) {
6dfb5aff7d922b Takashi Iwai        2014-02-25  2498  		dev_err(card->dev, "unable to grab IRQ %d\n", pci->irq);
^1da177e4c3f41 Linus Torvalds      2005-04-16  2499  		return -EIO;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2500  	}
^1da177e4c3f41 Linus Torvalds      2005-04-16  2501  
^1da177e4c3f41 Linus Torvalds      2005-04-16  2502  	ice->irq = pci->irq;
b0ad3bbc1e1ba1 Takashi Iwai        2019-12-10  2503  	card->sync_irq = ice->irq;
272d6efa0b43f3 Takashi Iwai        2021-07-15  2504  	card->private_free = snd_vt1724_free;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2505  
988f0664779674 Karsten Wiese       2008-04-22  2506  	snd_vt1724_chip_reset(ice);
272d6efa0b43f3 Takashi Iwai        2021-07-15  2507  	if (snd_vt1724_read_eeprom(ice, modelname) < 0)
^1da177e4c3f41 Linus Torvalds      2005-04-16  2508  		return -EIO;
272d6efa0b43f3 Takashi Iwai        2021-07-15  2509  	if (snd_vt1724_chip_init(ice) < 0)
^1da177e4c3f41 Linus Torvalds      2005-04-16  2510  		return -EIO;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2511  
^1da177e4c3f41 Linus Torvalds      2005-04-16 @2512  	return 0;
^1da177e4c3f41 Linus Torvalds      2005-04-16  2513  }
^1da177e4c3f41 Linus Torvalds      2005-04-16  2514  

:::::: The code@line 2512 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32896 bytes --]