* drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2640 eb_pin_engine() warn: inconsistent returns '&tl->mutex'.
@ 2021-08-25 20:26 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-08-25 20:26 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 7398 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
CC: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
CC: "Thomas Hellström" <thomas.hellstrom@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 6e764bcd1cf72a2846c0e53d3975a09b242c04c9
commit: 2bf541ff6d06f4169e198adaa6c4133e178caaa5 drm/i915: Pin engine before pinning all objects, v5.
date: 12 months ago
:::::: branch date: 28 hours ago
:::::: commit date: 12 months ago
config: i386-randconfig-m021-20210825 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2640 eb_pin_engine() warn: inconsistent returns '&tl->mutex'.
Old smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_object.h:130 __i915_gem_object_lock() error: we previously assumed 'ww' could be null (see line 122)
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1246 reloc_move_to_gpu() warn: maybe use && instead of &
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2162 eb_move_to_gpu() warn: maybe use && instead of &
drivers/gpu/drm/i915/gem/i915_gem_context.h:205 i915_gem_context_get_engine() warn: inconsistent indenting
drivers/gpu/drm/i915/gem/i915_gem_context.h:207 i915_gem_context_get_engine() warn: inconsistent indenting
vim +2640 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
e5dadff4b09376 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2598
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2599 static struct i915_request *eb_pin_engine(struct i915_execbuffer *eb, bool throttle)
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2600 {
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2601 struct intel_context *ce = eb->context;
e5dadff4b09376 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2602 struct intel_timeline *tl;
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2603 struct i915_request *rq = NULL;
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2604 int err;
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2605
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2606 GEM_BUG_ON(eb->args->flags & __EXEC_ENGINE_PINNED);
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2607
9f3ccd40acf4a3 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-12-20 2608 if (unlikely(intel_context_is_banned(ce)))
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2609 return ERR_PTR(-EIO);
9f3ccd40acf4a3 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-12-20 2610
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2611 /*
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2612 * Pinning the contexts may generate requests in order to acquire
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2613 * GGTT space, so do this first before we reserve a seqno for
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2614 * ourselves.
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2615 */
2850748ef8763a drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-10-04 2616 err = intel_context_pin(ce);
fa9f668141f4e5 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-26 2617 if (err)
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2618 return ERR_PTR(err);
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2619
a4e57f9031ccd5 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2620 /*
a4e57f9031ccd5 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2621 * Take a local wakeref for preparing to dispatch the execbuf as
a4e57f9031ccd5 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2622 * we expect to access the hardware fairly frequently in the
a4e57f9031ccd5 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2623 * process, and require the engine to be kept awake between accesses.
a4e57f9031ccd5 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2624 * Upon dispatch, we acquire another prolonged wakeref that we hold
a4e57f9031ccd5 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2625 * until the timeline is idle, which in turn releases the wakeref
a4e57f9031ccd5 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2626 * taken on the engine, and the parent device.
a4e57f9031ccd5 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2627 */
e5dadff4b09376 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2628 tl = intel_context_timeline_lock(ce);
e5dadff4b09376 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2629 if (IS_ERR(tl)) {
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2630 intel_context_unpin(ce);
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2631 return ERR_CAST(tl);
e5dadff4b09376 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2632 }
a4e57f9031ccd5 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2633
a4e57f9031ccd5 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2634 intel_context_enter(ce);
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2635 if (throttle)
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2636 rq = eb_throttle(eb, ce);
e5dadff4b09376 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2637 intel_context_timeline_unlock(tl);
e5dadff4b09376 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2638
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2639 eb->args->flags |= __EXEC_ENGINE_PINNED;
2bf541ff6d06f4 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 @2640 return rq;
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2641 }
8f2a1057d6ec21 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2642
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35613 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2640 eb_pin_engine() warn: inconsistent returns '&tl->mutex'.
@ 2021-07-02 3:27 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-07-02 3:27 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 7442 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
CC: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
CC: "Thomas Hellström" <thomas.hellstrom@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3dbdb38e286903ec220aaf1fb29a8d94297da246
commit: 2bf541ff6d06f4169e198adaa6c4133e178caaa5 drm/i915: Pin engine before pinning all objects, v5.
date: 10 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 10 months ago
config: i386-randconfig-m021-20210702 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2640 eb_pin_engine() warn: inconsistent returns '&tl->mutex'.
Old smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_object.h:130 __i915_gem_object_lock() error: we previously assumed 'ww' could be null (see line 122)
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1246 reloc_move_to_gpu() warn: maybe use && instead of &
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2162 eb_move_to_gpu() warn: maybe use && instead of &
drivers/gpu/drm/i915/gem/i915_gem_context.h:205 i915_gem_context_get_engine() warn: inconsistent indenting
drivers/gpu/drm/i915/gem/i915_gem_context.h:207 i915_gem_context_get_engine() warn: inconsistent indenting
vim +2640 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
e5dadff4b09376e drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2598
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2599 static struct i915_request *eb_pin_engine(struct i915_execbuffer *eb, bool throttle)
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2600 {
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2601 struct intel_context *ce = eb->context;
e5dadff4b09376e drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2602 struct intel_timeline *tl;
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2603 struct i915_request *rq = NULL;
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2604 int err;
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2605
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2606 GEM_BUG_ON(eb->args->flags & __EXEC_ENGINE_PINNED);
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2607
9f3ccd40acf4a34 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-12-20 2608 if (unlikely(intel_context_is_banned(ce)))
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2609 return ERR_PTR(-EIO);
9f3ccd40acf4a34 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-12-20 2610
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2611 /*
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2612 * Pinning the contexts may generate requests in order to acquire
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2613 * GGTT space, so do this first before we reserve a seqno for
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2614 * ourselves.
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2615 */
2850748ef8763ab drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-10-04 2616 err = intel_context_pin(ce);
fa9f668141f4e55 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-26 2617 if (err)
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2618 return ERR_PTR(err);
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2619
a4e57f9031ccd54 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2620 /*
a4e57f9031ccd54 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2621 * Take a local wakeref for preparing to dispatch the execbuf as
a4e57f9031ccd54 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2622 * we expect to access the hardware fairly frequently in the
a4e57f9031ccd54 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2623 * process, and require the engine to be kept awake between accesses.
a4e57f9031ccd54 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2624 * Upon dispatch, we acquire another prolonged wakeref that we hold
a4e57f9031ccd54 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2625 * until the timeline is idle, which in turn releases the wakeref
a4e57f9031ccd54 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2626 * taken on the engine, and the parent device.
a4e57f9031ccd54 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2627 */
e5dadff4b09376e drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2628 tl = intel_context_timeline_lock(ce);
e5dadff4b09376e drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2629 if (IS_ERR(tl)) {
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2630 intel_context_unpin(ce);
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2631 return ERR_CAST(tl);
e5dadff4b09376e drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2632 }
a4e57f9031ccd54 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2633
a4e57f9031ccd54 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-04 2634 intel_context_enter(ce);
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2635 if (throttle)
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2636 rq = eb_throttle(eb, ce);
e5dadff4b09376e drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2637 intel_context_timeline_unlock(tl);
e5dadff4b09376e drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Chris Wilson 2019-08-15 2638
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 2639 eb->args->flags |= __EXEC_ENGINE_PINNED;
2bf541ff6d06f41 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c Maarten Lankhorst 2020-08-19 @2640 return rq;
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2641 }
8f2a1057d6ec217 drivers/gpu/drm/i915/i915_gem_execbuffer.c Chris Wilson 2019-04-25 2642
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42269 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-25 20:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 20:26 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2640 eb_pin_engine() warn: inconsistent returns '&tl->mutex' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-07-02 3:27 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.