* [xlnx:master 10741/12418] drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 752.
@ 2021-08-26 5:01 kernel test robot
2021-08-26 5:01 ` [PATCH] v4l: xilinx-vpss-csc: fix for_each_child.cocci warnings kernel test robot
0 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2021-08-26 5:01 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Rohit Athavale <rohit.athavale@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
tree: https://github.com/Xilinx/linux-xlnx master
head: 45cd0074cdf1ddd710b28848e6a860b442babfcc
commit: 7d47a653da2e81cb73f43e507664d36305819ea1 [10741/12418] v4l: xilinx-vpss-csc: driver support for xilinx vpss csc
:::::: branch date: 3 days ago
:::::: commit date: 5 months ago
config: mips-randconfig-c023-20210825 (attached as .config)
compiler: mips64el-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 752.
drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 758.
drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 763.
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42477 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] v4l: xilinx-vpss-csc: fix for_each_child.cocci warnings
2021-08-26 5:01 [xlnx:master 10741/12418] drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 752 kernel test robot
@ 2021-08-26 5:01 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-08-26 5:01 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2467 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Rohit Athavale <rohit.athavale@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 752.
drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 758.
drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 763.
Semantic patch information:
False positives can be due to function calls within the for_each
loop that may encapsulate an of_node_put.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Rohit Athavale <rohit.athavale@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://github.com/Xilinx/linux-xlnx master
head: 45cd0074cdf1ddd710b28848e6a860b442babfcc
commit: 7d47a653da2e81cb73f43e507664d36305819ea1 [10741/12418] v4l: xilinx-vpss-csc: driver support for xilinx vpss csc
:::::: branch date: 3 days ago
:::::: commit date: 5 months ago
Please take the patch only if it's a positive warning. Thanks!
xilinx-vpss-csc.c | 3 +++
1 file changed, 3 insertions(+)
--- a/drivers/media/platform/xilinx/xilinx-vpss-csc.c
+++ b/drivers/media/platform/xilinx/xilinx-vpss-csc.c
@@ -749,17 +749,20 @@ static int xcsc_parse_of(struct xcsc_dev
vip_format = xvip_of_get_format(port);
if (IS_ERR(vip_format)) {
dev_err(dev, "Invalid media pad format in DT");
+ of_node_put(port);
return PTR_ERR(vip_format);
}
rval = of_property_read_u32(port, "reg", &port_id);
if (rval < 0) {
dev_err(dev, "No reg in DT to specify pad");
+ of_node_put(port);
return rval;
}
if (port_id != 0 && port_id != 1) {
dev_err(dev, "Invalid reg in DT");
+ of_node_put(port);
return -EINVAL;
}
xcsc->vip_formats[port_id] = vip_format;
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] v4l: xilinx-vpss-csc: fix for_each_child.cocci warnings
@ 2021-08-28 11:04 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2021-08-28 11:04 UTC (permalink / raw)
To: Rohit Athavale
Cc: kbuild-all, linux-arm-kernel, Rohit Athavale, Michal Simek,
Hyun Kwon, Laurent Pinchart, Mauro Carvalho Chehab, linux-media,
linux-arm-kernel, linux-kernel
From: kernel test robot <lkp@intel.com>
for_each_child_of_node should have of_node_put() before return.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Rohit Athavale <rohit.athavale@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://github.com/Xilinx/linux-xlnx master
head: 45cd0074cdf1ddd710b28848e6a860b442babfcc
commit: 7d47a653da2e81cb73f43e507664d36305819ea1 [10741/12418] v4l: xilinx-vpss-csc: driver support for xilinx vpss csc
:::::: branch date: 5 days ago
:::::: commit date: 5 months ago
Please take the patch only if it's a positive warning. Thanks!
xilinx-vpss-csc.c | 3 +++
1 file changed, 3 insertions(+)
--- a/drivers/media/platform/xilinx/xilinx-vpss-csc.c
+++ b/drivers/media/platform/xilinx/xilinx-vpss-csc.c
@@ -749,17 +749,20 @@ static int xcsc_parse_of(struct xcsc_dev
vip_format = xvip_of_get_format(port);
if (IS_ERR(vip_format)) {
dev_err(dev, "Invalid media pad format in DT");
+ of_node_put(port);
return PTR_ERR(vip_format);
}
rval = of_property_read_u32(port, "reg", &port_id);
if (rval < 0) {
dev_err(dev, "No reg in DT to specify pad");
+ of_node_put(port);
return rval;
}
if (port_id != 0 && port_id != 1) {
dev_err(dev, "Invalid reg in DT");
+ of_node_put(port);
return -EINVAL;
}
xcsc->vip_formats[port_id] = vip_format;
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] v4l: xilinx-vpss-csc: fix for_each_child.cocci warnings
@ 2021-08-28 11:04 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2021-08-28 11:04 UTC (permalink / raw)
To: Rohit Athavale
Cc: kbuild-all, linux-arm-kernel, Rohit Athavale, Michal Simek,
Hyun Kwon, Laurent Pinchart, Mauro Carvalho Chehab, linux-media,
linux-arm-kernel, linux-kernel
From: kernel test robot <lkp@intel.com>
for_each_child_of_node should have of_node_put() before return.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Rohit Athavale <rohit.athavale@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://github.com/Xilinx/linux-xlnx master
head: 45cd0074cdf1ddd710b28848e6a860b442babfcc
commit: 7d47a653da2e81cb73f43e507664d36305819ea1 [10741/12418] v4l: xilinx-vpss-csc: driver support for xilinx vpss csc
:::::: branch date: 5 days ago
:::::: commit date: 5 months ago
Please take the patch only if it's a positive warning. Thanks!
xilinx-vpss-csc.c | 3 +++
1 file changed, 3 insertions(+)
--- a/drivers/media/platform/xilinx/xilinx-vpss-csc.c
+++ b/drivers/media/platform/xilinx/xilinx-vpss-csc.c
@@ -749,17 +749,20 @@ static int xcsc_parse_of(struct xcsc_dev
vip_format = xvip_of_get_format(port);
if (IS_ERR(vip_format)) {
dev_err(dev, "Invalid media pad format in DT");
+ of_node_put(port);
return PTR_ERR(vip_format);
}
rval = of_property_read_u32(port, "reg", &port_id);
if (rval < 0) {
dev_err(dev, "No reg in DT to specify pad");
+ of_node_put(port);
return rval;
}
if (port_id != 0 && port_id != 1) {
dev_err(dev, "Invalid reg in DT");
+ of_node_put(port);
return -EINVAL;
}
xcsc->vip_formats[port_id] = vip_format;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] v4l: xilinx-vpss-csc: fix for_each_child.cocci warnings
@ 2021-08-28 11:04 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2021-08-28 11:04 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
From: kernel test robot <lkp@intel.com>
for_each_child_of_node should have of_node_put() before return.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Rohit Athavale <rohit.athavale@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://github.com/Xilinx/linux-xlnx master
head: 45cd0074cdf1ddd710b28848e6a860b442babfcc
commit: 7d47a653da2e81cb73f43e507664d36305819ea1 [10741/12418] v4l: xilinx-vpss-csc: driver support for xilinx vpss csc
:::::: branch date: 5 days ago
:::::: commit date: 5 months ago
Please take the patch only if it's a positive warning. Thanks!
xilinx-vpss-csc.c | 3 +++
1 file changed, 3 insertions(+)
--- a/drivers/media/platform/xilinx/xilinx-vpss-csc.c
+++ b/drivers/media/platform/xilinx/xilinx-vpss-csc.c
@@ -749,17 +749,20 @@ static int xcsc_parse_of(struct xcsc_dev
vip_format = xvip_of_get_format(port);
if (IS_ERR(vip_format)) {
dev_err(dev, "Invalid media pad format in DT");
+ of_node_put(port);
return PTR_ERR(vip_format);
}
rval = of_property_read_u32(port, "reg", &port_id);
if (rval < 0) {
dev_err(dev, "No reg in DT to specify pad");
+ of_node_put(port);
return rval;
}
if (port_id != 0 && port_id != 1) {
dev_err(dev, "Invalid reg in DT");
+ of_node_put(port);
return -EINVAL;
}
xcsc->vip_formats[port_id] = vip_format;
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] v4l: xilinx-vpss-csc: fix for_each_child.cocci warnings
2021-08-28 9:19 [xlnx:master 10741/12418] drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 752 kernel test robot
@ 2021-08-28 9:19 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-08-28 9:19 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2467 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Rohit Athavale <rohit.athavale@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 752.
drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 758.
drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 763.
Semantic patch information:
False positives can be due to function calls within the for_each
loop that may encapsulate an of_node_put.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Rohit Athavale <rohit.athavale@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://github.com/Xilinx/linux-xlnx master
head: 45cd0074cdf1ddd710b28848e6a860b442babfcc
commit: 7d47a653da2e81cb73f43e507664d36305819ea1 [10741/12418] v4l: xilinx-vpss-csc: driver support for xilinx vpss csc
:::::: branch date: 5 days ago
:::::: commit date: 5 months ago
Please take the patch only if it's a positive warning. Thanks!
xilinx-vpss-csc.c | 3 +++
1 file changed, 3 insertions(+)
--- a/drivers/media/platform/xilinx/xilinx-vpss-csc.c
+++ b/drivers/media/platform/xilinx/xilinx-vpss-csc.c
@@ -749,17 +749,20 @@ static int xcsc_parse_of(struct xcsc_dev
vip_format = xvip_of_get_format(port);
if (IS_ERR(vip_format)) {
dev_err(dev, "Invalid media pad format in DT");
+ of_node_put(port);
return PTR_ERR(vip_format);
}
rval = of_property_read_u32(port, "reg", &port_id);
if (rval < 0) {
dev_err(dev, "No reg in DT to specify pad");
+ of_node_put(port);
return rval;
}
if (port_id != 0 && port_id != 1) {
dev_err(dev, "Invalid reg in DT");
+ of_node_put(port);
return -EINVAL;
}
xcsc->vip_formats[port_id] = vip_format;
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-28 11:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-26 5:01 [xlnx:master 10741/12418] drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 752 kernel test robot
2021-08-26 5:01 ` [PATCH] v4l: xilinx-vpss-csc: fix for_each_child.cocci warnings kernel test robot
2021-08-28 9:19 [xlnx:master 10741/12418] drivers/media/platform/xilinx/xilinx-vpss-csc.c:747:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 752 kernel test robot
2021-08-28 9:19 ` [PATCH] v4l: xilinx-vpss-csc: fix for_each_child.cocci warnings kernel test robot
2021-08-28 11:04 Julia Lawall
2021-08-28 11:04 ` Julia Lawall
2021-08-28 11:04 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.