* [PATCH v2] board: ea: mx7ulp_com: move setting CONFIG_BOOTCOMMAND to defconfig
@ 2021-08-26 11:04 Oleksandr Suvorov
2021-08-26 11:51 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Oleksandr Suvorov @ 2021-08-26 11:04 UTC (permalink / raw)
To: u-boot; +Cc: Fabio Estevam, Ricardo Salveti, Oleksandr Suvorov
From: Ricardo Salveti <ricardo@foundries.io>
Move setting CONFIG_BOOTCOMMAND to the mx7ulp_com_defconfig file.
It also allows replacing the default CONFIG_BOOTCOMMAND without
code modification.
Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
---
Changes in v2:
- move setting the command to defconfig
configs/mx7ulp_com_defconfig | 2 ++
include/configs/mx7ulp_com.h | 5 -----
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/configs/mx7ulp_com_defconfig b/configs/mx7ulp_com_defconfig
index 62992fecdf..5fcf25a7fb 100644
--- a/configs/mx7ulp_com_defconfig
+++ b/configs/mx7ulp_com_defconfig
@@ -9,6 +9,8 @@ CONFIG_DEFAULT_DEVICE_TREE="imx7ulp-com"
CONFIG_LDO_ENABLED_MODE=y
CONFIG_TARGET_MX7ULP_COM=y
CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/ea/mx7ulp_com/imximage.cfg"
+CONFIG_USE_BOOTCOMMAND=y
+CONFIG_BOOTCOMMAND="if run loadimage; then run mmcboot; fi"
CONFIG_DEFAULT_FDT_FILE="imx7ulp-com"
CONFIG_BOARD_EARLY_INIT_F=y
CONFIG_HUSH_PARSER=y
diff --git a/include/configs/mx7ulp_com.h b/include/configs/mx7ulp_com.h
index 28672c4f94..3ef41e565a 100644
--- a/include/configs/mx7ulp_com.h
+++ b/include/configs/mx7ulp_com.h
@@ -69,11 +69,6 @@
"bootz ${loadaddr} - ${fdt_addr}; " \
"fi;\0" \
-#define CONFIG_BOOTCOMMAND \
- "if run loadimage; then " \
- "run mmcboot; " \
- "fi; " \
-
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
#define CONFIG_SYS_INIT_RAM_ADDR IRAM_BASE_ADDR
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] board: ea: mx7ulp_com: move setting CONFIG_BOOTCOMMAND to defconfig
2021-08-26 11:04 [PATCH v2] board: ea: mx7ulp_com: move setting CONFIG_BOOTCOMMAND to defconfig Oleksandr Suvorov
@ 2021-08-26 11:51 ` Fabio Estevam
2021-08-27 2:54 ` Tom Rini
2021-10-20 12:20 ` sbabic
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2021-08-26 11:51 UTC (permalink / raw)
To: Oleksandr Suvorov; +Cc: U-Boot-Denx, Ricardo Salveti
Hi Oleksandr,
On Thu, Aug 26, 2021 at 8:04 AM Oleksandr Suvorov
<oleksandr.suvorov@foundries.io> wrote:
>
> From: Ricardo Salveti <ricardo@foundries.io>
>
> Move setting CONFIG_BOOTCOMMAND to the mx7ulp_com_defconfig file.
> It also allows replacing the default CONFIG_BOOTCOMMAND without
> code modification.
>
> Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> ---
>
> Changes in v2:
> - move setting the command to defconfig
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] board: ea: mx7ulp_com: move setting CONFIG_BOOTCOMMAND to defconfig
2021-08-26 11:04 [PATCH v2] board: ea: mx7ulp_com: move setting CONFIG_BOOTCOMMAND to defconfig Oleksandr Suvorov
2021-08-26 11:51 ` Fabio Estevam
@ 2021-08-27 2:54 ` Tom Rini
2021-10-20 12:20 ` sbabic
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2021-08-27 2:54 UTC (permalink / raw)
To: Oleksandr Suvorov; +Cc: u-boot, Fabio Estevam, Ricardo Salveti
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
On Thu, Aug 26, 2021 at 02:04:24PM +0300, Oleksandr Suvorov wrote:
> From: Ricardo Salveti <ricardo@foundries.io>
>
> Move setting CONFIG_BOOTCOMMAND to the mx7ulp_com_defconfig file.
> It also allows replacing the default CONFIG_BOOTCOMMAND without
> code modification.
>
> Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] board: ea: mx7ulp_com: move setting CONFIG_BOOTCOMMAND to defconfig
2021-08-26 11:04 [PATCH v2] board: ea: mx7ulp_com: move setting CONFIG_BOOTCOMMAND to defconfig Oleksandr Suvorov
2021-08-26 11:51 ` Fabio Estevam
2021-08-27 2:54 ` Tom Rini
@ 2021-10-20 12:20 ` sbabic
2 siblings, 0 replies; 4+ messages in thread
From: sbabic @ 2021-10-20 12:20 UTC (permalink / raw)
To: Oleksandr Suvorov, u-boot
> From: Ricardo Salveti <ricardo@foundries.io>
> Move setting CONFIG_BOOTCOMMAND to the mx7ulp_com_defconfig file.
> It also allows replacing the default CONFIG_BOOTCOMMAND without
> code modification.
> Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-20 12:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-26 11:04 [PATCH v2] board: ea: mx7ulp_com: move setting CONFIG_BOOTCOMMAND to defconfig Oleksandr Suvorov
2021-08-26 11:51 ` Fabio Estevam
2021-08-27 2:54 ` Tom Rini
2021-10-20 12:20 ` sbabic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.