[PATCH v2 0/2] Remove unsupported features in SNR CPU model

[PATCH v2 0/2] Remove unsupported features in SNR CPU model

[Chenyi Qiang]

Patch 1: https://lore.kernel.org/qemu-devel/20210825195438.914387-2-ehabkost@redhat.com/

Patch 2 removes one more feature (core-capability) in Snowridge-v4 CPU
model based on previous patch.

Chenyi Qiang (2):
  target/i386: Remove split lock detect in Snowridge CPU model
  target/i386: Remove core-capability in Snowridge CPU model

 target/i386/cpu.c | 9 +++++++++
 1 file changed, 9 insertions(+)

-- 
2.17.1

[PATCH v2 1/2] target/i386: Remove split lock detect in Snowridge CPU model

[Chenyi Qiang]

At present, there's no mechanism intelligent enough to virtualize split
lock detection correctly. Remove it in Snowridge CPU model to avoid the
feature exposure.

Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
Message-Id: <20210630012053.10098-1-chenyi.qiang@intel.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target/i386/cpu.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 34a7ce865b..aebf81d9c9 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -3682,6 +3682,14 @@ static const X86CPUDefinition builtin_x86_defs[] = {
                     { /* end of list */ },
                 },
             },
+            {
+                .version = 4,
+                .note = "no split lock detect",
+                .props = (PropValue[]) {
+                    { "split-lock-detect", "off" },
+                    { /* end of list */ },
+                },
+            },
             { /* end of list */ },
         },
     },
-- 
2.17.1

[PATCH v2 2/2] target/i386: Remove core-capability in Snowridge CPU model

[Chenyi Qiang]

Because core-capability releated features are model-specific and KVM
won't support it, remove the core-capability in CPU model to avoid the
warning message.

Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
---
 target/i386/cpu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index aebf81d9c9..86a15af1ed 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -3684,9 +3684,10 @@ static const X86CPUDefinition builtin_x86_defs[] = {
             },
             {
                 .version = 4,
-                .note = "no split lock detect",
+                .note = "no split lock detect, no core-capability",
                 .props = (PropValue[]) {
                     { "split-lock-detect", "off" },
+                    { "core-capability", "off" },
                     { /* end of list */ },
                 },
             },
-- 
2.17.1

Re: [PATCH v2 2/2] target/i386: Remove core-capability in Snowridge CPU model

[Chenyi Qiang]

Hi Eduardo,

Ping for this minor change.

On 8/27/2021 2:48 PM, Chenyi Qiang wrote:
> Because core-capability releated features are model-specific and KVM
> won't support it, remove the core-capability in CPU model to avoid the
> warning message.
> 
> Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
> ---
>   target/i386/cpu.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index aebf81d9c9..86a15af1ed 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -3684,9 +3684,10 @@ static const X86CPUDefinition builtin_x86_defs[] = {
>               },
>               {
>                   .version = 4,
> -                .note = "no split lock detect",
> +                .note = "no split lock detect, no core-capability",
>                   .props = (PropValue[]) {
>                       { "split-lock-detect", "off" },
> +                    { "core-capability", "off" },
>                       { /* end of list */ },
>                   },
>               },
> 

Re: [PATCH v2 0/2] Remove unsupported features in SNR CPU model

[Eduardo Habkost]

On Fri, Aug 27, 2021 at 02:48:16PM +0800, Chenyi Qiang wrote:
> Patch 1: https://lore.kernel.org/qemu-devel/20210825195438.914387-2-ehabkost@redhat.com/
> 
> Patch 2 removes one more feature (core-capability) in Snowridge-v4 CPU
> model based on previous patch.
> 
> Chenyi Qiang (2):
>   target/i386: Remove split lock detect in Snowridge CPU model
>   target/i386: Remove core-capability in Snowridge CPU model

Patch 2/2 queued (patch 1/2 was already merged).  Thanks and
apologies for the delay.

-- 
Eduardo