All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] network/netstress: fix stdout/stderr log file flags and mode
@ 2021-08-27  8:34 Alexey Kodanev
  2021-09-09 11:00   ` Petr Vorel
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Kodanev @ 2021-08-27  8:34 UTC (permalink / raw)
  To: ltp

* fix access mode for stdout/stderr

* add a write bit to the mode so that the next time the server
  starts, it doesn't fail with EACCES because the log file
  already exists and has read-only permissions.

Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
---
 testcases/network/netstress/netstress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/network/netstress/netstress.c b/testcases/network/netstress/netstress.c
index c46bc86c3..03b1563dc 100644
--- a/testcases/network/netstress/netstress.c
+++ b/testcases/network/netstress/netstress.c
@@ -723,7 +723,7 @@ static void move_to_background(void)
 	close(STDOUT_FILENO);
 	close(STDERR_FILENO);
 
-	int fd = SAFE_OPEN(log_path, O_CREAT | O_TRUNC | O_RDONLY, 00444);
+	int fd = SAFE_OPEN(log_path, O_CREAT | O_TRUNC | O_WRONLY, 0644);
 
 	SAFE_DUP(fd);
 }
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [LTP] [PATCH] network/netstress: fix stdout/stderr log file flags and mode
@ 2021-09-09 11:00   ` Petr Vorel
  0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2021-09-09 11:00 UTC (permalink / raw)
  To: Alexey Kodanev; +Cc: ltp

Hi Alexey,

good catch!

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-09 11:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27  8:34 [LTP] [PATCH] network/netstress: fix stdout/stderr log file flags and mode Alexey Kodanev
2021-09-09 11:00 ` Petr Vorel
2021-09-09 11:00   ` Petr Vorel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.