From: Andrew Jones <drjones@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>,
kvm@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com,
cohuck@redhat.com, imbrenda@linux.ibm.com,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 1/2] Makefile: Fix cscope
Date: Fri, 27 Aug 2021 12:22:04 +0200 [thread overview]
Message-ID: <20210827102204.3y6gdpchn77cz7yo@gator.home> (raw)
In-Reply-To: <2aaffea2-0a20-1a6d-eebb-69b6cfe6e83c@linux.ibm.com>
On Fri, Aug 27, 2021 at 11:26:38AM +0200, Pierre Morel wrote:
>
>
> On 8/26/21 7:07 AM, Thomas Huth wrote:
> > On 25/08/2021 18.20, Pierre Morel wrote:
> > > In Linux, cscope uses a wrong directory.
> > > Simply search from the directory where the make is started.
> > >
> > > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> > > ---
> > > Makefile | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index f7b9f28c..c8b0d74f 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -119,7 +119,7 @@ cscope: cscope_dirs = lib lib/libfdt lib/linux
> > > $(TEST_DIR) $(ARCH_LIBDIRS) lib/a
> > > cscope:
> > > $(RM) ./cscope.*
> > > find -L $(cscope_dirs) -maxdepth 1 \
> > > - -name '*.[chsS]' -exec realpath --relative-base=$(PWD) {}
> > > \; | sort -u > ./cscope.files
> > > + -name '*.[chsS]' -exec realpath --relative-base=. {} \; |
> > > sort -u > ./cscope.files
> >
> > Why is $PWD not pointing to the same location as "." ? Are you doing
> > in-tree or out-of-tree builds?
> >
> > Thomas
> >
>
> In tree.
> That is the point, why is PWD indicating void ?
If you do 'env' I'll bet you'll see something like
...
PWD=
...
> I use a bash on s390x.
> inside bash PWD shows current directory
> GNU Make is 4.2.1 on Ubuntu 18.04
>
> This works on X with redhat and GNU make 3.82
>
> This happens on s390x since:
> 51b8f0b1 2017-11-23 Andrew Jones Makefile: fix cscope target
No surprise there, that's when the $(PWD) use was first introduced.
>
> So I add Andrew as CC, I did forgot to do before.
>
I'll send a patch changing $(PWD) to $(shell pwd)
Thanks,
drew
next prev parent reply other threads:[~2021-08-27 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 16:20 [kvm-unit-tests PATCH 0/2] Two fixes for KVM unit tests Pierre Morel
2021-08-25 16:20 ` [kvm-unit-tests PATCH 1/2] Makefile: Fix cscope Pierre Morel
2021-08-26 5:07 ` Thomas Huth
2021-08-27 9:26 ` Pierre Morel
2021-08-27 10:22 ` Andrew Jones [this message]
2021-09-20 13:27 ` Paolo Bonzini
2021-09-20 14:10 ` Andrew Jones
2021-09-20 18:04 ` Paolo Bonzini
2021-09-21 6:58 ` Andrew Jones
2021-08-27 10:22 ` Thomas Huth
2021-08-25 16:20 ` [kvm-unit-tests PATCH 2/2] s390x: fixing I/O memory allocation Pierre Morel
2021-08-25 16:31 ` Claudio Imbrenda
2021-08-27 9:39 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210827102204.3y6gdpchn77cz7yo@gator.home \
--to=drjones@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.