All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: Pierre Morel <pmorel@linux.ibm.com>,
	Thomas Huth <thuth@redhat.com>,
	kvm@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com,
	cohuck@redhat.com, imbrenda@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH 1/2] Makefile: Fix cscope
Date: Mon, 20 Sep 2021 20:04:02 +0200	[thread overview]
Message-ID: <7b2d795b-a65c-1983-868c-b4ae38d939f8@redhat.com> (raw)
In-Reply-To: <20210920141039.jfb2iektdzdjldy5@gator>

On 20/09/21 16:10, Andrew Jones wrote:
> Hi Paolo,
> 
> You'll get a conflict when you go to merge because I already did it :-)
> 
> commit 3d4eb24cb5b4de6c26f79b849fe2818d5315a691 (origin/misc/queue, misc/queue)
> Author: Andrew Jones <drjones@redhat.com>
> Date:   Fri Aug 27 12:25:27 2021 +0200
> 
>      Makefile: Don't trust PWD
>      
>      PWD comes from the environment and it's possible that it's already
>      set to something which isn't the full path of the current working
>      directory. Use the make variable $(CURDIR) instead.
>      
>      Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
>      Reviewed-by: Thomas Huth <thuth@redhat.com>
>      Suggested-by: Thomas Huth <thuth@redhat.com>
>      Signed-off-by: Andrew Jones <drjones@redhat.com>
> 
> 
> 
> misc/queue is something I recently invented for stuff like this in order
> to help lighten your load a bit.

Ok, are you going to create a merge request?


  reply	other threads:[~2021-09-20 18:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 16:20 [kvm-unit-tests PATCH 0/2] Two fixes for KVM unit tests Pierre Morel
2021-08-25 16:20 ` [kvm-unit-tests PATCH 1/2] Makefile: Fix cscope Pierre Morel
2021-08-26  5:07   ` Thomas Huth
2021-08-27  9:26     ` Pierre Morel
2021-08-27 10:22       ` Andrew Jones
2021-09-20 13:27         ` Paolo Bonzini
2021-09-20 14:10           ` Andrew Jones
2021-09-20 18:04             ` Paolo Bonzini [this message]
2021-09-21  6:58               ` Andrew Jones
2021-08-27 10:22       ` Thomas Huth
2021-08-25 16:20 ` [kvm-unit-tests PATCH 2/2] s390x: fixing I/O memory allocation Pierre Morel
2021-08-25 16:31   ` Claudio Imbrenda
2021-08-27  9:39     ` Pierre Morel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b2d795b-a65c-1983-868c-b4ae38d939f8@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=drjones@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=pmorel@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.