From: kernel test robot <lkp@intel.com> To: Michael Chan <michael.chan@broadcom.com>, davem@davemloft.net Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, netdev@vger.kernel.org, kuba@kernel.org, edwin.peer@broadcom.com, gospo@broadcom.com Subject: Re: [PATCH net-next 09/11] bnxt_en: update all firmware calls to use the new APIs Date: Sun, 29 Aug 2021 11:49:52 +0800 [thread overview] Message-ID: <202108291102.ABZVwXXv-lkp@intel.com> (raw) In-Reply-To: <1630187910-22252-10-git-send-email-michael.chan@broadcom.com> [-- Attachment #1: Type: text/plain, Size: 5585 bytes --] Hi Michael, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-Implement-new-driver-APIs-to-send-FW-messages/20210829-060031 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c77225119daa0ca0a9c6c007945c0a87b3e4a2e8 config: i386-randconfig-a002-20210829 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4e1a164d7bd53653f79decc121afe784d2fde0a7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/0202eb069086d82c68032e9f5db76e0b4cd5a4ca git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Michael-Chan/bnxt_en-Implement-new-driver-APIs-to-send-FW-messages/20210829-060031 git checkout 0202eb069086d82c68032e9f5db76e0b4cd5a4ca # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): clang-14: warning: optimization flag '-falign-jumps=0' is not supported [-Wignored-optimization-argument] In file included from drivers/net/ethernet/broadcom/bnxt/bnxt.c:11: In file included from include/linux/module.h:14: In file included from include/linux/buildid.h:5: In file included from include/linux/mm_types.h:9: In file included from include/linux/spinlock.h:51: In file included from include/linux/preempt.h:78: In file included from arch/x86/include/asm/preempt.h:7: In file included from include/linux/thread_info.h:60: arch/x86/include/asm/thread_info.h:172:13: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address] oldframe = __builtin_frame_address(1); ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/x86/include/asm/thread_info.h:174:11: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address] frame = __builtin_frame_address(2); ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/broadcom/bnxt/bnxt.c:5996:2: warning: variable 'req' is uninitialized when used here [-Wuninitialized] req->fid = cpu_to_le16(fid); ^~~ drivers/net/ethernet/broadcom/bnxt/bnxt.c:5990:34: note: initialize the variable 'req' to silence this warning struct hwrm_func_qcfg_input *req; ^ = NULL 3 warnings generated. -- clang-14: warning: optimization flag '-falign-jumps=0' is not supported [-Wignored-optimization-argument] In file included from drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:11: In file included from include/linux/ethtool.h:17: In file included from include/linux/compat.h:14: In file included from include/linux/sem.h:5: In file included from include/uapi/linux/sem.h:5: In file included from include/linux/ipc.h:5: In file included from include/linux/spinlock.h:51: In file included from include/linux/preempt.h:78: In file included from arch/x86/include/asm/preempt.h:7: In file included from include/linux/thread_info.h:60: arch/x86/include/asm/thread_info.h:172:13: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address] oldframe = __builtin_frame_address(1); ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/x86/include/asm/thread_info.h:174:11: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address] frame = __builtin_frame_address(2); ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1163:7: warning: variable 'rc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (is_valid_ether_addr(bp->vf.mac_addr)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1178:6: note: uninitialized use occurs here if (rc && strict) { ^~ drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1163:3: note: remove the 'if' if its condition is always true if (is_valid_ether_addr(bp->vf.mac_addr)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1157:8: note: initialize the variable 'rc' to silence this warning int rc; ^ = 0 3 warnings generated. vim +/req +5996 drivers/net/ethernet/broadcom/bnxt/bnxt.c 5986 5987 int __bnxt_hwrm_get_tx_rings(struct bnxt *bp, u16 fid, int *tx_rings) 5988 { 5989 struct hwrm_func_qcfg_output *resp; 5990 struct hwrm_func_qcfg_input *req; 5991 int rc; 5992 5993 if (bp->hwrm_spec_code < 0x10601) 5994 return 0; 5995 > 5996 req->fid = cpu_to_le16(fid); 5997 resp = hwrm_req_hold(bp, req); 5998 rc = hwrm_req_send(bp, req); 5999 if (!rc) 6000 *tx_rings = le16_to_cpu(resp->alloc_tx_rings); 6001 6002 hwrm_req_drop(bp, req); 6003 return rc; 6004 } 6005 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 43243 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH net-next 09/11] bnxt_en: update all firmware calls to use the new APIs Date: Sun, 29 Aug 2021 11:49:52 +0800 [thread overview] Message-ID: <202108291102.ABZVwXXv-lkp@intel.com> (raw) In-Reply-To: <1630187910-22252-10-git-send-email-michael.chan@broadcom.com> [-- Attachment #1: Type: text/plain, Size: 5695 bytes --] Hi Michael, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-Implement-new-driver-APIs-to-send-FW-messages/20210829-060031 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c77225119daa0ca0a9c6c007945c0a87b3e4a2e8 config: i386-randconfig-a002-20210829 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4e1a164d7bd53653f79decc121afe784d2fde0a7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/0202eb069086d82c68032e9f5db76e0b4cd5a4ca git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Michael-Chan/bnxt_en-Implement-new-driver-APIs-to-send-FW-messages/20210829-060031 git checkout 0202eb069086d82c68032e9f5db76e0b4cd5a4ca # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): clang-14: warning: optimization flag '-falign-jumps=0' is not supported [-Wignored-optimization-argument] In file included from drivers/net/ethernet/broadcom/bnxt/bnxt.c:11: In file included from include/linux/module.h:14: In file included from include/linux/buildid.h:5: In file included from include/linux/mm_types.h:9: In file included from include/linux/spinlock.h:51: In file included from include/linux/preempt.h:78: In file included from arch/x86/include/asm/preempt.h:7: In file included from include/linux/thread_info.h:60: arch/x86/include/asm/thread_info.h:172:13: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address] oldframe = __builtin_frame_address(1); ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/x86/include/asm/thread_info.h:174:11: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address] frame = __builtin_frame_address(2); ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/broadcom/bnxt/bnxt.c:5996:2: warning: variable 'req' is uninitialized when used here [-Wuninitialized] req->fid = cpu_to_le16(fid); ^~~ drivers/net/ethernet/broadcom/bnxt/bnxt.c:5990:34: note: initialize the variable 'req' to silence this warning struct hwrm_func_qcfg_input *req; ^ = NULL 3 warnings generated. -- clang-14: warning: optimization flag '-falign-jumps=0' is not supported [-Wignored-optimization-argument] In file included from drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:11: In file included from include/linux/ethtool.h:17: In file included from include/linux/compat.h:14: In file included from include/linux/sem.h:5: In file included from include/uapi/linux/sem.h:5: In file included from include/linux/ipc.h:5: In file included from include/linux/spinlock.h:51: In file included from include/linux/preempt.h:78: In file included from arch/x86/include/asm/preempt.h:7: In file included from include/linux/thread_info.h:60: arch/x86/include/asm/thread_info.h:172:13: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address] oldframe = __builtin_frame_address(1); ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/x86/include/asm/thread_info.h:174:11: warning: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address] frame = __builtin_frame_address(2); ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1163:7: warning: variable 'rc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (is_valid_ether_addr(bp->vf.mac_addr)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1178:6: note: uninitialized use occurs here if (rc && strict) { ^~ drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1163:3: note: remove the 'if' if its condition is always true if (is_valid_ether_addr(bp->vf.mac_addr)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:1157:8: note: initialize the variable 'rc' to silence this warning int rc; ^ = 0 3 warnings generated. vim +/req +5996 drivers/net/ethernet/broadcom/bnxt/bnxt.c 5986 5987 int __bnxt_hwrm_get_tx_rings(struct bnxt *bp, u16 fid, int *tx_rings) 5988 { 5989 struct hwrm_func_qcfg_output *resp; 5990 struct hwrm_func_qcfg_input *req; 5991 int rc; 5992 5993 if (bp->hwrm_spec_code < 0x10601) 5994 return 0; 5995 > 5996 req->fid = cpu_to_le16(fid); 5997 resp = hwrm_req_hold(bp, req); 5998 rc = hwrm_req_send(bp, req); 5999 if (!rc) 6000 *tx_rings = le16_to_cpu(resp->alloc_tx_rings); 6001 6002 hwrm_req_drop(bp, req); 6003 return rc; 6004 } 6005 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 43243 bytes --]
next prev parent reply other threads:[~2021-08-29 3:50 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-28 21:58 [PATCH net-next 00/11] bnxt_en: Implement new driver APIs to send FW messages Michael Chan 2021-08-28 21:58 ` [PATCH net-next 01/11] bnxt_en: remove DMA mapping for KONG response Michael Chan 2021-08-28 21:58 ` [PATCH net-next 02/11] bnxt_en: Refactor the HWRM_VER_GET firmware calls Michael Chan 2021-08-28 21:58 ` [PATCH net-next 03/11] bnxt_en: move HWRM API implementation into separate file Michael Chan 2021-08-28 21:58 ` [PATCH net-next 04/11] bnxt_en: introduce new firmware message API based on DMA pools Michael Chan 2021-08-29 0:13 ` kernel test robot 2021-08-29 0:13 ` kernel test robot 2021-08-28 21:58 ` [PATCH net-next 05/11] bnxt_en: discard out of sequence HWRM responses Michael Chan 2021-08-28 21:58 ` [PATCH net-next 06/11] bnxt_en: add HWRM request assignment API Michael Chan 2021-08-28 21:58 ` [PATCH net-next 07/11] bnxt_en: add support for HWRM request slices Michael Chan 2021-08-28 21:58 ` [PATCH net-next 08/11] bnxt_en: use link_lock instead of hwrm_cmd_lock to protect link_info Michael Chan 2021-08-28 21:58 ` [PATCH net-next 09/11] bnxt_en: update all firmware calls to use the new APIs Michael Chan 2021-08-29 3:49 ` kernel test robot [this message] 2021-08-29 3:49 ` kernel test robot 2021-08-28 21:58 ` [PATCH net-next 10/11] bnxt_en: remove legacy HWRM interface Michael Chan 2021-08-28 21:58 ` [PATCH net-next 11/11] bnxt_en: support multiple HWRM commands in flight Michael Chan 2021-08-28 22:07 ` [PATCH net-next 00/11] bnxt_en: Implement new driver APIs to send FW messages Andrew Lunn 2021-08-28 22:58 ` Michael Chan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202108291102.ABZVwXXv-lkp@intel.com \ --to=lkp@intel.com \ --cc=davem@davemloft.net \ --cc=edwin.peer@broadcom.com \ --cc=gospo@broadcom.com \ --cc=kbuild-all@lists.01.org \ --cc=kuba@kernel.org \ --cc=llvm@lists.linux.dev \ --cc=michael.chan@broadcom.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.