From: Jonathan Cameron <jic23@kernel.org> To: Billy Tsai <billy_tsai@aspeedtech.com> Cc: Rob Herring <robh@kernel.org>, "lars@metafoo.de" <lars@metafoo.de>, "pmeerw@pmeerw.net" <pmeerw@pmeerw.net>, "joel@jms.id.au" <joel@jms.id.au>, "andrew@aj.id.au" <andrew@aj.id.au>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "lgirdwood@gmail.com" <lgirdwood@gmail.com>, "broonie@kernel.org" <broonie@kernel.org>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, BMC-SW <BMC-SW@aspeedtech.com> Subject: Re: [v4 01/15] dt-bindings: iio: adc: Add ast2600-adc bindings Date: Sun, 29 Aug 2021 15:53:44 +0100 [thread overview] Message-ID: <20210829155344.370348d1@jic23-huawei> (raw) In-Reply-To: <DEB9D606-6489-4993-A5E7-6E4F3226EE5A@aspeedtech.com> On Wed, 25 Aug 2021 00:06:47 +0000 Billy Tsai <billy_tsai@aspeedtech.com> wrote: > Hi Rob, > > On 2021/8/24, 8:13 PM, "Rob Herring" <robh@kernel.org> wrote: > > On Mon, Aug 23, 2021 at 03:02:26PM +0800, Billy Tsai wrote: > > > +properties: > > > + compatible: > > > + enum: > > > + - aspeed,ast2600-adc0 > > > + - aspeed,ast2600-adc1 > > > What's the difference between 0 and 1? > > Their trimming data, which is used to calibrate internal reference volage, > locates in different address of OTP. At very least document that with a description: here to avoid anyone looking at this later asking the same question! Jonathan > > Best Regards, > Billy Tsai > > >
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Billy Tsai <billy_tsai@aspeedtech.com> Cc: Rob Herring <robh@kernel.org>, "lars@metafoo.de" <lars@metafoo.de>, "pmeerw@pmeerw.net" <pmeerw@pmeerw.net>, "joel@jms.id.au" <joel@jms.id.au>, "andrew@aj.id.au" <andrew@aj.id.au>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "lgirdwood@gmail.com" <lgirdwood@gmail.com>, "broonie@kernel.org" <broonie@kernel.org>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, BMC-SW <BMC-SW@aspeedtech.com> Subject: Re: [v4 01/15] dt-bindings: iio: adc: Add ast2600-adc bindings Date: Sun, 29 Aug 2021 15:53:44 +0100 [thread overview] Message-ID: <20210829155344.370348d1@jic23-huawei> (raw) In-Reply-To: <DEB9D606-6489-4993-A5E7-6E4F3226EE5A@aspeedtech.com> On Wed, 25 Aug 2021 00:06:47 +0000 Billy Tsai <billy_tsai@aspeedtech.com> wrote: > Hi Rob, > > On 2021/8/24, 8:13 PM, "Rob Herring" <robh@kernel.org> wrote: > > On Mon, Aug 23, 2021 at 03:02:26PM +0800, Billy Tsai wrote: > > > +properties: > > > + compatible: > > > + enum: > > > + - aspeed,ast2600-adc0 > > > + - aspeed,ast2600-adc1 > > > What's the difference between 0 and 1? > > Their trimming data, which is used to calibrate internal reference volage, > locates in different address of OTP. At very least document that with a description: here to avoid anyone looking at this later asking the same question! Jonathan > > Best Regards, > Billy Tsai > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-29 14:50 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-23 7:02 [v4 00/15] Add support for ast2600 ADC Billy Tsai 2021-08-23 7:02 ` Billy Tsai 2021-08-23 7:02 ` [v4 01/15] dt-bindings: iio: adc: Add ast2600-adc bindings Billy Tsai 2021-08-23 7:02 ` Billy Tsai 2021-08-24 12:13 ` Rob Herring 2021-08-24 12:13 ` Rob Herring 2021-08-25 0:06 ` Billy Tsai 2021-08-25 0:06 ` Billy Tsai 2021-08-29 14:53 ` Jonathan Cameron [this message] 2021-08-29 14:53 ` Jonathan Cameron 2021-08-23 7:02 ` [v4 02/15] iio: adc: aspeed: completes the bitfield declare Billy Tsai 2021-08-23 7:02 ` Billy Tsai 2021-08-23 7:02 ` [v4 03/15] iio: adc: aspeed: set driver data when adc probe Billy Tsai 2021-08-23 7:02 ` Billy Tsai 2021-08-23 7:02 ` [v4 04/15] iio: adc: aspeed: Keep model data to driver data Billy Tsai 2021-08-23 7:02 ` Billy Tsai 2021-08-23 7:02 ` [v4 05/15] iio: adc: aspeed: Refactory model data structure Billy Tsai 2021-08-23 7:02 ` Billy Tsai 2021-08-23 7:02 ` [v4 06/15] iio: adc: aspeed: Add vref config function Billy Tsai 2021-08-23 7:02 ` Billy Tsai 2021-08-23 7:02 ` [v4 07/15] iio: adc: aspeed: Set num_channels with model data Billy Tsai 2021-08-23 7:02 ` Billy Tsai 2021-08-23 7:02 ` [v4 08/15] iio: adc: aspeed: Use model_data to set clk scaler Billy Tsai 2021-08-23 7:02 ` Billy Tsai 2021-08-23 7:02 ` [v4 09/15] iio: adc: aspeed: Use devm_add_action_or_reset Billy Tsai 2021-08-23 7:02 ` Billy Tsai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210829155344.370348d1@jic23-huawei \ --to=jic23@kernel.org \ --cc=BMC-SW@aspeedtech.com \ --cc=andrew@aj.id.au \ --cc=billy_tsai@aspeedtech.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=lars@metafoo.de \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=pmeerw@pmeerw.net \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.