From: Matthew Hagan <mnhagan88@gmail.com> To: unlisted-recipients:; (no To-header on input) Cc: Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>, Matthew Hagan <mnhagan88@gmail.com>, Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/5] ARM: dts: NSP: Fix MDIO mux node names Date: Sun, 29 Aug 2021 22:37:49 +0000 [thread overview] Message-ID: <20210829223752.2748091-3-mnhagan88@gmail.com> (raw) In-Reply-To: <20210829223752.2748091-1-mnhagan88@gmail.com> While functional, the mdio-mux-mmioreg binding does not conform to Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml in that an mdio-mux compatible is also required. Without this the following output is observed when running dtbs_check: mdio-mux@32000: compatible: ['mdio-mux-mmioreg'] is too short This change brings conformance to this requirement and corresponds likewise to Rafal Milecki's change to the BCM5301x platform[1]. [1] https://lore.kernel.org/linux-arm-kernel/20210822191256.3715003-1-f.fainelli@gmail.com/T/ Signed-off-by: Matthew Hagan <mnhagan88@gmail.com> --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi index 6f2ccd059e73..180827500f25 100644 --- a/arch/arm/boot/dts/bcm-nsp.dtsi +++ b/arch/arm/boot/dts/bcm-nsp.dtsi @@ -371,7 +371,7 @@ mdio: mdio@32000 { }; mdio-mux@32000 { - compatible = "mdio-mux-mmioreg"; + compatible = "mdio-mux-mmioreg", "mdio-mux"; reg = <0x32000 0x4>; mux-mask = <0x200>; #address-cells = <1>; diff --git a/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi b/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi index 8860f2fefc63..57d0c5eb9749 100644 --- a/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi +++ b/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi @@ -72,7 +72,7 @@ led-5 { }; mdio-mii-mux { - compatible = "mdio-mux-mmioreg"; + compatible = "mdio-mux-mmioreg", "mdio-mux"; reg = <0x1803f1c0 0x4>; mux-mask = <0x2000>; mdio-parent-bus = <&mdio_ext>; -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Hagan <mnhagan88@gmail.com> Cc: Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>, Matthew Hagan <mnhagan88@gmail.com>, Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/5] ARM: dts: NSP: Fix MDIO mux node names Date: Sun, 29 Aug 2021 22:37:49 +0000 [thread overview] Message-ID: <20210829223752.2748091-3-mnhagan88@gmail.com> (raw) In-Reply-To: <20210829223752.2748091-1-mnhagan88@gmail.com> While functional, the mdio-mux-mmioreg binding does not conform to Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml in that an mdio-mux compatible is also required. Without this the following output is observed when running dtbs_check: mdio-mux@32000: compatible: ['mdio-mux-mmioreg'] is too short This change brings conformance to this requirement and corresponds likewise to Rafal Milecki's change to the BCM5301x platform[1]. [1] https://lore.kernel.org/linux-arm-kernel/20210822191256.3715003-1-f.fainelli@gmail.com/T/ Signed-off-by: Matthew Hagan <mnhagan88@gmail.com> --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi index 6f2ccd059e73..180827500f25 100644 --- a/arch/arm/boot/dts/bcm-nsp.dtsi +++ b/arch/arm/boot/dts/bcm-nsp.dtsi @@ -371,7 +371,7 @@ mdio: mdio@32000 { }; mdio-mux@32000 { - compatible = "mdio-mux-mmioreg"; + compatible = "mdio-mux-mmioreg", "mdio-mux"; reg = <0x32000 0x4>; mux-mask = <0x200>; #address-cells = <1>; diff --git a/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi b/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi index 8860f2fefc63..57d0c5eb9749 100644 --- a/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi +++ b/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi @@ -72,7 +72,7 @@ led-5 { }; mdio-mii-mux { - compatible = "mdio-mux-mmioreg"; + compatible = "mdio-mux-mmioreg", "mdio-mux"; reg = <0x1803f1c0 0x4>; mux-mask = <0x2000>; mdio-parent-bus = <&mdio_ext>; -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-29 22:38 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-29 22:37 [PATCH v2 1/5] ARM: dts: NSP: Add bcm958623hr board name to dts Matthew Hagan 2021-08-29 22:37 ` Matthew Hagan 2021-08-29 22:37 ` [PATCH v2 2/5] ARM: dts: NSP: Fix mpcore, mmc node names Matthew Hagan 2021-08-29 22:37 ` Matthew Hagan 2021-09-02 21:05 ` Florian Fainelli 2021-09-02 21:05 ` Florian Fainelli 2021-08-29 22:37 ` Matthew Hagan [this message] 2021-08-29 22:37 ` [PATCH v2 3/5] ARM: dts: NSP: Fix MDIO mux " Matthew Hagan 2021-08-30 0:27 ` Andrew Lunn 2021-08-30 0:27 ` Andrew Lunn 2021-09-02 21:05 ` Florian Fainelli 2021-09-02 21:05 ` Florian Fainelli 2021-08-29 22:37 ` [PATCH v2 4/5] ARM: dts: NSP: Fix MX64/MX65 eeprom node name Matthew Hagan 2021-08-29 22:37 ` Matthew Hagan 2021-09-02 21:05 ` Florian Fainelli 2021-09-02 21:05 ` Florian Fainelli 2021-08-29 22:37 ` [PATCH v2 5/5] ARM: dts: NSP: Fix MX65 MDIO mux warnings Matthew Hagan 2021-08-29 22:37 ` Matthew Hagan 2021-09-02 21:06 ` Florian Fainelli 2021-09-02 21:06 ` Florian Fainelli 2021-09-02 21:04 ` [PATCH v2 1/5] ARM: dts: NSP: Add bcm958623hr board name to dts Florian Fainelli 2021-09-02 21:04 ` Florian Fainelli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210829223752.2748091-3-mnhagan88@gmail.com \ --to=mnhagan88@gmail.com \ --cc=andrew@lunn.ch \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rjui@broadcom.com \ --cc=robh+dt@kernel.org \ --cc=sbranden@broadcom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.