[PATCH] dev-manual: pass False to d.getVar() for devpyshell example

[PATCH] dev-manual: pass False to d.getVar() for devpyshell example

[Robert P. J. Day]

In the example in section 3.9, the call to d.getVar() needs to have
the additional arugment of "False" so that the output is not expanded.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  pretty sure it works this way.

diff --git a/documentation/dev-manual/common-tasks.rst b/documentation/dev-manual/common-tasks.rst
index 4a5011ea7..f3b508443 100644
--- a/documentation/dev-manual/common-tasks.rst
+++ b/documentation/dev-manual/common-tasks.rst
@@ -3486,7 +3486,7 @@ functions::

    pydevshell> d.getVar("STAGING_DIR")
    '/media/build1/poky/build/tmp/sysroots'
-   pydevshell> d.getVar("STAGING_DIR")
+   pydevshell> d.getVar("STAGING_DIR", False)
    '${TMPDIR}/sysroots'
    pydevshell> d.setVar("FOO", "bar")
    pydevshell> d.getVar("FOO")

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                         http://crashcourse.ca

LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [docs] [PATCH] dev-manual: pass False to d.getVar() for devpyshell example

[Quentin Schulz]

Hi Robert,

On Mon, Aug 30, 2021 at 08:05:30AM -0400, Robert P. J. Day wrote:
> 
> In the example in section 3.9, the call to d.getVar() needs to have
> the additional arugment of "False" so that the output is not expanded.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
>   pretty sure it works this way.
> 

The second positional argument is indeed "expand", which by default is
true.

Reviewed-by: Quentin Schulz <foss@0leil.net>

Thanks!
Quentin

Re: [docs] [PATCH] dev-manual: pass False to d.getVar() for devpyshell example

[Michael Opdenacker]

On 8/30/21 3:10 PM, Quentin Schulz wrote:
> Hi Robert,
>
> On Mon, Aug 30, 2021 at 08:05:30AM -0400, Robert P. J. Day wrote:
>> In the example in section 3.9, the call to d.getVar() needs to have
>> the additional arugment of "False" so that the output is not expanded.
>>
>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>>
>> ---
>>
>>   pretty sure it works this way.
>>
> The second positional argument is indeed "expand", which by default is
> true.
>
> Reviewed-by: Quentin Schulz <foss@0leil.net>


Tested-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Now merged in "master-next".

Thanks for the patch and the review!

Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com