From: Richard Palethorpe <rpalethorpe@suse.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl
Date: Tue, 31 Aug 2021 13:25:53 +0100 [thread overview]
Message-ID: <20210831122554.14590-1-rpalethorpe@suse.com> (raw)
It is included in `make check` now.
Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
---
doc/maintainer-patch-review-checklist.txt | 3 +--
doc/test-writing-guidelines.txt | 5 ++---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/doc/maintainer-patch-review-checklist.txt b/doc/maintainer-patch-review-checklist.txt
index 58662bed1..c8ace80f7 100644
--- a/doc/maintainer-patch-review-checklist.txt
+++ b/doc/maintainer-patch-review-checklist.txt
@@ -38,8 +38,7 @@ New test should
### C tests
* Use new https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#22-writing-a-test-in-c[C API]
* Test binaries are added into corresponding '.gitignore' files
-* Check coding style with
- https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl[checkpatch.pl] and `make check`
+* Check coding style with `make check`
(more in https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#21-c-coding-style[C coding style])
* Docparse documentation
* If a test is a regression test it should include tags
diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt
index 340c80cc6..e95373e84 100644
--- a/doc/test-writing-guidelines.txt
+++ b/doc/test-writing-guidelines.txt
@@ -305,12 +305,11 @@ NOTE: See also
https://github.com/linux-test-project/ltp/wiki/Maintainer-Patch-Review-Checklist[Maintainer Patch Review Checklist].
1. Test compiles and runs fine (check with `-i 10` too)
-2. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl[checkpatch.pl]
- does not report any errors
+2. `make check` does not emit any warnings for the test you are working on
+ (hint: run it in the test's directory and/or use `make check-$TCID`)
3. The runtest entires are in place
4. Test binaries are added into corresponding '.gitignore' files
5. Patches apply over the latest git
-6. 'make check' does not emit any warnings
6.1 About .gitignore files
~~~~~~~~~~~~~~~~~~~~~~~~~~
--
2.31.1
next reply other threads:[~2021-08-31 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 12:25 Richard Palethorpe [this message]
2021-08-31 12:25 ` [LTP] [PATCH 2/2] docs: Fix typo 'entires' -> 'entries' Richard Palethorpe
2021-08-31 12:50 ` Petr Vorel
2021-08-31 13:19 ` Cyril Hrubis
2021-09-01 7:40 ` Petr Vorel
2021-08-31 12:52 ` [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl Petr Vorel
2021-08-31 13:18 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210831122554.14590-1-rpalethorpe@suse.com \
--to=rpalethorpe@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.