* [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl
@ 2021-08-31 12:25 Richard Palethorpe
2021-08-31 12:25 ` [LTP] [PATCH 2/2] docs: Fix typo 'entires' -> 'entries' Richard Palethorpe
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Richard Palethorpe @ 2021-08-31 12:25 UTC (permalink / raw)
To: ltp
It is included in `make check` now.
Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
---
doc/maintainer-patch-review-checklist.txt | 3 +--
doc/test-writing-guidelines.txt | 5 ++---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/doc/maintainer-patch-review-checklist.txt b/doc/maintainer-patch-review-checklist.txt
index 58662bed1..c8ace80f7 100644
--- a/doc/maintainer-patch-review-checklist.txt
+++ b/doc/maintainer-patch-review-checklist.txt
@@ -38,8 +38,7 @@ New test should
### C tests
* Use new https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#22-writing-a-test-in-c[C API]
* Test binaries are added into corresponding '.gitignore' files
-* Check coding style with
- https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl[checkpatch.pl] and `make check`
+* Check coding style with `make check`
(more in https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#21-c-coding-style[C coding style])
* Docparse documentation
* If a test is a regression test it should include tags
diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt
index 340c80cc6..e95373e84 100644
--- a/doc/test-writing-guidelines.txt
+++ b/doc/test-writing-guidelines.txt
@@ -305,12 +305,11 @@ NOTE: See also
https://github.com/linux-test-project/ltp/wiki/Maintainer-Patch-Review-Checklist[Maintainer Patch Review Checklist].
1. Test compiles and runs fine (check with `-i 10` too)
-2. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl[checkpatch.pl]
- does not report any errors
+2. `make check` does not emit any warnings for the test you are working on
+ (hint: run it in the test's directory and/or use `make check-$TCID`)
3. The runtest entires are in place
4. Test binaries are added into corresponding '.gitignore' files
5. Patches apply over the latest git
-6. 'make check' does not emit any warnings
6.1 About .gitignore files
~~~~~~~~~~~~~~~~~~~~~~~~~~
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [LTP] [PATCH 2/2] docs: Fix typo 'entires' -> 'entries'
2021-08-31 12:25 [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl Richard Palethorpe
@ 2021-08-31 12:25 ` Richard Palethorpe
2021-08-31 12:50 ` Petr Vorel
2021-08-31 12:52 ` [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl Petr Vorel
2021-08-31 13:18 ` Cyril Hrubis
2 siblings, 1 reply; 7+ messages in thread
From: Richard Palethorpe @ 2021-08-31 12:25 UTC (permalink / raw)
To: ltp
Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
---
doc/test-writing-guidelines.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt
index e95373e84..12fe4922a 100644
--- a/doc/test-writing-guidelines.txt
+++ b/doc/test-writing-guidelines.txt
@@ -307,7 +307,7 @@ NOTE: See also
1. Test compiles and runs fine (check with `-i 10` too)
2. `make check` does not emit any warnings for the test you are working on
(hint: run it in the test's directory and/or use `make check-$TCID`)
-3. The runtest entires are in place
+3. The runtest entries are in place
4. Test binaries are added into corresponding '.gitignore' files
5. Patches apply over the latest git
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [LTP] [PATCH 2/2] docs: Fix typo 'entires' -> 'entries'
2021-08-31 12:25 ` [LTP] [PATCH 2/2] docs: Fix typo 'entires' -> 'entries' Richard Palethorpe
@ 2021-08-31 12:50 ` Petr Vorel
2021-08-31 13:19 ` Cyril Hrubis
0 siblings, 1 reply; 7+ messages in thread
From: Petr Vorel @ 2021-08-31 12:50 UTC (permalink / raw)
To: ltp
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl
2021-08-31 12:25 [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl Richard Palethorpe
2021-08-31 12:25 ` [LTP] [PATCH 2/2] docs: Fix typo 'entires' -> 'entries' Richard Palethorpe
@ 2021-08-31 12:52 ` Petr Vorel
2021-08-31 13:18 ` Cyril Hrubis
2 siblings, 0 replies; 7+ messages in thread
From: Petr Vorel @ 2021-08-31 12:52 UTC (permalink / raw)
To: ltp
Hi Richie,
...
> 1. Test compiles and runs fine (check with `-i 10` too)
> -2. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl[checkpatch.pl]
> - does not report any errors
> +2. `make check` does not emit any warnings for the test you are working on
> + (hint: run it in the test's directory and/or use `make check-$TCID`)
Reviewed-by: Petr Vorel <pvorel@suse.cz>
I was thinking about mention what exactly make check does, but that'd again
require being kept in sync.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl
2021-08-31 12:25 [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl Richard Palethorpe
2021-08-31 12:25 ` [LTP] [PATCH 2/2] docs: Fix typo 'entires' -> 'entries' Richard Palethorpe
2021-08-31 12:52 ` [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl Petr Vorel
@ 2021-08-31 13:18 ` Cyril Hrubis
2 siblings, 0 replies; 7+ messages in thread
From: Cyril Hrubis @ 2021-08-31 13:18 UTC (permalink / raw)
To: ltp
Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH 2/2] docs: Fix typo 'entires' -> 'entries'
2021-08-31 12:50 ` Petr Vorel
@ 2021-08-31 13:19 ` Cyril Hrubis
2021-09-01 7:40 ` Petr Vorel
0 siblings, 1 reply; 7+ messages in thread
From: Cyril Hrubis @ 2021-08-31 13:19 UTC (permalink / raw)
To: ltp
Hi!
This is obviously fine.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH 2/2] docs: Fix typo 'entires' -> 'entries'
2021-08-31 13:19 ` Cyril Hrubis
@ 2021-09-01 7:40 ` Petr Vorel
0 siblings, 0 replies; 7+ messages in thread
From: Petr Vorel @ 2021-09-01 7:40 UTC (permalink / raw)
To: ltp
Hi Richie, Cyril,
thanks, merged!
Kind regards,
Petr
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-09-01 7:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-31 12:25 [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl Richard Palethorpe
2021-08-31 12:25 ` [LTP] [PATCH 2/2] docs: Fix typo 'entires' -> 'entries' Richard Palethorpe
2021-08-31 12:50 ` Petr Vorel
2021-08-31 13:19 ` Cyril Hrubis
2021-09-01 7:40 ` Petr Vorel
2021-08-31 12:52 ` [LTP] [PATCH 1/2] docs: rm explicit reference to checkpatch.pl Petr Vorel
2021-08-31 13:18 ` Cyril Hrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.