Re: [RFC][PATCH v2 12/13] iommu/arm-smmu-v3: Add support for NVIDIA CMDQ-Virtualization hw

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3718 bytes --]

Hi Nicolin,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on iommu/next]
[also build test WARNING on next-20210830]
[cannot apply to vfio/next linus/master v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicolin-Chen/iommu-arm-smmu-v3-Add-NVIDIA-implementation/20210831-111013
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: arm64-randconfig-r015-20210831 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/9a22c788ed0320df4a0fb8689c3113d0bd0a91da
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nicolin-Chen/iommu-arm-smmu-v3-Add-NVIDIA-implementation/20210831-111013
        git checkout 9a22c788ed0320df4a0fb8689c3113d0bd0a91da
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/iommu/arm/arm-smmu-v3/nvidia-smmu-v3.c:410:21: warning: no previous prototype for function 'nvidia_smmu_create' [-Wmissing-prototypes]
   struct nvidia_smmu *nvidia_smmu_create(struct arm_smmu_device *smmu)
                       ^
   drivers/iommu/arm/arm-smmu-v3/nvidia-smmu-v3.c:410:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct nvidia_smmu *nvidia_smmu_create(struct arm_smmu_device *smmu)
   ^
   static 
   1 warning generated.


vim +/nvidia_smmu_create +410 drivers/iommu/arm/arm-smmu-v3/nvidia-smmu-v3.c

   373	
   374	#ifdef CONFIG_ACPI
   375	struct nvidia_smmu *nvidia_smmu_create(struct arm_smmu_device *smmu)
   376	{
   377		struct nvidia_smmu *nsmmu = NULL;
   378		struct acpi_iort_node *node;
   379		struct acpi_device *adev;
   380		struct device *cmdqv_dev;
   381		const char *match_uid;
   382	
   383		if (acpi_disabled)
   384			return NULL;
   385	
   386		/* Look for a device in the DSDT whose _UID matches the SMMU's iort_node identifier */
   387		node = *(struct acpi_iort_node **)dev_get_platdata(smmu->dev);
   388		match_uid = kasprintf(GFP_KERNEL, "%u", node->identifier);
   389		adev = acpi_dev_get_first_match_dev(NVIDIA_SMMU_CMDQV_HID, match_uid, -1);
   390		kfree(match_uid);
   391	
   392		if (!adev)
   393			return NULL;
   394	
   395		cmdqv_dev = bus_find_device_by_acpi_dev(&platform_bus_type, adev);
   396		if (!cmdqv_dev)
   397			return NULL;
   398	
   399		dev_info(smmu->dev, "found companion CMDQV device, %s", dev_name(cmdqv_dev));
   400	
   401		nsmmu = devm_krealloc(smmu->dev, smmu, sizeof(*nsmmu), GFP_KERNEL);
   402		if (!nsmmu)
   403			return ERR_PTR(-ENOMEM);
   404	
   405		nsmmu->cmdqv_dev = cmdqv_dev;
   406	
   407		return nsmmu;
   408	}
   409	#else
 > 410	struct nvidia_smmu *nvidia_smmu_create(struct arm_smmu_device *smmu)
   411	{
   412		return NULL;
   413	}
   414	#endif
   415	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39823 bytes --]