Re: [PATCH 2/3] leds: add new LED_FUNCTION_PLAYER for player LEDs for game controllers.

From: Pavel Machek <pavel@ucw.cz>
To: Jiri Kosina <jikos@kernel.org>
Cc: "Daniel Ogorchock" <djogorchock@gmail.com>,
	"Roderick Colenbrander" <roderick@gaikai.com>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	linux-input <linux-input@vger.kernel.org>,
	linux-leds@vger.kernel.org,
	"Barnabás Pőcze" <pobrn@protonmail.com>,
	"Roderick Colenbrander" <roderick.colenbrander@sony.com>,
	"Roderick Colenbrander" <thunderbird2k@gmail.com>
Subject: Re: [PATCH 2/3] leds: add new LED_FUNCTION_PLAYER for player LEDs for game controllers.
Date: Wed, 1 Sep 2021 07:19:38 +0200	[thread overview]
Message-ID: <20210901051938.GA6870@amd> (raw)
In-Reply-To: <nycvar.YFH.7.76.2108312109340.15313@cbobk.fhfr.pm>

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

Hi!

> > Do you have any recommendations on what would be an appropriate
> > function string for player indicator LEDs? Would some variant such as:
> >   "status-x"
> >   "player-status-x"
> >   "indicator-x"
> >   "player-indicator-x"
> > be more suitable? It looks like the string "status" has been used for
> > other existing LED names.

I guess "player-x" would be suitable.

> > I think we are pretty happy to use whatever naming scheme fits the
> > standards of the led subsystem's userspace api for the Nintendo/Sony
> > HID drivers, and any future game controller drivers featuring player
> > LEDs could conform to that going forward.
> 
> Pavel, could you please take a look here, so that we can proceed with the 
> patchset?

So... leds tree has just been merged:

> git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/
tags/leds-5.15-rc1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a998a62be9cdb509491731ffe81575aa09943a32

It includes Documentation/leds/well-known-leds.txt file. Could a
section describing proposed naming be added there (both device and
function), with explanations what the LEDs do?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]