* [PATCH] driver/gpio: gpio-cherryview: call correct api to remove gpio device
@ 2021-09-01 5:21 Hongzhan Chen
2021-09-01 6:33 ` Jan Kiszka
0 siblings, 1 reply; 2+ messages in thread
From: Hongzhan Chen @ 2021-09-01 5:21 UTC (permalink / raw)
To: xenomai
call correct api to remove gpio device.
Signed-off-by: Hongzhan Chen <hongzhan.chen@intel.com>
diff --git a/kernel/drivers/gpio/gpio-cherryview.c b/kernel/drivers/gpio/gpio-cherryview.c
index 826faff3a..1234a3e12 100644
--- a/kernel/drivers/gpio/gpio-cherryview.c
+++ b/kernel/drivers/gpio/gpio-cherryview.c
@@ -35,7 +35,7 @@ module_init(cherryview_gpio_init);
static void __exit cherryview_gpio_exit(void)
{
- rtdm_gpiochip_remove(RTDM_SUBCLASS_CHERRYVIEW);
+ rtdm_gpiochip_remove_by_type(RTDM_SUBCLASS_CHERRYVIEW);
}
module_exit(cherryview_gpio_exit);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] driver/gpio: gpio-cherryview: call correct api to remove gpio device
2021-09-01 5:21 [PATCH] driver/gpio: gpio-cherryview: call correct api to remove gpio device Hongzhan Chen
@ 2021-09-01 6:33 ` Jan Kiszka
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2021-09-01 6:33 UTC (permalink / raw)
To: Hongzhan Chen, xenomai
On 01.09.21 07:21, Hongzhan Chen via Xenomai wrote:
> call correct api to remove gpio device.
>
> Signed-off-by: Hongzhan Chen <hongzhan.chen@intel.com>
>
> diff --git a/kernel/drivers/gpio/gpio-cherryview.c b/kernel/drivers/gpio/gpio-cherryview.c
> index 826faff3a..1234a3e12 100644
> --- a/kernel/drivers/gpio/gpio-cherryview.c
> +++ b/kernel/drivers/gpio/gpio-cherryview.c
> @@ -35,7 +35,7 @@ module_init(cherryview_gpio_init);
>
> static void __exit cherryview_gpio_exit(void)
> {
> - rtdm_gpiochip_remove(RTDM_SUBCLASS_CHERRYVIEW);
> + rtdm_gpiochip_remove_by_type(RTDM_SUBCLASS_CHERRYVIEW);
> }
> module_exit(cherryview_gpio_exit);
>
>
Oh, indeed. Please send a new version of the affected commit (top of
next right now anyway). And please also update the kernel configs for CI
(xenomai/.gitlab-ci.yml) at this chance so that this new driver is built
whenever possible.
We may also want to enable it in xenomai-images eventually.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-01 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 5:21 [PATCH] driver/gpio: gpio-cherryview: call correct api to remove gpio device Hongzhan Chen
2021-09-01 6:33 ` Jan Kiszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.