* [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards
@ 2021-09-01 7:48 Francesco Dolcini
2021-09-01 7:48 ` [PATCH v1 1/2] colibri-imx6ull: improve env badblock management Francesco Dolcini
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Francesco Dolcini @ 2021-09-01 7:48 UTC (permalink / raw)
To: u-boot
Cc: Francesco Dolcini, Igor Opaniuk, Lukasz Majewski,
Oleksandr Suvorov, Patrick Delaunay, Philippe Schenker,
Simon Glass, Tero Kristo
Use the complete 512kb (4 blocks) nand partition reserved for u-boot
environment instead of just the first block, this allows the module
to have a working environment even if 3 blocks are bad.
Francesco Dolcini (2):
colibri-imx6ull: improve env badblock management
colibri-imx7: improve env badblock management
include/configs/colibri-imx6ull.h | 5 +++++
include/configs/colibri_imx7.h | 5 +++++
2 files changed, 10 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 1/2] colibri-imx6ull: improve env badblock management
2021-09-01 7:48 [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards Francesco Dolcini
@ 2021-09-01 7:48 ` Francesco Dolcini
2021-09-01 7:48 ` [PATCH v1 2/2] colibri-imx7: " Francesco Dolcini
2021-10-21 10:16 ` [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards Stefano Babic
2 siblings, 0 replies; 8+ messages in thread
From: Francesco Dolcini @ 2021-09-01 7:48 UTC (permalink / raw)
To: u-boot
Cc: Francesco Dolcini, Igor Opaniuk, Lukasz Majewski,
Oleksandr Suvorov, Patrick Delaunay, Philippe Schenker,
Simon Glass, Tero Kristo
Use the complete 512kb (4 blocks) nand partition reserved for u-boot
environment instead of just the first block, this allows the module to
have a working environment even if 3 blocks are bad.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
include/configs/colibri-imx6ull.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/configs/colibri-imx6ull.h b/include/configs/colibri-imx6ull.h
index 2fa3485173..a2753f8840 100644
--- a/include/configs/colibri-imx6ull.h
+++ b/include/configs/colibri-imx6ull.h
@@ -124,6 +124,11 @@
#define CONFIG_SYS_INIT_SP_ADDR \
(CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
+/* environment organization */
+#if defined(CONFIG_ENV_IS_IN_NAND)
+#define CONFIG_ENV_RANGE (4 * CONFIG_ENV_SIZE)
+#endif
+
/* NAND stuff */
#define CONFIG_SYS_MAX_NAND_DEVICE 1
/* used to initialize CONFIG_SYS_NAND_BASE_LIST which is unused */
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v1 2/2] colibri-imx7: improve env badblock management
2021-09-01 7:48 [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards Francesco Dolcini
2021-09-01 7:48 ` [PATCH v1 1/2] colibri-imx6ull: improve env badblock management Francesco Dolcini
@ 2021-09-01 7:48 ` Francesco Dolcini
2022-02-05 16:43 ` sbabic
2021-10-21 10:16 ` [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards Stefano Babic
2 siblings, 1 reply; 8+ messages in thread
From: Francesco Dolcini @ 2021-09-01 7:48 UTC (permalink / raw)
To: u-boot
Cc: Francesco Dolcini, Igor Opaniuk, Patrick Delaunay,
Philippe Schenker, Simon Glass
Use the complete 512kb (4 blocks) nand partition reserved for u-boot
environment instead of just the first block, this allows the module
to have a working environment even if 3 blocks are bad.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
include/configs/colibri_imx7.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/configs/colibri_imx7.h b/include/configs/colibri_imx7.h
index 2fffaa39c0..c3e12c81c9 100644
--- a/include/configs/colibri_imx7.h
+++ b/include/configs/colibri_imx7.h
@@ -192,6 +192,11 @@
#define CONFIG_SYS_INIT_SP_ADDR \
(CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
+/* environment organization */
+#if defined(CONFIG_ENV_IS_IN_NAND)
+#define CONFIG_ENV_RANGE (4 * CONFIG_ENV_SIZE)
+#endif
+
#ifdef CONFIG_TARGET_COLIBRI_IMX7_NAND
/* NAND stuff */
#define CONFIG_SYS_MAX_NAND_DEVICE 1
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards
2021-09-01 7:48 [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards Francesco Dolcini
2021-09-01 7:48 ` [PATCH v1 1/2] colibri-imx6ull: improve env badblock management Francesco Dolcini
2021-09-01 7:48 ` [PATCH v1 2/2] colibri-imx7: " Francesco Dolcini
@ 2021-10-21 10:16 ` Stefano Babic
2021-10-21 11:08 ` Francesco Dolcini
2 siblings, 1 reply; 8+ messages in thread
From: Stefano Babic @ 2021-10-21 10:16 UTC (permalink / raw)
To: Francesco Dolcini, u-boot
Cc: Igor Opaniuk, Lukasz Majewski, Oleksandr Suvorov,
Patrick Delaunay, Philippe Schenker, Simon Glass, Tero Kristo
Hi Francesco,
On 01.09.21 09:48, Francesco Dolcini wrote:
>
> Use the complete 512kb (4 blocks) nand partition reserved for u-boot
> environment instead of just the first block, this allows the module
> to have a working environment even if 3 blocks are bad.
>
>
> Francesco Dolcini (2):
> colibri-imx6ull: improve env badblock management
> colibri-imx7: improve env badblock management
>
> include/configs/colibri-imx6ull.h | 5 +++++
> include/configs/colibri_imx7.h | 5 +++++
> 2 files changed, 10 insertions(+)
>
Sure, but is it not time to move CONFIG_ENV_RANGE into Kconfig (and drop
it from whitelist= ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards
2021-10-21 10:16 ` [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards Stefano Babic
@ 2021-10-21 11:08 ` Francesco Dolcini
2021-10-22 7:59 ` Francesco Dolcini
0 siblings, 1 reply; 8+ messages in thread
From: Francesco Dolcini @ 2021-10-21 11:08 UTC (permalink / raw)
To: Stefano Babic
Cc: Francesco Dolcini, u-boot, Igor Opaniuk, Lukasz Majewski,
Oleksandr Suvorov, Patrick Delaunay, Philippe Schenker,
Simon Glass, Tero Kristo
Hello Stefano,
On Thu, Oct 21, 2021 at 12:16:33PM +0200, Stefano Babic wrote:
> On 01.09.21 09:48, Francesco Dolcini wrote:
> >
> > Use the complete 512kb (4 blocks) nand partition reserved for u-boot
> > environment instead of just the first block, this allows the module
> > to have a working environment even if 3 blocks are bad.
> >
> >
> > Francesco Dolcini (2):
> > colibri-imx6ull: improve env badblock management
> > colibri-imx7: improve env badblock management
> >
> > include/configs/colibri-imx6ull.h | 5 +++++
> > include/configs/colibri_imx7.h | 5 +++++
> > 2 files changed, 10 insertions(+)
> >
>
> Sure, but is it not time to move CONFIG_ENV_RANGE into Kconfig (and drop it
> from whitelist= ?
I'll try to have a look at it later tonight, I cannot warrant anything at the
moment.
Francesco
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards
2021-10-21 11:08 ` Francesco Dolcini
@ 2021-10-22 7:59 ` Francesco Dolcini
2021-10-22 8:04 ` Stefano Babic
0 siblings, 1 reply; 8+ messages in thread
From: Francesco Dolcini @ 2021-10-22 7:59 UTC (permalink / raw)
To: Stefano Babic
Cc: u-boot, Igor Opaniuk, Lukasz Majewski, Oleksandr Suvorov,
Patrick Delaunay, Philippe Schenker, Simon Glass, Tero Kristo
Hello Stefano,
On Thu, Oct 21, 2021 at 01:08:16PM +0200, Francesco Dolcini wrote:
> On Thu, Oct 21, 2021 at 12:16:33PM +0200, Stefano Babic wrote:
> > On 01.09.21 09:48, Francesco Dolcini wrote:
> > >
> > > Use the complete 512kb (4 blocks) nand partition reserved for u-boot
> > > environment instead of just the first block, this allows the module
> > > to have a working environment even if 3 blocks are bad.
> > >
> > >
> > > Francesco Dolcini (2):
> > > colibri-imx6ull: improve env badblock management
> > > colibri-imx7: improve env badblock management
> > >
> > > include/configs/colibri-imx6ull.h | 5 +++++
> > > include/configs/colibri_imx7.h | 5 +++++
> > > 2 files changed, 10 insertions(+)
> > >
> >
> > Sure, but is it not time to move CONFIG_ENV_RANGE into Kconfig (and drop it
> > from whitelist= ?
>
> I'll try to have a look at it later tonight, I cannot warrant anything at the
> moment.
So, I gave it a try, but it is not trivial (CONFIG_ENV_RANGE is using most of
the time other CONFIG options that are not in kconfig yet) :-/
At the moment I have no much time to invest on this topic, I hope it would be fine
to merge these 2 patches as they are.
Francesco
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards
2021-10-22 7:59 ` Francesco Dolcini
@ 2021-10-22 8:04 ` Stefano Babic
0 siblings, 0 replies; 8+ messages in thread
From: Stefano Babic @ 2021-10-22 8:04 UTC (permalink / raw)
To: Francesco Dolcini, Stefano Babic
Cc: u-boot, Igor Opaniuk, Lukasz Majewski, Oleksandr Suvorov,
Patrick Delaunay, Philippe Schenker, Simon Glass, Tero Kristo
Hi Francesco,
On 22.10.21 09:59, Francesco Dolcini wrote:
> Hello Stefano,
>
> On Thu, Oct 21, 2021 at 01:08:16PM +0200, Francesco Dolcini wrote:
>> On Thu, Oct 21, 2021 at 12:16:33PM +0200, Stefano Babic wrote:
>>> On 01.09.21 09:48, Francesco Dolcini wrote:
>>>>
>>>> Use the complete 512kb (4 blocks) nand partition reserved for u-boot
>>>> environment instead of just the first block, this allows the module
>>>> to have a working environment even if 3 blocks are bad.
>>>>
>>>>
>>>> Francesco Dolcini (2):
>>>> colibri-imx6ull: improve env badblock management
>>>> colibri-imx7: improve env badblock management
>>>>
>>>> include/configs/colibri-imx6ull.h | 5 +++++
>>>> include/configs/colibri_imx7.h | 5 +++++
>>>> 2 files changed, 10 insertions(+)
>>>>
>>>
>>> Sure, but is it not time to move CONFIG_ENV_RANGE into Kconfig (and drop it
>>> from whitelist= ?
>>
>> I'll try to have a look at it later tonight, I cannot warrant anything at the
>> moment.
>
> So, I gave it a try, but it is not trivial (CONFIG_ENV_RANGE is using most of
> the time other CONFIG options that are not in kconfig yet) :-/
>
> At the moment I have no much time to invest on this topic, I hope it would be fine
> to merge these 2 patches as they are.
Ok, I will merge your patches into u-boot-imx.
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 2/2] colibri-imx7: improve env badblock management
2021-09-01 7:48 ` [PATCH v1 2/2] colibri-imx7: " Francesco Dolcini
@ 2022-02-05 16:43 ` sbabic
0 siblings, 0 replies; 8+ messages in thread
From: sbabic @ 2022-02-05 16:43 UTC (permalink / raw)
To: Francesco Dolcini, u-boot
> Use the complete 512kb (4 blocks) nand partition reserved for u-boot
> environment instead of just the first block, this allows the module
> to have a working environment even if 3 blocks are bad.
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-02-05 16:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 7:48 [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards Francesco Dolcini
2021-09-01 7:48 ` [PATCH v1 1/2] colibri-imx6ull: improve env badblock management Francesco Dolcini
2021-09-01 7:48 ` [PATCH v1 2/2] colibri-imx7: " Francesco Dolcini
2022-02-05 16:43 ` sbabic
2021-10-21 10:16 ` [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards Stefano Babic
2021-10-21 11:08 ` Francesco Dolcini
2021-10-22 7:59 ` Francesco Dolcini
2021-10-22 8:04 ` Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.