All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: Thomas Schmitt <scdbackup@gmx.net>
Cc: grub-devel@gnu.org, development@efficientek.com
Subject: Re: [PATCH] tests: Let xorriso fixely assume UTF-8 as local character set
Date: Wed, 1 Sep 2021 15:11:38 +0200	[thread overview]
Message-ID: <20210901131138.iymzlg6wquxwei3m@tomti.i.net-space.pl> (raw)
In-Reply-To: <20210827210506.17586-1-scdbackup@gmx.net>

On Fri, Aug 27, 2021 at 11:05:06PM +0200, Thomas Schmitt wrote:
> iso9660_test fails if the effective locale is not UTF-8. This happens
> because xorriso needs to convert file names and FSLABEL to UCS-2 when
> preparing a Joliet tree. grub-fs-tester obviously intends to use UTF-8
> as character set, but xorriso assumes by default the result of
> nl_langinfo(3) with item CODESET.
> So override the result of nl_langinfo(CODESET) by options of xorriso -as
> mkisofs.
>
> Signed-off-by: Thomas Schmitt <scdbackup@gmx.net>

Thomas, Glenn, thank you for doing such deep investigation!

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Glenn, did you test this patch?

Daniel


  reply	other threads:[~2021-09-01 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 21:05 [PATCH] tests: Let xorriso fixely assume UTF-8 as local character set Thomas Schmitt
2021-09-01 13:11 ` Daniel Kiper [this message]
2021-09-07 21:15   ` Glenn Washburn
2021-09-08 19:06     ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210901131138.iymzlg6wquxwei3m@tomti.i.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=development@efficientek.com \
    --cc=grub-devel@gnu.org \
    --cc=scdbackup@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.