All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: Glenn Washburn <development@efficientek.com>
Cc: Thomas Schmitt <scdbackup@gmx.net>, grub-devel@gnu.org
Subject: Re: [PATCH] tests: Let xorriso fixely assume UTF-8 as local character set
Date: Wed, 8 Sep 2021 21:06:54 +0200	[thread overview]
Message-ID: <20210908190654.sqzho2nxa2oqwmmc@tomti.i.net-space.pl> (raw)
In-Reply-To: <20210907211346.7d0dd9e8@ubuntu>

On Tue, Sep 07, 2021 at 09:15:58PM +0000, Glenn Washburn wrote:
> On Wed, 1 Sep 2021 15:11:38 +0200
> Daniel Kiper <dkiper@net-space.pl> wrote:
>
> > On Fri, Aug 27, 2021 at 11:05:06PM +0200, Thomas Schmitt wrote:
> > > iso9660_test fails if the effective locale is not UTF-8. This
> > > happens because xorriso needs to convert file names and FSLABEL to
> > > UCS-2 when preparing a Joliet tree. grub-fs-tester obviously
> > > intends to use UTF-8 as character set, but xorriso assumes by
> > > default the result of nl_langinfo(3) with item CODESET.
> > > So override the result of nl_langinfo(CODESET) by options of
> > > xorriso -as mkisofs.
> > >
> > > Signed-off-by: Thomas Schmitt <scdbackup@gmx.net>
> >
> > Thomas, Glenn, thank you for doing such deep investigation!
> >
> > Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> >
> > Glenn, did you test this patch?
>
> Coming to this late, had some issues which kept me away. I notice that

No worries...

> the patch is already in master, but for what its worth, I have now
> tested with the patch and LANG unset and the test now succeeds. Thanks

Thank you for doing test.

Daniel


      reply	other threads:[~2021-09-08 19:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 21:05 [PATCH] tests: Let xorriso fixely assume UTF-8 as local character set Thomas Schmitt
2021-09-01 13:11 ` Daniel Kiper
2021-09-07 21:15   ` Glenn Washburn
2021-09-08 19:06     ` Daniel Kiper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210908190654.sqzho2nxa2oqwmmc@tomti.i.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=development@efficientek.com \
    --cc=grub-devel@gnu.org \
    --cc=scdbackup@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.