* [PATCH 1/2] clk: versatile: Rename ICST to CLK_ICST
@ 2021-09-01 16:08 Jean Delvare
2021-09-01 16:09 ` [PATCH 2/2] clk: versatile: hide clock drivers from non-ARM users Jean Delvare
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jean Delvare @ 2021-09-01 16:08 UTC (permalink / raw)
To: linux-clk; +Cc: Linus Walleij, Michael Turquette, Stephen Boyd
For consistency, prefix the ICST config option with CLK as all other
clock source drivers have.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
---
arch/arm/mach-integrator/Kconfig | 2 +-
arch/arm/mach-realview/Kconfig | 2 +-
arch/arm/mach-versatile/Kconfig | 2 +-
arch/arm/mach-vexpress/Kconfig | 2 +-
drivers/clk/versatile/Kconfig | 2 +-
drivers/clk/versatile/Makefile | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
--- linux-5.14.orig/arch/arm/mach-integrator/Kconfig 2021-09-01 17:59:24.942741599 +0200
+++ linux-5.14/arch/arm/mach-integrator/Kconfig 2021-09-01 18:00:06.681274791 +0200
@@ -6,7 +6,7 @@ menuconfig ARCH_INTEGRATOR
select CMA
select DMA_CMA
select HAVE_TCM
- select ICST
+ select CLK_ICST
select MFD_SYSCON
select PLAT_VERSATILE
select POWER_RESET
--- linux-5.14.orig/arch/arm/mach-realview/Kconfig 2021-09-01 17:59:24.942741599 +0200
+++ linux-5.14/arch/arm/mach-realview/Kconfig 2021-09-01 18:00:06.681274791 +0200
@@ -11,7 +11,7 @@ menuconfig ARCH_REALVIEW
select HAVE_ARM_TWD if SMP
select HAVE_PATA_PLATFORM
select HAVE_TCM
- select ICST
+ select CLK_ICST
select MACH_REALVIEW_EB if ARCH_MULTI_V5
select MFD_SYSCON
select PLAT_VERSATILE
--- linux-5.14.orig/arch/arm/mach-versatile/Kconfig 2021-09-01 17:59:24.942741599 +0200
+++ linux-5.14/arch/arm/mach-versatile/Kconfig 2021-09-01 18:00:06.681274791 +0200
@@ -7,7 +7,7 @@ config ARCH_VERSATILE
select ARM_VIC
select CLKSRC_VERSATILE
select CPU_ARM926T
- select ICST
+ select CLK_ICST
select MFD_SYSCON
select PLAT_VERSATILE
select POWER_RESET
--- linux-5.14.orig/arch/arm/mach-vexpress/Kconfig 2021-09-01 17:59:24.942741599 +0200
+++ linux-5.14/arch/arm/mach-vexpress/Kconfig 2021-09-01 18:00:06.681274791 +0200
@@ -11,7 +11,7 @@ menuconfig ARCH_VEXPRESS
select HAVE_ARM_SCU if SMP
select HAVE_ARM_TWD if SMP
select HAVE_PATA_PLATFORM
- select ICST
+ select CLK_ICST
select NO_IOPORT_MAP
select PLAT_VERSATILE
select POWER_RESET
--- linux-5.14.orig/drivers/clk/versatile/Kconfig 2021-09-01 17:59:24.942741599 +0200
+++ linux-5.14/drivers/clk/versatile/Kconfig 2021-09-01 18:05:25.939393462 +0200
@@ -3,7 +3,7 @@
menu "Clock driver for ARM Reference designs"
depends on HAS_IOMEM
-config ICST
+config CLK_ICST
bool "Clock driver for ARM Reference designs ICST"
select REGMAP_MMIO
help
--- linux-5.14.orig/drivers/clk/versatile/Makefile 2021-08-30 00:04:50.000000000 +0200
+++ linux-5.14/drivers/clk/versatile/Makefile 2021-09-01 18:07:46.446233983 +0200
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
# Makefile for Versatile-specific clocks
-obj-$(CONFIG_ICST) += icst.o clk-icst.o clk-versatile.o
+obj-$(CONFIG_CLK_ICST) += icst.o clk-icst.o clk-versatile.o
obj-$(CONFIG_INTEGRATOR_IMPD1) += clk-impd1.o
obj-$(CONFIG_CLK_SP810) += clk-sp810.o
obj-$(CONFIG_CLK_VEXPRESS_OSC) += clk-vexpress-osc.o
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/2] clk: versatile: hide clock drivers from non-ARM users
2021-09-01 16:08 [PATCH 1/2] clk: versatile: Rename ICST to CLK_ICST Jean Delvare
@ 2021-09-01 16:09 ` Jean Delvare
2021-09-16 23:01 ` Linus Walleij
2021-10-15 1:01 ` Stephen Boyd
2021-09-16 23:00 ` [PATCH 1/2] clk: versatile: Rename ICST to CLK_ICST Linus Walleij
2021-10-15 1:00 ` Stephen Boyd
2 siblings, 2 replies; 6+ messages in thread
From: Jean Delvare @ 2021-09-01 16:09 UTC (permalink / raw)
To: linux-clk; +Cc: Linus Walleij, Stephen Boyd, Peter Collingbourne, Lee Jones
Commit 419b3ab6987f ("clk: versatile: remove dependency on ARCH_*")
made the whole menu of ARM reference clock drivers visible on all
architectures. I can't see how this is an improvement for non-ARM
users. Unless build-testing, there is no point on presenting
ARM-only clock drivers on other architectures.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Peter Collingbourne <pcc@google.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>
---
drivers/clk/versatile/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-5.14.orig/drivers/clk/versatile/Kconfig 2021-09-01 17:28:15.853037684 +0200
+++ linux-5.14/drivers/clk/versatile/Kconfig 2021-09-01 17:32:58.498817653 +0200
@@ -2,6 +2,7 @@
menu "Clock driver for ARM Reference designs"
depends on HAS_IOMEM
+ depends on ARM || ARM64 || COMPILE_TEST
config CLK_ICST
bool "Clock driver for ARM Reference designs ICST"
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] clk: versatile: hide clock drivers from non-ARM users
2021-09-01 16:09 ` [PATCH 2/2] clk: versatile: hide clock drivers from non-ARM users Jean Delvare
@ 2021-09-16 23:01 ` Linus Walleij
2021-10-15 1:01 ` Stephen Boyd
1 sibling, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2021-09-16 23:01 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-clk, Stephen Boyd, Peter Collingbourne, Lee Jones
On Wed, Sep 1, 2021 at 6:09 PM Jean Delvare <jdelvare@suse.de> wrote:
> Commit 419b3ab6987f ("clk: versatile: remove dependency on ARCH_*")
> made the whole menu of ARM reference clock drivers visible on all
> architectures. I can't see how this is an improvement for non-ARM
> users. Unless build-testing, there is no point on presenting
> ARM-only clock drivers on other architectures.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Peter Collingbourne <pcc@google.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
OK then:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] clk: versatile: hide clock drivers from non-ARM users
2021-09-01 16:09 ` [PATCH 2/2] clk: versatile: hide clock drivers from non-ARM users Jean Delvare
2021-09-16 23:01 ` Linus Walleij
@ 2021-10-15 1:01 ` Stephen Boyd
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2021-10-15 1:01 UTC (permalink / raw)
To: Jean Delvare, linux-clk; +Cc: Linus Walleij, Peter Collingbourne, Lee Jones
Quoting Jean Delvare (2021-09-01 09:09:53)
> Commit 419b3ab6987f ("clk: versatile: remove dependency on ARCH_*")
> made the whole menu of ARM reference clock drivers visible on all
> architectures. I can't see how this is an improvement for non-ARM
> users. Unless build-testing, there is no point on presenting
> ARM-only clock drivers on other architectures.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Peter Collingbourne <pcc@google.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] clk: versatile: Rename ICST to CLK_ICST
2021-09-01 16:08 [PATCH 1/2] clk: versatile: Rename ICST to CLK_ICST Jean Delvare
2021-09-01 16:09 ` [PATCH 2/2] clk: versatile: hide clock drivers from non-ARM users Jean Delvare
@ 2021-09-16 23:00 ` Linus Walleij
2021-10-15 1:00 ` Stephen Boyd
2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2021-09-16 23:00 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-clk, Michael Turquette, Stephen Boyd
On Wed, Sep 1, 2021 at 6:08 PM Jean Delvare <jdelvare@suse.de> wrote:
> For consistency, prefix the ICST config option with CLK as all other
> clock source drivers have.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
Fine by me!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] clk: versatile: Rename ICST to CLK_ICST
2021-09-01 16:08 [PATCH 1/2] clk: versatile: Rename ICST to CLK_ICST Jean Delvare
2021-09-01 16:09 ` [PATCH 2/2] clk: versatile: hide clock drivers from non-ARM users Jean Delvare
2021-09-16 23:00 ` [PATCH 1/2] clk: versatile: Rename ICST to CLK_ICST Linus Walleij
@ 2021-10-15 1:00 ` Stephen Boyd
2 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2021-10-15 1:00 UTC (permalink / raw)
To: Jean Delvare, linux-clk; +Cc: Linus Walleij, Michael Turquette
Quoting Jean Delvare (2021-09-01 09:08:33)
> For consistency, prefix the ICST config option with CLK as all other
> clock source drivers have.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-15 1:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 16:08 [PATCH 1/2] clk: versatile: Rename ICST to CLK_ICST Jean Delvare
2021-09-01 16:09 ` [PATCH 2/2] clk: versatile: hide clock drivers from non-ARM users Jean Delvare
2021-09-16 23:01 ` Linus Walleij
2021-10-15 1:01 ` Stephen Boyd
2021-09-16 23:00 ` [PATCH 1/2] clk: versatile: Rename ICST to CLK_ICST Linus Walleij
2021-10-15 1:00 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.