All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Tianyu Lan <ltykernel@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
	kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
	catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
	dave.hansen@linux.intel.com, luto@kernel.org,
	peterz@infradead.org, konrad.wilk@oracle.com,
	boris.ostrovsky@oracle.com, jgross@suse.com,
	sstabellini@kernel.org, joro@8bytes.org, davem@davemloft.net,
	kuba@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com,
	gregkh@linuxfoundation.org, arnd@arndb.de,
	m.szyprowski@samsung.com, robin.murphy@arm.com,
	brijesh.singh@amd.com, thomas.lendacky@amd.com,
	Tianyu.Lan@microsoft.com, pgonda@google.com,
	martin.b.radev@gmail.com, akpm@linux-foundation.org,
	kirill.shutemov@linux.intel.com, rppt@kernel.org,
	hannes@cmpxchg.org, aneesh.kumar@linux.ibm.com,
	krish.sadhukhan@oracle.com, saravanand@fb.com,
	linux-arm-kernel@lists.infradead.org,
	xen-devel@lists.xenproject.org, rientjes@google.com,
	ardb@kernel.org, michael.h.kelley@microsoft.com,
	iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
	vkuznets@redhat.com, parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: Re: [PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support
Date: Thu, 2 Sep 2021 09:51:31 +0200	[thread overview]
Message-ID: <20210902075131.GA14986@lst.de> (raw)
In-Reply-To: <91b5e997-8d44-77f0-6519-f574b541ba9f@gmail.com>

On Tue, Aug 31, 2021 at 11:20:06PM +0800, Tianyu Lan wrote:
>> If so I suspect the best way to allocate them is by not using vmalloc
>> but just discontiguous pages, and then use kmap_local_pfn where the
>> PFN includes the share_gpa offset when actually copying from/to the
>> skbs.
>>
> When netvsc needs to copy packet data to send buffer, it needs to caculate 
> position with section_index and send_section_size.
> Please seee netvsc_copy_to_send_buf() detail. So the contiguous virtual 
> address of send buffer is necessary to copy data and batch packets.

Actually that makes the kmap approach much easier.  The phys_to_virt
can just be replaced with a kmap_local_pfn and the unmap needs to
be added.  I've been mostly focussing on the receive path, which
would need a similar treatment.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Tianyu Lan <ltykernel@gmail.com>
Cc: parri.andrea@gmail.com, linux-hyperv@vger.kernel.org,
	brijesh.singh@amd.com, peterz@infradead.org,
	catalin.marinas@arm.com, dave.hansen@linux.intel.com,
	dave.hansen@intel.com, netdev@vger.kernel.org, hpa@zytor.com,
	kys@microsoft.com, will@kernel.org, tglx@linutronix.de,
	linux-arch@vger.kernel.org, wei.liu@kernel.org,
	sstabellini@kernel.org, sthemmin@microsoft.com,
	xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
	aneesh.kumar@linux.ibm.com, x86@kernel.org, decui@microsoft.com,
	Christoph Hellwig <hch@lst.de>,
	michael.h.kelley@microsoft.com, mingo@redhat.com,
	pgonda@google.com, rientjes@google.com, kuba@kernel.org,
	jejb@linux.ibm.com, martin.b.radev@gmail.com,
	thomas.lendacky@amd.com, Tianyu.Lan@microsoft.com, arnd@arndb.de,
	konrad.wilk@oracle.com, haiyangz@microsoft.com, bp@alien8.de,
	luto@kernel.org, krish.sadhukhan@oracle.com,
	boris.ostrovsky@oracle.com, vkuznets@redhat.com,
	linux-arm-kernel@lists.infradead.org, jgross@suse.com,
	martin.petersen@oracle.com, saravanand@fb.com,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org, rppt@kernel.org,
	hannes@cmpxchg.org, ardb@kernel.org, akpm@linux-foundation.org,
	robin.murphy@arm.com, davem@davemloft.net,
	kirill.shutemov@linux.intel.com
Subject: Re: [PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support
Date: Thu, 2 Sep 2021 09:51:31 +0200	[thread overview]
Message-ID: <20210902075131.GA14986@lst.de> (raw)
In-Reply-To: <91b5e997-8d44-77f0-6519-f574b541ba9f@gmail.com>

On Tue, Aug 31, 2021 at 11:20:06PM +0800, Tianyu Lan wrote:
>> If so I suspect the best way to allocate them is by not using vmalloc
>> but just discontiguous pages, and then use kmap_local_pfn where the
>> PFN includes the share_gpa offset when actually copying from/to the
>> skbs.
>>
> When netvsc needs to copy packet data to send buffer, it needs to caculate 
> position with section_index and send_section_size.
> Please seee netvsc_copy_to_send_buf() detail. So the contiguous virtual 
> address of send buffer is necessary to copy data and batch packets.

Actually that makes the kmap approach much easier.  The phys_to_virt
can just be replaced with a kmap_local_pfn and the unmap needs to
be added.  I've been mostly focussing on the receive path, which
would need a similar treatment.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-09-02  7:51 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 17:20 [PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support Tianyu Lan
2021-08-27 17:20 ` Tianyu Lan
2021-08-27 17:20 ` [PATCH V4 01/13] x86/hyperv: Initialize GHCB page in Isolation VM Tianyu Lan
2021-08-27 17:20   ` Tianyu Lan
2021-09-02  0:15   ` Michael Kelley
2021-09-02  0:15     ` Michael Kelley via iommu
2021-09-02  0:15     ` Michael Kelley
2021-08-27 17:21 ` [PATCH V4 02/13] x86/hyperv: Initialize shared memory boundary in the " Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-09-02  0:15   ` Michael Kelley
2021-09-02  0:15     ` Michael Kelley
2021-09-02  0:15     ` Michael Kelley via iommu
2021-09-02  6:35     ` Tianyu Lan
2021-09-02  6:35       ` Tianyu Lan
2021-09-02  6:35       ` Tianyu Lan
2021-08-27 17:21 ` [PATCH V4 03/13] x86/hyperv: Add new hvcall guest address host visibility support Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-09-02  0:16   ` Michael Kelley
2021-09-02  0:16     ` Michael Kelley
2021-09-02  0:16     ` Michael Kelley via iommu
2021-08-27 17:21 ` [PATCH V4 04/13] hyperv: Mark vmbus ring buffer visible to host in Isolation VM Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-08-27 17:41   ` Greg KH
2021-08-27 17:41     ` Greg KH
2021-08-27 17:44     ` Tianyu Lan
2021-08-27 17:44       ` Tianyu Lan
2021-09-02  0:17   ` Michael Kelley
2021-09-02  0:17     ` Michael Kelley
2021-09-02  0:17     ` Michael Kelley via iommu
2021-08-27 17:21 ` [PATCH V4 05/13] hyperv: Add Write/Read MSR registers via ghcb page Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-08-27 17:41   ` Greg KH
2021-08-27 17:41     ` Greg KH
2021-08-27 17:46     ` Tianyu Lan
2021-08-27 17:46       ` Tianyu Lan
2021-09-02  3:32   ` Michael Kelley
2021-09-02  3:32     ` Michael Kelley
2021-09-02  3:32     ` Michael Kelley via iommu
2021-08-27 17:21 ` [PATCH V4 06/13] hyperv: Add ghcb hvcall support for SNP VM Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-09-02  0:20   ` Michael Kelley
2021-09-02  0:20     ` Michael Kelley
2021-09-02  0:20     ` Michael Kelley via iommu
2021-08-27 17:21 ` [PATCH V4 07/13] hyperv/Vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-09-02  0:21   ` Michael Kelley
2021-09-02  0:21     ` Michael Kelley
2021-09-02  0:21     ` Michael Kelley via iommu
2021-08-27 17:21 ` [PATCH V4 08/13] hyperv/vmbus: Initialize VMbus ring buffer for Isolation VM Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-09-02  0:23   ` Michael Kelley
2021-09-02  0:23     ` Michael Kelley
2021-09-02  0:23     ` Michael Kelley via iommu
2021-09-02 13:35     ` Tianyu Lan
2021-09-02 13:35       ` Tianyu Lan
2021-09-02 13:35       ` Tianyu Lan
2021-09-02 16:14       ` Michael Kelley
2021-09-02 16:14         ` Michael Kelley via iommu
2021-09-02 16:14         ` Michael Kelley
2021-08-27 17:21 ` [PATCH V4 09/13] DMA: Add dma_map_decrypted/dma_unmap_encrypted() function Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-08-27 17:21 ` [PATCH V4 10/13] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-08-27 17:21 ` [PATCH V4 11/13] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-09-02  1:27   ` Michael Kelley
2021-09-02  1:27     ` Michael Kelley
2021-09-02  1:27     ` Michael Kelley via iommu
2021-08-27 17:21 ` [PATCH V4 12/13] hv_netvsc: Add Isolation VM support for netvsc driver Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-09-02  2:34   ` Michael Kelley
2021-09-02  2:34     ` Michael Kelley
2021-09-02  2:34     ` Michael Kelley via iommu
2021-09-02  4:56     ` Michael Kelley
2021-09-02  4:56       ` Michael Kelley
2021-09-02  4:56       ` Michael Kelley via iommu
2021-08-27 17:21 ` [PATCH V4 13/13] hv_storvsc: Add Isolation VM support for storvsc driver Tianyu Lan
2021-08-27 17:21   ` Tianyu Lan
2021-09-02  2:08   ` Michael Kelley
2021-09-02  2:08     ` Michael Kelley
2021-09-02  2:08     ` Michael Kelley via iommu
2021-08-30 12:00 ` [PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support Christoph Hellwig
2021-08-30 12:00   ` Christoph Hellwig
2021-08-31 15:20   ` Tianyu Lan
2021-08-31 15:20     ` Tianyu Lan
2021-09-02  7:51     ` Christoph Hellwig [this message]
2021-09-02  7:51       ` Christoph Hellwig
2021-08-31 17:16   ` Michael Kelley
2021-08-31 17:16     ` Michael Kelley
2021-08-31 17:16     ` Michael Kelley via iommu
2021-09-02  7:59     ` Christoph Hellwig
2021-09-02  7:59       ` Christoph Hellwig
2021-09-02  7:59       ` Christoph Hellwig
2021-09-02 11:21       ` Tianyu Lan
2021-09-02 11:21         ` Tianyu Lan
2021-09-02 11:21         ` Tianyu Lan
2021-09-02 15:57       ` Michael Kelley
2021-09-02 15:57         ` Michael Kelley
2021-09-02 15:57         ` Michael Kelley via iommu
2021-09-14 14:41         ` Tianyu Lan
2021-09-14 14:41           ` Tianyu Lan
2021-09-14 14:41           ` Tianyu Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210902075131.GA14986@lst.de \
    --to=hch@lst.de \
    --cc=Tianyu.Lan@microsoft.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=brijesh.singh@amd.com \
    --cc=catalin.marinas@arm.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=decui@microsoft.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=hannes@cmpxchg.org \
    --cc=hpa@zytor.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jejb@linux.ibm.com \
    --cc=jgross@suse.com \
    --cc=joro@8bytes.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=krish.sadhukhan@oracle.com \
    --cc=kuba@kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ltykernel@gmail.com \
    --cc=luto@kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=martin.b.radev@gmail.com \
    --cc=martin.petersen@oracle.com \
    --cc=michael.h.kelley@microsoft.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=parri.andrea@gmail.com \
    --cc=peterz@infradead.org \
    --cc=pgonda@google.com \
    --cc=rientjes@google.com \
    --cc=robin.murphy@arm.com \
    --cc=rppt@kernel.org \
    --cc=saravanand@fb.com \
    --cc=sstabellini@kernel.org \
    --cc=sthemmin@microsoft.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=vkuznets@redhat.com \
    --cc=wei.liu@kernel.org \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.