From: Carlos Maiolino <cmaiolino@redhat.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: Erwan Velu <erwanaliasr1@gmail.com>,
grub-devel@gnu.org, Erwan Velu <e.velu@criteo.com>,
javierm@redhat.com
Subject: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock
Date: Thu, 2 Sep 2021 10:56:49 +0200 [thread overview]
Message-ID: <20210902085649.zucibvxhnez2meys@omega.lan> (raw)
In-Reply-To: <20210901124057.qqmqkjh7k3dkgnsv@tomti.i.net-space.pl>
On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote:
> CC-ing Javier...
>
> On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote:
> > Hi.
> > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote:
> > > Good day list,
> > > Le jeu. 26 août 2021 à 15:26, Carlos Maiolino <[1]cmaiolino@redhat.com>
> > > a écrit :
> > >
> > > [..]
> > > Thanks for spotting this!
> > >
> > > I'm adding the maintainers in CC. Carlos who commit the patch I'm
> > > fixing, agreed on the content.
> >
> > I didn't test the patch itself yet, but I've reproduced the issue. I was quite
> > sure I had tested this patch on a V4 fs, but looks like I miscalculated the
> > sizing. Thanks again. I'll try to test the patch here asap.
>
> Did you test this patch? If yes may I add your Tested-by to it?
Yup, patch works fine, just finished testing it, I was just trying to understand
where/why I miscalculated the inode size on V4 filesystems, and the reason was
the same why Erwan split the last/first members of inode v2/v3 in two different
unused structs.
Feel free to add to the patch:
Tested-by: Carlos Maiolino <cmaiolino@redhat.com>
>
> Daniel
>
--
Carlos
next prev parent reply other threads:[~2021-09-02 8:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 13:31 [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock Erwan Velu
2021-08-26 7:54 ` Erwan Velu
2021-08-26 13:26 ` Carlos Maiolino
2021-08-26 13:30 ` Erwan Velu
2021-08-30 9:18 ` Erwan Velu
2021-08-30 11:48 ` Carlos Maiolino
2021-09-01 12:40 ` Daniel Kiper
2021-09-01 13:05 ` Carlos Maiolino
2021-09-02 8:56 ` Carlos Maiolino [this message]
2021-09-02 11:33 ` Daniel Kiper
2021-09-02 11:39 ` Erwan Velu
2021-09-02 12:49 ` Daniel Kiper
2021-09-02 13:05 ` Erwan Velu
2021-09-02 13:31 ` Daniel Kiper
2021-09-02 13:34 ` Erwan Velu
2021-09-08 1:22 ` Where is the testing? (was: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock) Glenn Washburn
2021-09-08 9:20 ` Erwan Velu
2021-09-08 16:19 ` Daniel Kiper
2021-09-08 16:21 ` Erwan Velu
2021-09-08 16:03 ` Daniel Kiper
2021-09-08 19:57 ` Glenn Washburn
2021-09-14 12:24 ` Daniel Kiper
2021-09-06 12:20 ` [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902085649.zucibvxhnez2meys@omega.lan \
--to=cmaiolino@redhat.com \
--cc=dkiper@net-space.pl \
--cc=e.velu@criteo.com \
--cc=erwanaliasr1@gmail.com \
--cc=grub-devel@gnu.org \
--cc=javierm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.