From: Mark Brown <broonie@kernel.org>
To: Daniel Baluta <daniel.baluta@oss.nxp.com>
Cc: pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com,
robh+dt@kernel.org, devicetree@vger.kernel.org,
ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
shawnguo@kernel.org, kernel@pengutronix.de, festevam@gmail.com,
linux-imx@nxp.com, peter.ujfalusi@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
s-anna@ti.com, Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH 1/2] ASoC: SOF: imx: Add code to manage DSP related clocks
Date: Thu, 2 Sep 2021 15:49:13 +0100 [thread overview]
Message-ID: <20210902144913.GE11164@sirena.org.uk> (raw)
In-Reply-To: <20210902123216.787025-2-daniel.baluta@oss.nxp.com>
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
On Thu, Sep 02, 2021 at 03:32:15PM +0300, Daniel Baluta wrote:
> + for (i = 0; i < clks->num_dsp_clks; i++) {
> + clks->dsp_clks[i] = devm_clk_get(sdev->dev, clks->dsp_clks_names[i]);
Looks like this could benefit from the use of the clk_bulk_ APIs?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Daniel Baluta <daniel.baluta@oss.nxp.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kai.vehmanen@linux.intel.com, lgirdwood@gmail.com,
festevam@gmail.com, peter.ujfalusi@linux.intel.com,
ranjani.sridharan@linux.intel.com,
pierre-louis.bossart@linux.intel.com, robh+dt@kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, s-anna@ti.com,
shawnguo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: SOF: imx: Add code to manage DSP related clocks
Date: Thu, 2 Sep 2021 15:49:13 +0100 [thread overview]
Message-ID: <20210902144913.GE11164@sirena.org.uk> (raw)
In-Reply-To: <20210902123216.787025-2-daniel.baluta@oss.nxp.com>
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
On Thu, Sep 02, 2021 at 03:32:15PM +0300, Daniel Baluta wrote:
> + for (i = 0; i < clks->num_dsp_clks; i++) {
> + clks->dsp_clks[i] = devm_clk_get(sdev->dev, clks->dsp_clks_names[i]);
Looks like this could benefit from the use of the clk_bulk_ APIs?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-02 14:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 12:32 [PATCH 0/2] Add code to manage DSP related clocks Daniel Baluta
2021-09-02 12:32 ` Daniel Baluta
2021-09-02 12:32 ` [PATCH 1/2] ASoC: SOF: imx: " Daniel Baluta
2021-09-02 12:32 ` Daniel Baluta
2021-09-02 13:35 ` Péter Ujfalusi
2021-09-02 13:35 ` Péter Ujfalusi
2021-09-03 15:00 ` Daniel Baluta
2021-09-03 15:00 ` Daniel Baluta
2021-09-02 14:49 ` Mark Brown [this message]
2021-09-02 14:49 ` Mark Brown
2021-09-03 14:49 ` Daniel Baluta
2021-09-03 14:49 ` Daniel Baluta
2021-09-02 12:32 ` [PATCH 2/2] dt-bindings: dsp: fsl: Add DSP optional clocks documentation Daniel Baluta
2021-09-02 12:32 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902144913.GE11164@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=daniel.baluta@nxp.com \
--cc=daniel.baluta@oss.nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.