From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Leo Yan <leo.yan@linaro.org>, James Clark <james.clark@arm.com>, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, suzuki.poulose@arm.com, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 9/9] perf cs-etm: Show a warning for an unknown magic number Date: Thu, 2 Sep 2021 11:48:51 -0600 [thread overview] Message-ID: <20210902174851.GB1078000@p14s> (raw) In-Reply-To: <YS+iOrcPTzQfmbqU@kernel.org> Hi Arnaldo, On Wed, Sep 01, 2021 at 12:54:34PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Aug 24, 2021 at 04:36:15PM +0800, Leo Yan escreveu: > > On Fri, Aug 06, 2021 at 02:41:09PM +0100, James Clark wrote: > > > Currently perf reports "Cannot allocate memory" which isn't very helpful > > > for a potentially user facing issue. If we add a new magic number in > > > the future, perf will be able to report unrecognised magic numbers. > > > > > > Signed-off-by: James Clark <james.clark@arm.com> > > > > Reviewed-by: Leo Yan <leo.yan@linaro.org> > > Applies cleanly to my tree, test building it now, holler if there is > something that prevents it from being merged. Have you already merged this? If so than let it be. Otherwise please hold off as I'd like to take a look, something I intend on doing next week. Thanks, Mathieu > - Arnaldo > > > > --- > > > tools/perf/util/cs-etm.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > > > index 788ad5a099f6..5b276bdb96a6 100644 > > > --- a/tools/perf/util/cs-etm.c > > > +++ b/tools/perf/util/cs-etm.c > > > @@ -2973,6 +2973,11 @@ int cs_etm__process_auxtrace_info(union perf_event *event, > > > > > > /* ETE shares first part of metadata with ETMv4 */ > > > trcidr_idx = CS_ETMV4_TRCTRACEIDR; > > > + } else { > > > + ui__error("CS ETM Trace: Unrecognised magic number %#"PRIx64". File could be from a newer version of perf.\n", > > > + ptr[i]); > > > + err = -EINVAL; > > > + goto err_free_metadata; > > > } > > > > > > if (!metadata[j]) { > > > -- > > > 2.28.0 > > > > > -- > > - Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Leo Yan <leo.yan@linaro.org>, James Clark <james.clark@arm.com>, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, suzuki.poulose@arm.com, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 9/9] perf cs-etm: Show a warning for an unknown magic number Date: Thu, 2 Sep 2021 11:48:51 -0600 [thread overview] Message-ID: <20210902174851.GB1078000@p14s> (raw) In-Reply-To: <YS+iOrcPTzQfmbqU@kernel.org> Hi Arnaldo, On Wed, Sep 01, 2021 at 12:54:34PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Aug 24, 2021 at 04:36:15PM +0800, Leo Yan escreveu: > > On Fri, Aug 06, 2021 at 02:41:09PM +0100, James Clark wrote: > > > Currently perf reports "Cannot allocate memory" which isn't very helpful > > > for a potentially user facing issue. If we add a new magic number in > > > the future, perf will be able to report unrecognised magic numbers. > > > > > > Signed-off-by: James Clark <james.clark@arm.com> > > > > Reviewed-by: Leo Yan <leo.yan@linaro.org> > > Applies cleanly to my tree, test building it now, holler if there is > something that prevents it from being merged. Have you already merged this? If so than let it be. Otherwise please hold off as I'd like to take a look, something I intend on doing next week. Thanks, Mathieu > - Arnaldo > > > > --- > > > tools/perf/util/cs-etm.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > > > index 788ad5a099f6..5b276bdb96a6 100644 > > > --- a/tools/perf/util/cs-etm.c > > > +++ b/tools/perf/util/cs-etm.c > > > @@ -2973,6 +2973,11 @@ int cs_etm__process_auxtrace_info(union perf_event *event, > > > > > > /* ETE shares first part of metadata with ETMv4 */ > > > trcidr_idx = CS_ETMV4_TRCTRACEIDR; > > > + } else { > > > + ui__error("CS ETM Trace: Unrecognised magic number %#"PRIx64". File could be from a newer version of perf.\n", > > > + ptr[i]); > > > + err = -EINVAL; > > > + goto err_free_metadata; > > > } > > > > > > if (!metadata[j]) { > > > -- > > > 2.28.0 > > > > > -- > > - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-02 17:49 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-06 13:41 [PATCH v2 0/9] Support ETE decoding James Clark 2021-08-06 13:41 ` James Clark 2021-08-06 13:41 ` [PATCH v2 1/9] perf cs-etm: Refactor initialisation of decoder params James Clark 2021-08-06 13:41 ` James Clark 2021-09-03 8:52 ` Suzuki K Poulose 2021-09-03 8:52 ` Suzuki K Poulose 2021-09-03 11:05 ` Arnaldo Carvalho de Melo 2021-09-03 11:05 ` Arnaldo Carvalho de Melo 2021-09-05 21:24 ` Mike Leach 2021-09-05 21:24 ` Mike Leach 2021-08-06 13:41 ` [PATCH v2 2/9] perf cs-etm: Initialise architecture based on TRCIDR1 James Clark 2021-08-06 13:41 ` James Clark 2021-08-24 6:53 ` Leo Yan 2021-08-24 6:53 ` Leo Yan 2021-09-03 8:55 ` Suzuki K Poulose 2021-09-03 8:55 ` Suzuki K Poulose 2021-09-03 11:07 ` Arnaldo Carvalho de Melo 2021-09-03 11:07 ` Arnaldo Carvalho de Melo 2021-09-05 21:24 ` Mike Leach 2021-09-05 21:24 ` Mike Leach 2021-08-06 13:41 ` [PATCH v2 3/9] perf cs-etm: Refactor out ETMv4 header saving James Clark 2021-08-06 13:41 ` James Clark 2021-08-24 6:58 ` Leo Yan 2021-08-24 6:58 ` Leo Yan 2021-09-03 8:56 ` Suzuki K Poulose 2021-09-03 8:56 ` Suzuki K Poulose 2021-09-05 21:24 ` Mike Leach 2021-09-05 21:24 ` Mike Leach 2021-08-06 13:41 ` [PATCH v2 4/9] perf cs-etm: Save TRCDEVARCH register James Clark 2021-08-06 13:41 ` James Clark 2021-08-24 7:14 ` Leo Yan 2021-08-24 7:14 ` Leo Yan 2021-09-03 9:08 ` Suzuki K Poulose 2021-09-03 9:08 ` Suzuki K Poulose 2021-09-03 11:15 ` Arnaldo Carvalho de Melo 2021-09-03 11:15 ` Arnaldo Carvalho de Melo 2021-09-05 21:24 ` Mike Leach 2021-09-05 21:24 ` Mike Leach 2021-08-06 13:41 ` [PATCH v2 5/9] perf cs-etm: Fix typo James Clark 2021-08-06 13:41 ` James Clark 2021-08-24 7:15 ` Leo Yan 2021-08-24 7:15 ` Leo Yan 2021-09-03 9:09 ` Suzuki K Poulose 2021-09-03 9:09 ` Suzuki K Poulose 2021-09-05 21:24 ` Mike Leach 2021-09-05 21:24 ` Mike Leach 2021-08-06 13:41 ` [PATCH v2 6/9] perf cs-etm: Update OpenCSD decoder for ETE James Clark 2021-08-06 13:41 ` James Clark 2021-09-03 9:10 ` Suzuki K Poulose 2021-09-03 9:10 ` Suzuki K Poulose 2021-09-03 11:16 ` Arnaldo Carvalho de Melo 2021-09-03 11:16 ` Arnaldo Carvalho de Melo 2021-09-05 21:24 ` Mike Leach 2021-09-05 21:24 ` Mike Leach 2021-08-06 13:41 ` [PATCH v2 7/9] perf cs-etm: Create ETE decoder James Clark 2021-08-06 13:41 ` James Clark 2021-08-24 8:33 ` Leo Yan 2021-08-24 8:33 ` Leo Yan 2021-08-25 10:13 ` James Clark 2021-08-25 10:13 ` James Clark 2021-09-03 9:15 ` Suzuki K Poulose 2021-09-03 9:15 ` Suzuki K Poulose 2021-09-03 11:16 ` Arnaldo Carvalho de Melo 2021-09-03 11:16 ` Arnaldo Carvalho de Melo 2021-09-05 21:24 ` Mike Leach 2021-09-05 21:24 ` Mike Leach 2021-08-06 13:41 ` [PATCH v2 8/9] perf cs-etm: Print the decoder name James Clark 2021-08-06 13:41 ` James Clark 2021-09-03 9:17 ` Suzuki K Poulose 2021-09-03 9:17 ` Suzuki K Poulose 2021-09-03 11:18 ` Arnaldo Carvalho de Melo 2021-09-03 11:18 ` Arnaldo Carvalho de Melo 2021-09-03 11:52 ` Arnaldo Carvalho de Melo 2021-09-03 11:52 ` Arnaldo Carvalho de Melo 2021-09-05 21:24 ` Mike Leach 2021-09-05 21:24 ` Mike Leach 2021-08-06 13:41 ` [PATCH v2 9/9] perf cs-etm: Show a warning for an unknown magic number James Clark 2021-08-06 13:41 ` James Clark 2021-08-24 8:36 ` Leo Yan 2021-08-24 8:36 ` Leo Yan 2021-09-01 15:54 ` Arnaldo Carvalho de Melo 2021-09-01 15:54 ` Arnaldo Carvalho de Melo 2021-09-01 16:07 ` Arnaldo Carvalho de Melo 2021-09-01 16:07 ` Arnaldo Carvalho de Melo 2021-09-01 16:16 ` Arnaldo Carvalho de Melo 2021-09-01 16:16 ` Arnaldo Carvalho de Melo 2021-09-01 16:25 ` Arnaldo Carvalho de Melo 2021-09-01 16:25 ` Arnaldo Carvalho de Melo 2021-09-01 16:49 ` Arnaldo Carvalho de Melo 2021-09-01 16:49 ` Arnaldo Carvalho de Melo 2021-09-02 7:53 ` Leo Yan 2021-09-02 7:53 ` Leo Yan 2021-09-02 17:48 ` Mathieu Poirier [this message] 2021-09-02 17:48 ` Mathieu Poirier 2021-09-02 18:19 ` Arnaldo Carvalho de Melo 2021-09-02 18:19 ` Arnaldo Carvalho de Melo 2021-09-02 19:22 ` Mathieu Poirier 2021-09-02 19:22 ` Mathieu Poirier 2021-09-05 21:24 ` Mike Leach 2021-09-05 21:24 ` Mike Leach 2021-08-24 8:47 ` [PATCH v2 0/9] Support ETE decoding Leo Yan 2021-08-24 8:47 ` Leo Yan 2021-08-25 10:14 ` James Clark 2021-08-25 10:14 ` James Clark
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210902174851.GB1078000@p14s \ --to=mathieu.poirier@linaro.org \ --cc=acme@kernel.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=coresight@lists.linaro.org \ --cc=james.clark@arm.com \ --cc=john.garry@huawei.com \ --cc=jolsa@redhat.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mike.leach@linaro.org \ --cc=namhyung@kernel.org \ --cc=suzuki.poulose@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.