From: Samuel Holland <samuel@sholland.org>
To: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Icenowy Zheng <icenowy@aosc.io>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org,
Samuel Holland <samuel@sholland.org>
Subject: [PATCH v3 2/3] dt-bindings: watchdog: sunxi: Add compatibles for D1
Date: Thu, 2 Sep 2021 17:57:49 -0500 [thread overview]
Message-ID: <20210902225750.29313-3-samuel@sholland.org> (raw)
In-Reply-To: <20210902225750.29313-1-samuel@sholland.org>
D1 keeps the same register layout and clock sources as the R329, but it
adds a key field which must be set to update the watchdog's "CFG" and
"MODE" registers. Therefore it is not backward-compatible.
Similarly to the R329, the D1 has three watchdog instances, and only one
of them has the "soft reset" registers. So that instance needs an extra
compatible string.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
Changes v2 to v3:
- Add additional allwinner,sun20i-d1-wdt-reset compatible
Changes v1 to v2:
- None
.../bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
index 877f47759814..44cad9427ae6 100644
--- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
@@ -30,6 +30,10 @@ properties:
- items:
- const: allwinner,suniv-f1c100s-wdt
- const: allwinner,sun4i-a10-wdt
+ - const: allwinner,sun20i-d1-wdt
+ - items:
+ - const: allwinner,sun20i-d1-wdt-reset
+ - const: allwinner,sun20i-d1-wdt
reg:
maxItems: 1
@@ -62,6 +66,8 @@ if:
compatible:
contains:
enum:
+ - allwinner,sun20i-d1-wdt
+ - allwinner,sun20i-d1-wdt-reset
- allwinner,sun50i-r329-wdt
- allwinner,sun50i-r329-wdt-reset
--
2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Holland <samuel@sholland.org>
To: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Icenowy Zheng <icenowy@aosc.io>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org,
Samuel Holland <samuel@sholland.org>
Subject: [PATCH v3 2/3] dt-bindings: watchdog: sunxi: Add compatibles for D1
Date: Thu, 2 Sep 2021 17:57:49 -0500 [thread overview]
Message-ID: <20210902225750.29313-3-samuel@sholland.org> (raw)
In-Reply-To: <20210902225750.29313-1-samuel@sholland.org>
D1 keeps the same register layout and clock sources as the R329, but it
adds a key field which must be set to update the watchdog's "CFG" and
"MODE" registers. Therefore it is not backward-compatible.
Similarly to the R329, the D1 has three watchdog instances, and only one
of them has the "soft reset" registers. So that instance needs an extra
compatible string.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
Changes v2 to v3:
- Add additional allwinner,sun20i-d1-wdt-reset compatible
Changes v1 to v2:
- None
.../bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
index 877f47759814..44cad9427ae6 100644
--- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
@@ -30,6 +30,10 @@ properties:
- items:
- const: allwinner,suniv-f1c100s-wdt
- const: allwinner,sun4i-a10-wdt
+ - const: allwinner,sun20i-d1-wdt
+ - items:
+ - const: allwinner,sun20i-d1-wdt-reset
+ - const: allwinner,sun20i-d1-wdt
reg:
maxItems: 1
@@ -62,6 +66,8 @@ if:
compatible:
contains:
enum:
+ - allwinner,sun20i-d1-wdt
+ - allwinner,sun20i-d1-wdt-reset
- allwinner,sun50i-r329-wdt
- allwinner,sun50i-r329-wdt-reset
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-02 22:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 22:57 [PATCH v3 0/3] Allwinner R329 and D1 watchdog support Samuel Holland
2021-09-02 22:57 ` Samuel Holland
2021-09-02 22:57 ` [PATCH v3 1/3] dt-bindings: watchdog: sunxi: Add compatibles for R329 Samuel Holland
2021-09-02 22:57 ` Samuel Holland
2021-09-03 9:30 ` Maxime Ripard
2021-09-03 9:30 ` Maxime Ripard
2021-09-03 16:07 ` Rob Herring
2021-09-03 16:07 ` Rob Herring
2021-09-04 15:10 ` Guenter Roeck
2021-09-04 15:10 ` Guenter Roeck
2021-09-02 22:57 ` Samuel Holland [this message]
2021-09-02 22:57 ` [PATCH v3 2/3] dt-bindings: watchdog: sunxi: Add compatibles for D1 Samuel Holland
2021-09-03 9:30 ` Maxime Ripard
2021-09-03 9:30 ` Maxime Ripard
2021-09-04 15:11 ` Guenter Roeck
2021-09-04 15:11 ` Guenter Roeck
2021-09-07 19:09 ` Rob Herring
2021-09-07 19:09 ` Rob Herring
2021-09-02 22:57 ` [PATCH v3 3/3] watchdog: sunxi_wdt: Add support " Samuel Holland
2021-09-02 22:57 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902225750.29313-3-samuel@sholland.org \
--to=samuel@sholland.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.