* [PATCH 1/1] virtio-blk: remove unneeded "likely" statements
@ 2021-08-30 12:01 Max Gurtovoy
2021-09-02 15:00 ` Stefan Hajnoczi
0 siblings, 1 reply; 6+ messages in thread
From: Max Gurtovoy @ 2021-08-30 12:01 UTC (permalink / raw)
To: mst, virtualization, kvm, stefanha; +Cc: oren, linux-block, axboe, Max Gurtovoy
Usually we use "likely/unlikely" to optimize the fast path. Remove
redundant "likely" statements in the control path to ease on the code.
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
drivers/block/virtio_blk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index afb37aac09e8..e574fbf5e6df 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -765,7 +765,7 @@ static int virtblk_probe(struct virtio_device *vdev)
goto out_free_vblk;
/* Default queue sizing is to fill the ring. */
- if (likely(!virtblk_queue_depth)) {
+ if (!virtblk_queue_depth) {
queue_depth = vblk->vqs[0].vq->num_free;
/* ... but without indirect descs, we use 2 descs per req */
if (!virtio_has_feature(vdev, VIRTIO_RING_F_INDIRECT_DESC))
@@ -839,7 +839,7 @@ static int virtblk_probe(struct virtio_device *vdev)
else
blk_size = queue_logical_block_size(q);
- if (unlikely(blk_size < SECTOR_SIZE || blk_size > PAGE_SIZE)) {
+ if (blk_size < SECTOR_SIZE || blk_size > PAGE_SIZE) {
dev_err(&vdev->dev,
"block size is changed unexpectedly, now is %u\n",
blk_size);
--
2.18.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] virtio-blk: remove unneeded "likely" statements
2021-08-30 12:01 [PATCH 1/1] virtio-blk: remove unneeded "likely" statements Max Gurtovoy
@ 2021-09-02 15:00 ` Stefan Hajnoczi
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2021-09-02 15:00 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: mst, virtualization, kvm, oren, linux-block, axboe
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
On Mon, Aug 30, 2021 at 03:01:11PM +0300, Max Gurtovoy wrote:
> Usually we use "likely/unlikely" to optimize the fast path. Remove
> redundant "likely" statements in the control path to ease on the code.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> drivers/block/virtio_blk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
It would be nice to tweak the commit description before merging this. I
had trouble parsing the second sentence. If I understand correctly the
purpose of this patch is to make the code simpler and easier to read:
s/ease on the code/simplify the code and make it easier to read/
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] virtio-blk: remove unneeded "likely" statements
@ 2021-09-02 15:00 ` Stefan Hajnoczi
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2021-09-02 15:00 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: axboe, kvm, mst, virtualization, linux-block, oren
[-- Attachment #1.1: Type: text/plain, Size: 706 bytes --]
On Mon, Aug 30, 2021 at 03:01:11PM +0300, Max Gurtovoy wrote:
> Usually we use "likely/unlikely" to optimize the fast path. Remove
> redundant "likely" statements in the control path to ease on the code.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> drivers/block/virtio_blk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
It would be nice to tweak the commit description before merging this. I
had trouble parsing the second sentence. If I understand correctly the
purpose of this patch is to make the code simpler and easier to read:
s/ease on the code/simplify the code and make it easier to read/
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] virtio-blk: remove unneeded "likely" statements
2021-09-02 15:00 ` Stefan Hajnoczi
(?)
@ 2021-09-02 19:13 ` Max Gurtovoy
2021-09-03 9:04 ` Michael S. Tsirkin
-1 siblings, 1 reply; 6+ messages in thread
From: Max Gurtovoy @ 2021-09-02 19:13 UTC (permalink / raw)
To: Stefan Hajnoczi, mst; +Cc: virtualization, kvm, oren, linux-block, axboe
On 9/2/2021 6:00 PM, Stefan Hajnoczi wrote:
> On Mon, Aug 30, 2021 at 03:01:11PM +0300, Max Gurtovoy wrote:
>> Usually we use "likely/unlikely" to optimize the fast path. Remove
>> redundant "likely" statements in the control path to ease on the code.
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>> drivers/block/virtio_blk.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
> It would be nice to tweak the commit description before merging this. I
> had trouble parsing the second sentence. If I understand correctly the
> purpose of this patch is to make the code simpler and easier to read:
>
> s/ease on the code/simplify the code and make it easier to read/
I'm ok with this change in commit message.
MST,
can you apply this change if you'll pick this commit ?
-Max.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] virtio-blk: remove unneeded "likely" statements
2021-09-02 19:13 ` Max Gurtovoy
@ 2021-09-03 9:04 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2021-09-03 9:04 UTC (permalink / raw)
To: Max Gurtovoy
Cc: Stefan Hajnoczi, virtualization, kvm, oren, linux-block, axboe
On Thu, Sep 02, 2021 at 10:13:04PM +0300, Max Gurtovoy wrote:
>
> On 9/2/2021 6:00 PM, Stefan Hajnoczi wrote:
> > On Mon, Aug 30, 2021 at 03:01:11PM +0300, Max Gurtovoy wrote:
> > > Usually we use "likely/unlikely" to optimize the fast path. Remove
> > > redundant "likely" statements in the control path to ease on the code.
> > >
> > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> > > ---
> > > drivers/block/virtio_blk.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > It would be nice to tweak the commit description before merging this. I
> > had trouble parsing the second sentence. If I understand correctly the
> > purpose of this patch is to make the code simpler and easier to read:
> >
> > s/ease on the code/simplify the code and make it easier to read/
>
> I'm ok with this change in commit message.
>
> MST,
>
> can you apply this change if you'll pick this commit ?
>
> -Max.
Just repost with a fixed commit log pls, easier for me.
Thanks!
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] virtio-blk: remove unneeded "likely" statements
@ 2021-09-03 9:04 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2021-09-03 9:04 UTC (permalink / raw)
To: Max Gurtovoy
Cc: axboe, kvm, virtualization, linux-block, Stefan Hajnoczi, oren
On Thu, Sep 02, 2021 at 10:13:04PM +0300, Max Gurtovoy wrote:
>
> On 9/2/2021 6:00 PM, Stefan Hajnoczi wrote:
> > On Mon, Aug 30, 2021 at 03:01:11PM +0300, Max Gurtovoy wrote:
> > > Usually we use "likely/unlikely" to optimize the fast path. Remove
> > > redundant "likely" statements in the control path to ease on the code.
> > >
> > > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> > > ---
> > > drivers/block/virtio_blk.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > It would be nice to tweak the commit description before merging this. I
> > had trouble parsing the second sentence. If I understand correctly the
> > purpose of this patch is to make the code simpler and easier to read:
> >
> > s/ease on the code/simplify the code and make it easier to read/
>
> I'm ok with this change in commit message.
>
> MST,
>
> can you apply this change if you'll pick this commit ?
>
> -Max.
Just repost with a fixed commit log pls, easier for me.
Thanks!
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-03 9:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-30 12:01 [PATCH 1/1] virtio-blk: remove unneeded "likely" statements Max Gurtovoy
2021-09-02 15:00 ` Stefan Hajnoczi
2021-09-02 15:00 ` Stefan Hajnoczi
2021-09-02 19:13 ` Max Gurtovoy
2021-09-03 9:04 ` Michael S. Tsirkin
2021-09-03 9:04 ` Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.