* [PATCH] ARM: dts: imx: Fix ECSPI nCS polarity on M53Menlo
@ 2021-09-05 0:02 Marek Vasut
2021-09-05 0:51 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2021-09-05 0:02 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Marek Vasut, Shawn Guo, Fabio Estevam, NXP Linux Team
This board has the nCS lines connected to a CPLD and they are active
high. Undo the change from 2bfdd113d0ee1 ("ARM: dts: imx: Fix the SPI
chipselect polarity") for this board, as the previous DT description
was correct.
Fixes: 2bfdd113d0ee1 ("ARM: dts: imx: Fix the SPI chipselect polarity")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
---
arch/arm/boot/dts/imx53-m53menlo.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
index 4f88e96d81ddb..03c43c1912a7e 100644
--- a/arch/arm/boot/dts/imx53-m53menlo.dts
+++ b/arch/arm/boot/dts/imx53-m53menlo.dts
@@ -104,7 +104,7 @@ &clks {
&ecspi2 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ecspi2>;
- cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>, <&gpio2 27 GPIO_ACTIVE_LOW>;
+ cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio2 27 GPIO_ACTIVE_HIGH>;
status = "okay";
spidev@0 {
--
2.33.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx: Fix ECSPI nCS polarity on M53Menlo
2021-09-05 0:02 [PATCH] ARM: dts: imx: Fix ECSPI nCS polarity on M53Menlo Marek Vasut
@ 2021-09-05 0:51 ` Fabio Estevam
2021-09-08 22:33 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2021-09-05 0:51 UTC (permalink / raw)
To: Marek Vasut
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Shawn Guo, NXP Linux Team, Linus Walleij
[Adding Linus]
On Sat, Sep 4, 2021 at 9:02 PM Marek Vasut <marex@denx.de> wrote:
>
> This board has the nCS lines connected to a CPLD and they are active
> high. Undo the change from 2bfdd113d0ee1 ("ARM: dts: imx: Fix the SPI
> chipselect polarity") for this board, as the previous DT description
> was correct.
>
> Fixes: 2bfdd113d0ee1 ("ARM: dts: imx: Fix the SPI chipselect polarity")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> ---
> arch/arm/boot/dts/imx53-m53menlo.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
> index 4f88e96d81ddb..03c43c1912a7e 100644
> --- a/arch/arm/boot/dts/imx53-m53menlo.dts
> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
> @@ -104,7 +104,7 @@ &clks {
> &ecspi2 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ecspi2>;
> - cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>, <&gpio2 27 GPIO_ACTIVE_LOW>;
> + cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio2 27 GPIO_ACTIVE_HIGH>;
> status = "okay";
>
> spidev@0 {
Then you need to pass the 'spi-cs-high' property under the spidev nodes.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx: Fix ECSPI nCS polarity on M53Menlo
2021-09-05 0:51 ` Fabio Estevam
@ 2021-09-08 22:33 ` Marek Vasut
0 siblings, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2021-09-08 22:33 UTC (permalink / raw)
To: Fabio Estevam
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Shawn Guo, NXP Linux Team, Linus Walleij
On 9/5/21 2:51 AM, Fabio Estevam wrote:
> [Adding Linus]
>
> On Sat, Sep 4, 2021 at 9:02 PM Marek Vasut <marex@denx.de> wrote:
>>
>> This board has the nCS lines connected to a CPLD and they are active
>> high. Undo the change from 2bfdd113d0ee1 ("ARM: dts: imx: Fix the SPI
>> chipselect polarity") for this board, as the previous DT description
>> was correct.
>>
>> Fixes: 2bfdd113d0ee1 ("ARM: dts: imx: Fix the SPI chipselect polarity")
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> ---
>> arch/arm/boot/dts/imx53-m53menlo.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
>> index 4f88e96d81ddb..03c43c1912a7e 100644
>> --- a/arch/arm/boot/dts/imx53-m53menlo.dts
>> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
>> @@ -104,7 +104,7 @@ &clks {
>> &ecspi2 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_ecspi2>;
>> - cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>, <&gpio2 27 GPIO_ACTIVE_LOW>;
>> + cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio2 27 GPIO_ACTIVE_HIGH>;
>> status = "okay";
>>
>> spidev@0 {
>
> Then you need to pass the 'spi-cs-high' property under the spidev nodes.
Turns out this patch can be dropped altogether.
Please drop this one.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-08 22:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-05 0:02 [PATCH] ARM: dts: imx: Fix ECSPI nCS polarity on M53Menlo Marek Vasut
2021-09-05 0:51 ` Fabio Estevam
2021-09-08 22:33 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.