* [Intel-gfx] [PATCH] drm/i915: Free the returned object of acpi_evaluate_dsm()
@ 2021-09-06 3:35 ` Zenghui Yu
0 siblings, 0 replies; 8+ messages in thread
From: Zenghui Yu @ 2021-09-06 3:35 UTC (permalink / raw)
To: intel-gfx, dri-devel, linux-kernel
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied, daniel,
ville.syrjala, tiwai, wanghaibin.wang, Zenghui Yu, Kai-Heng Feng
As per the comment on top of acpi_evaluate_dsm():
| * Evaluate device's _DSM method with specified GUID, revision id and
| * function number. Caller needs to free the returned object.
We should free the returned object of acpi_evaluate_dsm() to avoid memory
leakage. Otherwise the kmemleak splat will be triggered at boot time (if we
compile kernel with CONFIG_DEBUG_TEST_DRIVER_REMOVE=y).
Fixes: 8e55f99c510f ("drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops")
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
drivers/gpu/drm/i915/display/intel_acpi.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
index 7cfe91fc05f2..68abeaf2d7d4 100644
--- a/drivers/gpu/drm/i915/display/intel_acpi.c
+++ b/drivers/gpu/drm/i915/display/intel_acpi.c
@@ -186,13 +186,16 @@ void intel_dsm_get_bios_data_funcs_supported(struct drm_i915_private *i915)
{
struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
acpi_handle dhandle;
+ union acpi_object *obj;
dhandle = ACPI_HANDLE(&pdev->dev);
if (!dhandle)
return;
- acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID,
- INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL);
+ obj = acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID,
+ INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL);
+ if (obj)
+ ACPI_FREE(obj);
}
/*
--
2.19.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Free the returned object of acpi_evaluate_dsm()
2021-09-06 3:35 ` [Intel-gfx] " Zenghui Yu
(?)
(?)
@ 2021-09-07 16:40 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-09-07 16:40 UTC (permalink / raw)
To: Zenghui Yu; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30280 bytes --]
== Series Details ==
Series: drm/i915: Free the returned object of acpi_evaluate_dsm()
URL : https://patchwork.freedesktop.org/series/94433/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10557_full -> Patchwork_20975_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
New tests
---------
New tests have been introduced between CI_DRM_10557_full and Patchwork_20975_full:
### New IGT tests (145) ###
* igt@feature_discovery@chamelium:
- Statuses : 6 skip(s)
- Exec time: [0.0, 0.00] s
* igt@feature_discovery@display:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@feature_discovery@display-2x:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0] s
* igt@feature_discovery@display-3x:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@feature_discovery@display-4x:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@feature_discovery@psr1:
- Statuses : 2 pass(s) 4 skip(s)
- Exec time: [0.0, 0.00] s
* igt@feature_discovery@psr2:
- Statuses : 1 pass(s) 4 skip(s)
- Exec time: [0.0] s
* igt@gem_exec_fence@invalid-timeline-fence-array:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.03] s
* igt@gem_exec_fence@syncobj-backward-timeline-chain-engines:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 0.48] s
* igt@gem_exec_fence@syncobj-stationary-timeline-chain-engines:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 0.48] s
* igt@gem_exec_fence@syncobj-timeline-chain-engines:
- Statuses : 6 pass(s)
- Exec time: [0.05, 0.55] s
* igt@gem_exec_fence@syncobj-timeline-export:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.04] s
* igt@gem_exec_fence@syncobj-timeline-invalid-flags:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@gem_exec_fence@syncobj-timeline-invalid-wait:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@gem_exec_fence@syncobj-timeline-multiple-ext-nodes:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.05] s
* igt@gem_exec_fence@syncobj-timeline-repeat:
- Statuses : 6 pass(s)
- Exec time: [0.27, 3.60] s
* igt@gem_exec_fence@syncobj-timeline-signal:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.04] s
* igt@gem_exec_fence@syncobj-timeline-unused-fence:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.03] s
* igt@gem_exec_fence@syncobj-timeline-wait:
- Statuses : 6 pass(s)
- Exec time: [0.02, 0.19] s
* igt@gem_mmap_offset@blt-coherency:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.03] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a:
- Statuses : 7 pass(s)
- Exec time: [0.28, 1.16] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- Statuses : 6 pass(s)
- Exec time: [0.36, 2.33] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0, 2.31] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@32bits-limit:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.02] s
* igt@syncobj_timeline@device-signal-unordered:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@device-submit-unordered:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-available-unsubmitted:
- Statuses : 5 pass(s)
- Exec time: [0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-available-unsubmitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-available-unsubmitted-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.12] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.12] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-unsubmitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-unsubmitted-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-for-submit-unsubmitted-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-all-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.12] s
* igt@syncobj_timeline@etime-multi-wait-all-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-for-submit-available-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-for-submit-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-for-submit-unsubmitted:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-for-submit-unsubmitted-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-multi-wait-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-all-for-submit-available-unsubmitted:
- Statuses : 5 pass(s)
- Exec time: [0.10] s
* igt@syncobj_timeline@etime-single-wait-all-for-submit-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-all-for-submit-unsubmitted:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-all-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-for-submit-available-unsubmitted:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-for-submit-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-for-submit-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@etime-single-wait-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@host-signal-ordered:
- Statuses : 4 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@host-signal-points:
- Statuses : 7 pass(s)
- Exec time: [0.01, 0.08] s
* igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@invalid-multi-wait-all-available-unsubmitted-submitted-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@invalid-multi-wait-all-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-all-unsubmitted-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-all-unsubmitted-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@invalid-multi-wait-all-unsubmitted-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@invalid-multi-wait-available-unsubmitted-submitted-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@invalid-multi-wait-unsubmitted:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-multi-wait-unsubmitted-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@invalid-multi-wait-unsubmitted-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@invalid-multi-wait-unsubmitted-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@invalid-query-bad-pad:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-query-illegal-handle:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-query-one-illegal-handle:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-query-zero-handles:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-signal-bad-pad:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-signal-illegal-handle:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-signal-illegal-point:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-signal-one-illegal-handle:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-signal-zero-handles:
- Statuses : 7 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-single-wait-all-available-unsubmitted:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-single-wait-all-unsubmitted:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-single-wait-available-unsubmitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-single-wait-unsubmitted:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-transfer-bad-pad:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-transfer-illegal-handle:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-transfer-non-existent-point:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@invalid-wait-bad-flags:
- Statuses : 7 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-wait-illegal-handle:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@invalid-wait-zero-handles:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@syncobj_timeline@multi-wait-all-available-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-all-available-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-all-available-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-all-for-submit-available-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.02] s
* igt@syncobj_timeline@multi-wait-all-for-submit-available-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-all-for-submit-available-submitted-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-all-for-submit-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-all-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-available-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-available-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-available-submitted-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-for-submit-available-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-for-submit-available-submitted:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-for-submit-available-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-for-submit-available-unsubmitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@multi-wait-for-submit-available-unsubmitted-submitted:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@multi-wait-for-submit-available-unsubmitted-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-for-submit-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-for-submit-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-for-submit-unsubmitted-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-for-submit-unsubmitted-submitted-signaled:
- Statuses : 4 pass(s)
- Exec time: [0.00] s
* igt@syncobj_timeline@multi-wait-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@multi-wait-submitted-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@reset-during-wait-for-submit:
- Statuses : 5 pass(s)
- Exec time: [0.10] s
* igt@syncobj_timeline@reset-multiple-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.00, 0.01] s
* igt@syncobj_timeline@reset-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@reset-unsignaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@signal:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@signal-array:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@signal-point-0:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-all-available-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-all-available-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-all-for-submit-available-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-all-for-submit-available-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-all-for-submit-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@single-wait-all-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-available-signaled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-available-submitted:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-for-submit-available-signaled:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-for-submit-available-submitted:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@single-wait-for-submit-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@single-wait-signaled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.01] s
* igt@syncobj_timeline@transfer-timeline-point:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s
* igt@syncobj_timeline@wait-all-complex:
- Statuses : 4 pass(s)
- Exec time: [0.21, 0.22] s
* igt@syncobj_timeline@wait-all-delayed-signal:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@wait-all-for-submit-complex:
- Statuses : 4 pass(s)
- Exec time: [0.22] s
* igt@syncobj_timeline@wait-all-for-submit-delayed-submit:
- Statuses :
- Exec time: [None] s
* igt@syncobj_timeline@wait-all-for-submit-snapshot:
- Statuses : 6 pass(s)
- Exec time: [0.08, 0.09] s
* igt@syncobj_timeline@wait-all-interrupted:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@wait-all-snapshot:
- Statuses : 7 pass(s)
- Exec time: [0.08, 0.09] s
* igt@syncobj_timeline@wait-any-complex:
- Statuses : 6 pass(s)
- Exec time: [0.06, 0.08] s
* igt@syncobj_timeline@wait-any-interrupted:
- Statuses : 6 pass(s)
- Exec time: [0.10] s
* igt@syncobj_timeline@wait-any-snapshot:
- Statuses : 6 pass(s)
- Exec time: [0.08, 0.09] s
* igt@syncobj_timeline@wait-delayed-signal:
- Statuses : 7 pass(s)
- Exec time: [0.10, 0.12] s
* igt@syncobj_timeline@wait-for-submit-complex:
- Statuses : 5 pass(s)
- Exec time: [0.06, 0.08] s
* igt@syncobj_timeline@wait-for-submit-delayed-submit:
- Statuses : 6 pass(s)
- Exec time: [0.10, 0.11] s
* igt@syncobj_timeline@wait-for-submit-snapshot:
- Statuses : 7 pass(s)
- Exec time: [0.08, 0.09] s
Known issues
------------
Here are the changes found in Patchwork_20975_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-tglb: NOTRUN -> [DMESG-WARN][1] ([i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-tglb6/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-snb7/igt@gem_ctx_persistence@legacy-engines-queued.html
* igt@gem_eio@unwedge-stress:
- shard-skl: [PASS][3] -> [TIMEOUT][4] ([i915#2369] / [i915#3063])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10557/shard-skl8/igt@gem_eio@unwedge-stress.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-skl1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][5] -> [SKIP][6] ([fdo#109271]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10557/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-tglb: NOTRUN -> [FAIL][7] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-tglb6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#2190])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-apl7/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@big-copy-xy:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#1888] / [i915#307])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10557/shard-skl8/igt@gem_mmap_gtt@big-copy-xy.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-skl1/igt@gem_mmap_gtt@big-copy-xy.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#3323])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-apl7/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][12] -> [DMESG-WARN][13] ([i915#180])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10557/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
* igt@gen9_exec_parse@basic-rejected:
- shard-iclb: NOTRUN -> [SKIP][14] ([i915#2856]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb7/igt@gen9_exec_parse@basic-rejected.html
* igt@gen9_exec_parse@valid-registers:
- shard-tglb: NOTRUN -> [SKIP][15] ([i915#2856]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-tglb6/igt@gen9_exec_parse@valid-registers.html
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-apl: NOTRUN -> [SKIP][16] ([fdo#109271]) +137 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-apl7/igt@i915_pm_rpm@modeset-lpsp-stress.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: NOTRUN -> [DMESG-WARN][17] ([i915#180]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-apl3/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_big_fb@linear-32bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][18] ([fdo#110725] / [fdo#111614])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb7/igt@kms_big_fb@linear-32bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#3777])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-skl5/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][20] ([fdo#111615])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-tglb6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3886])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-skl5/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#3886]) +6 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-apl7/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][23] ([fdo#109278] / [i915#3886])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb7/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][24] ([i915#3689]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-tglb6/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_ccs.html
* igt@kms_chamelium@hdmi-crc-fast:
- shard-iclb: NOTRUN -> [SKIP][25] ([fdo#109284] / [fdo#111827])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb7/igt@kms_chamelium@hdmi-crc-fast.html
- shard-tglb: NOTRUN -> [SKIP][26] ([fdo#109284] / [fdo#111827]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-tglb3/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [PASS][27] -> [DMESG-WARN][28] ([i915#1982])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10557/shard-skl2/igt@kms_color@pipe-b-ctm-0-75.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-skl6/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_color_chamelium@pipe-a-ctm-0-5:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +14 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-apl8/igt@kms_color_chamelium@pipe-a-ctm-0-5.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-snb: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +12 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-snb5/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-b-ctm-max:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-skl5/igt@kms_color_chamelium@pipe-b-ctm-max.html
* igt@kms_color_chamelium@pipe-d-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][32] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb7/igt@kms_color_chamelium@pipe-d-ctm-green-to-red.html
* igt@kms_content_protection@atomic:
- shard-tglb: NOTRUN -> [SKIP][33] ([fdo#111828])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-tglb6/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@dp-mst-type-1:
- shard-iclb: NOTRUN -> [SKIP][34] ([i915#3116])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb7/igt@kms_content_protection@dp-mst-type-1.html
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#3116])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-tglb3/igt@kms_content_protection@dp-mst-type-1.html
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][36] ([i915#2105])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-apl3/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-tglb: [PASS][37] -> [INCOMPLETE][38] ([i915#2411] / [i915#2828] / [i915#456])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10557/shard-tglb6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#109278]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb7/igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen.html
* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109274] / [fdo#109278])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb7/igt@kms_cursor_legacy@cursora-vs-flipb-varying-size.html
* igt@kms_cursor_legacy@pipe-d-torture-move:
- shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271]) +38 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-skl5/igt@kms_cursor_legacy@pipe-d-torture-move.html
* igt@kms_flip@2x-flip-vs-suspend-interruptible:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109274])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb7/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- shard-iclb: [PASS][43] -> [SKIP][44] ([i915#3701])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10557/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109280]) +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-kbl: NOTRUN -> [SKIP][46] ([fdo#109271])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-kbl3/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-indfb-plflip-blt:
- shard-snb: NOTRUN -> [SKIP][47] ([fdo#109271]) +303 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-snb5/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-plflip-blt:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#111825]) +10 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-shrfb-plflip-blt.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][49] ([fdo#108145] / [i915#265]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#112054])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-tglb3/igt@kms_plane_multiple@atomic-pipe-b-tiling-yf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#658]) +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-apl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
- shard-iclb: NOTRUN -> [SKIP][52] ([i915#658])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/shard-iclb7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#2920]) +1 similar issue
[53]: https://intel-
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20975/index.html
[-- Attachment #2: Type: text/html, Size: 36507 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/i915: Free the returned object of acpi_evaluate_dsm()
2021-09-06 3:35 ` [Intel-gfx] " Zenghui Yu
@ 2021-10-07 9:21 ` Zenghui Yu
-1 siblings, 0 replies; 8+ messages in thread
From: Zenghui Yu @ 2021-10-07 9:21 UTC (permalink / raw)
To: intel-gfx, dri-devel, linux-kernel
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied, daniel,
ville.syrjala, tiwai, wanghaibin.wang, Kai-Heng Feng, linux-acpi
[+linux-acpi]
ping
On 2021/9/6 11:35, Zenghui Yu wrote:
> As per the comment on top of acpi_evaluate_dsm():
>
> | * Evaluate device's _DSM method with specified GUID, revision id and
> | * function number. Caller needs to free the returned object.
>
> We should free the returned object of acpi_evaluate_dsm() to avoid memory
> leakage. Otherwise the kmemleak splat will be triggered at boot time (if we
> compile kernel with CONFIG_DEBUG_TEST_DRIVER_REMOVE=y).
>
> Fixes: 8e55f99c510f ("drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops")
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> drivers/gpu/drm/i915/display/intel_acpi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index 7cfe91fc05f2..68abeaf2d7d4 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -186,13 +186,16 @@ void intel_dsm_get_bios_data_funcs_supported(struct drm_i915_private *i915)
> {
> struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
> acpi_handle dhandle;
> + union acpi_object *obj;
>
> dhandle = ACPI_HANDLE(&pdev->dev);
> if (!dhandle)
> return;
>
> - acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID,
> - INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL);
> + obj = acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID,
> + INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL);
> + if (obj)
> + ACPI_FREE(obj);
> }
>
> /*
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/i915: Free the returned object of acpi_evaluate_dsm()
2021-09-06 3:35 ` [Intel-gfx] " Zenghui Yu
@ 2021-10-07 10:10 ` Ville Syrjälä
-1 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjälä @ 2021-10-07 10:10 UTC (permalink / raw)
To: Zenghui Yu
Cc: intel-gfx, dri-devel, linux-kernel, jani.nikula, joonas.lahtinen,
rodrigo.vivi, airlied, daniel, tiwai, wanghaibin.wang,
Kai-Heng Feng
On Mon, Sep 06, 2021 at 11:35:41AM +0800, Zenghui Yu wrote:
> As per the comment on top of acpi_evaluate_dsm():
>
> | * Evaluate device's _DSM method with specified GUID, revision id and
> | * function number. Caller needs to free the returned object.
>
> We should free the returned object of acpi_evaluate_dsm() to avoid memory
> leakage. Otherwise the kmemleak splat will be triggered at boot time (if we
> compile kernel with CONFIG_DEBUG_TEST_DRIVER_REMOVE=y).
>
> Fixes: 8e55f99c510f ("drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops")
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Applied to drm-intel-next. Thanks, and sorry for the lag.
> ---
> drivers/gpu/drm/i915/display/intel_acpi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index 7cfe91fc05f2..68abeaf2d7d4 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -186,13 +186,16 @@ void intel_dsm_get_bios_data_funcs_supported(struct drm_i915_private *i915)
> {
> struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
> acpi_handle dhandle;
> + union acpi_object *obj;
>
> dhandle = ACPI_HANDLE(&pdev->dev);
> if (!dhandle)
> return;
>
> - acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID,
> - INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL);
> + obj = acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID,
> + INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL);
> + if (obj)
> + ACPI_FREE(obj);
> }
>
> /*
> --
> 2.19.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 8+ messages in thread