* [hch-block:blkdev.h-includes 14/17] drivers/block/swim.c:793:31: error: 'FLOPPY_MAJOR' undeclared
@ 2021-09-06 20:49 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-09-06 20:49 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 10592 bytes --]
tree: git://git.infradead.org/users/hch/block.git blkdev.h-includes
head: 9a8385d2d0ea7e589b98c102f4a60576385ca6c7
commit: 390df5b131b24e07917f79ae8f87437ea668cb61 [14/17] block: drop unused includes in <linux/genhd.h>
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add hch-block git://git.infradead.org/users/hch/block.git
git fetch --no-tags hch-block blkdev.h-includes
git checkout 390df5b131b24e07917f79ae8f87437ea668cb61
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/block/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/blkdev.h:6,
from include/linux/blk-mq.h:5,
from drivers/block/swim.c:18:
drivers/block/swim.c: In function 'swim_floppy_init':
>> drivers/block/swim.c:793:31: error: 'FLOPPY_MAJOR' undeclared (first use in this function)
793 | err = register_blkdev(FLOPPY_MAJOR, "fd");
| ^~~~~~~~~~~~
include/linux/genhd.h:276:27: note: in definition of macro 'register_blkdev'
276 | __register_blkdev(major, name, NULL)
| ^~~~~
drivers/block/swim.c:793:31: note: each undeclared identifier is reported only once for each function it appears in
793 | err = register_blkdev(FLOPPY_MAJOR, "fd");
| ^~~~~~~~~~~~
include/linux/genhd.h:276:27: note: in definition of macro 'register_blkdev'
276 | __register_blkdev(major, name, NULL)
| ^~~~~
drivers/block/swim.c: In function 'swim_remove':
drivers/block/swim.c:919:27: error: 'FLOPPY_MAJOR' undeclared (first use in this function)
919 | unregister_blkdev(FLOPPY_MAJOR, "fd");
| ^~~~~~~~~~~~
--
drivers/block/amiflop.c: In function 'fd_alloc_disk':
>> drivers/block/amiflop.c:1787:23: error: 'FLOPPY_MAJOR' undeclared (first use in this function)
1787 | disk->major = FLOPPY_MAJOR;
| ^~~~~~~~~~~~
drivers/block/amiflop.c:1787:23: note: each undeclared identifier is reported only once for each function it appears in
In file included from include/linux/blkdev.h:6,
from include/linux/blk-mq.h:5,
from drivers/block/amiflop.c:66:
drivers/block/amiflop.c: In function 'amiga_floppy_probe':
drivers/block/amiflop.c:1868:29: error: 'FLOPPY_MAJOR' undeclared (first use in this function)
1868 | if (register_blkdev(FLOPPY_MAJOR,"fd"))
| ^~~~~~~~~~~~
include/linux/genhd.h:276:27: note: in definition of macro 'register_blkdev'
276 | __register_blkdev(major, name, NULL)
| ^~~~~
--
drivers/block/ataflop.c: In function 'ataflop_alloc_disk':
>> drivers/block/ataflop.c:1976:23: error: 'FLOPPY_MAJOR' undeclared (first use in this function)
1976 | disk->major = FLOPPY_MAJOR;
| ^~~~~~~~~~~~
drivers/block/ataflop.c:1976:23: note: each undeclared identifier is reported only once for each function it appears in
drivers/block/ataflop.c: In function 'atari_floppy_init':
drivers/block/ataflop.c:2019:33: error: 'FLOPPY_MAJOR' undeclared (first use in this function)
2019 | ret = __register_blkdev(FLOPPY_MAJOR, "fd", ataflop_probe);
| ^~~~~~~~~~~~
drivers/block/ataflop.c: In function 'atari_floppy_exit':
drivers/block/ataflop.c:2143:27: error: 'FLOPPY_MAJOR' undeclared (first use in this function)
2143 | unregister_blkdev(FLOPPY_MAJOR, "fd");
| ^~~~~~~~~~~~
vim +/FLOPPY_MAJOR +793 drivers/block/swim.c
e3896d77b7025c Omar Sandoval 2018-10-15 773
8d85fce77edfc2 Greg Kroah-Hartman 2012-12-21 774 static int swim_floppy_init(struct swim_priv *swd)
8852ecd9748824 Laurent Vivier 2008-11-15 775 {
8852ecd9748824 Laurent Vivier 2008-11-15 776 int err;
8852ecd9748824 Laurent Vivier 2008-11-15 777 int drive;
8852ecd9748824 Laurent Vivier 2008-11-15 778 struct swim __iomem *base = swd->base;
8852ecd9748824 Laurent Vivier 2008-11-15 779
8852ecd9748824 Laurent Vivier 2008-11-15 780 /* scan floppy drives */
8852ecd9748824 Laurent Vivier 2008-11-15 781
8852ecd9748824 Laurent Vivier 2008-11-15 782 swim_drive(base, INTERNAL_DRIVE);
8a500df63d07d8 Finn Thain 2018-04-11 783 if (swim_readbit(base, DRIVE_PRESENT) &&
8a500df63d07d8 Finn Thain 2018-04-11 784 !swim_readbit(base, ONEMEG_DRIVE))
8852ecd9748824 Laurent Vivier 2008-11-15 785 swim_add_floppy(swd, INTERNAL_DRIVE);
8852ecd9748824 Laurent Vivier 2008-11-15 786 swim_drive(base, EXTERNAL_DRIVE);
8a500df63d07d8 Finn Thain 2018-04-11 787 if (swim_readbit(base, DRIVE_PRESENT) &&
8a500df63d07d8 Finn Thain 2018-04-11 788 !swim_readbit(base, ONEMEG_DRIVE))
8852ecd9748824 Laurent Vivier 2008-11-15 789 swim_add_floppy(swd, EXTERNAL_DRIVE);
8852ecd9748824 Laurent Vivier 2008-11-15 790
8852ecd9748824 Laurent Vivier 2008-11-15 791 /* register floppy drives */
8852ecd9748824 Laurent Vivier 2008-11-15 792
8852ecd9748824 Laurent Vivier 2008-11-15 @793 err = register_blkdev(FLOPPY_MAJOR, "fd");
8852ecd9748824 Laurent Vivier 2008-11-15 794 if (err) {
8852ecd9748824 Laurent Vivier 2008-11-15 795 printk(KERN_ERR "Unable to get major %d for SWIM floppy\n",
8852ecd9748824 Laurent Vivier 2008-11-15 796 FLOPPY_MAJOR);
8852ecd9748824 Laurent Vivier 2008-11-15 797 return -EBUSY;
8852ecd9748824 Laurent Vivier 2008-11-15 798 }
8852ecd9748824 Laurent Vivier 2008-11-15 799
103db8b2dfa5da Omar Sandoval 2017-03-27 800 spin_lock_init(&swd->lock);
103db8b2dfa5da Omar Sandoval 2017-03-27 801
8852ecd9748824 Laurent Vivier 2008-11-15 802 for (drive = 0; drive < swd->floppy_count; drive++) {
51fbfedfcc8627 Christoph Hellwig 2021-06-02 803 err = blk_mq_alloc_sq_tag_set(&swd->unit[drive].tag_set,
51fbfedfcc8627 Christoph Hellwig 2021-06-02 804 &swim_mq_ops, 2, BLK_MQ_F_SHOULD_MERGE);
51fbfedfcc8627 Christoph Hellwig 2021-06-02 805 if (err)
8852ecd9748824 Laurent Vivier 2008-11-15 806 goto exit_put_disks;
e3896d77b7025c Omar Sandoval 2018-10-15 807
51fbfedfcc8627 Christoph Hellwig 2021-06-02 808 swd->unit[drive].disk =
51fbfedfcc8627 Christoph Hellwig 2021-06-02 809 blk_mq_alloc_disk(&swd->unit[drive].tag_set,
51fbfedfcc8627 Christoph Hellwig 2021-06-02 810 &swd->unit[drive]);
51fbfedfcc8627 Christoph Hellwig 2021-06-02 811 if (IS_ERR(swd->unit[drive].disk)) {
51fbfedfcc8627 Christoph Hellwig 2021-06-02 812 blk_mq_free_tag_set(&swd->unit[drive].tag_set);
51fbfedfcc8627 Christoph Hellwig 2021-06-02 813 err = PTR_ERR(swd->unit[drive].disk);
8852ecd9748824 Laurent Vivier 2008-11-15 814 goto exit_put_disks;
8852ecd9748824 Laurent Vivier 2008-11-15 815 }
e3896d77b7025c Omar Sandoval 2018-10-15 816
103db8b2dfa5da Omar Sandoval 2017-03-27 817 swd->unit[drive].swd = swd;
103db8b2dfa5da Omar Sandoval 2017-03-27 818 }
8852ecd9748824 Laurent Vivier 2008-11-15 819
8852ecd9748824 Laurent Vivier 2008-11-15 820 for (drive = 0; drive < swd->floppy_count; drive++) {
8852ecd9748824 Laurent Vivier 2008-11-15 821 swd->unit[drive].disk->flags = GENHD_FL_REMOVABLE;
8852ecd9748824 Laurent Vivier 2008-11-15 822 swd->unit[drive].disk->major = FLOPPY_MAJOR;
8852ecd9748824 Laurent Vivier 2008-11-15 823 swd->unit[drive].disk->first_minor = drive;
51fbfedfcc8627 Christoph Hellwig 2021-06-02 824 swd->unit[drive].disk->minors = 1;
8852ecd9748824 Laurent Vivier 2008-11-15 825 sprintf(swd->unit[drive].disk->disk_name, "fd%d", drive);
8852ecd9748824 Laurent Vivier 2008-11-15 826 swd->unit[drive].disk->fops = &floppy_fops;
773008f6fe0544 Martin Wilck 2019-03-27 827 swd->unit[drive].disk->events = DISK_EVENT_MEDIA_CHANGE;
8852ecd9748824 Laurent Vivier 2008-11-15 828 swd->unit[drive].disk->private_data = &swd->unit[drive];
8852ecd9748824 Laurent Vivier 2008-11-15 829 set_capacity(swd->unit[drive].disk, 2880);
8852ecd9748824 Laurent Vivier 2008-11-15 830 add_disk(swd->unit[drive].disk);
8852ecd9748824 Laurent Vivier 2008-11-15 831 }
8852ecd9748824 Laurent Vivier 2008-11-15 832
8852ecd9748824 Laurent Vivier 2008-11-15 833 return 0;
8852ecd9748824 Laurent Vivier 2008-11-15 834
8852ecd9748824 Laurent Vivier 2008-11-15 835 exit_put_disks:
8852ecd9748824 Laurent Vivier 2008-11-15 836 unregister_blkdev(FLOPPY_MAJOR, "fd");
1448a2a5360ae0 Omar Sandoval 2018-10-11 837 do {
1448a2a5360ae0 Omar Sandoval 2018-10-11 838 struct gendisk *disk = swd->unit[drive].disk;
1448a2a5360ae0 Omar Sandoval 2018-10-11 839
51fbfedfcc8627 Christoph Hellwig 2021-06-02 840 if (!disk)
51fbfedfcc8627 Christoph Hellwig 2021-06-02 841 continue;
51fbfedfcc8627 Christoph Hellwig 2021-06-02 842 blk_cleanup_disk(disk);
e3896d77b7025c Omar Sandoval 2018-10-15 843 blk_mq_free_tag_set(&swd->unit[drive].tag_set);
1448a2a5360ae0 Omar Sandoval 2018-10-11 844 } while (drive--);
8852ecd9748824 Laurent Vivier 2008-11-15 845 return err;
8852ecd9748824 Laurent Vivier 2008-11-15 846 }
8852ecd9748824 Laurent Vivier 2008-11-15 847
:::::: The code at line 793 was first introduced by commit
:::::: 8852ecd97488249ca7fe2c0d3eb44cae95886881 m68k: mac - Add SWIM floppy support
:::::: TO: Laurent Vivier <laurent@lvivier.info>
:::::: CC: Geert Uytterhoeven <geert@linux-m68k.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 61220 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-06 20:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-06 20:49 [hch-block:blkdev.h-includes 14/17] drivers/block/swim.c:793:31: error: 'FLOPPY_MAJOR' undeclared kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.