From: Christoph Hellwig <hch@lst.de> To: Kanchan Joshi <joshi.k@samsung.com> Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org, io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, anuj20.g@samsung.com, javier.gonz@samsung.com, hare@suse.de Subject: Re: [RFC PATCH 6/6] nvme: enable passthrough with fixed-buffer Date: Tue, 7 Sep 2021 09:50:55 +0200 [thread overview] Message-ID: <20210907075055.GE29874@lst.de> (raw) In-Reply-To: <20210805125539.66958-7-joshi.k@samsung.com> > +/* > + * Unlike blk_rq_map_user () this is only for fixed-buffer async passthrough. > + * And hopefully faster as well. > + */ This belongs into io_uring.c. And that hopeful comment needs to be validated and removed. > +int nvme_rq_map_user_fixedb(struct request_queue *q, struct request *rq, > + void __user *ubuf, unsigned long len, gfp_t gfp_mask, > + struct io_uring_cmd *ioucmd) > +{ > + struct iov_iter iter; > + size_t iter_count, nr_segs; > + struct bio *bio; > + int ret; > + > + /* > + * Talk to io_uring to obtain BVEC iterator for the buffer. > + * And use that iterator to form bio/request. > + */ > + ret = io_uring_cmd_import_fixed(ubuf, len, rq_data_dir(rq), &iter, > + ioucmd); io_uring_cmd_import_fixed takes a non-__user pointer, so this will cause a sparse warning.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Kanchan Joshi <joshi.k@samsung.com> Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org, io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, anuj20.g@samsung.com, javier.gonz@samsung.com, hare@suse.de Subject: Re: [RFC PATCH 6/6] nvme: enable passthrough with fixed-buffer Date: Tue, 7 Sep 2021 09:50:55 +0200 [thread overview] Message-ID: <20210907075055.GE29874@lst.de> (raw) In-Reply-To: <20210805125539.66958-7-joshi.k@samsung.com> > +/* > + * Unlike blk_rq_map_user () this is only for fixed-buffer async passthrough. > + * And hopefully faster as well. > + */ This belongs into io_uring.c. And that hopeful comment needs to be validated and removed. > +int nvme_rq_map_user_fixedb(struct request_queue *q, struct request *rq, > + void __user *ubuf, unsigned long len, gfp_t gfp_mask, > + struct io_uring_cmd *ioucmd) > +{ > + struct iov_iter iter; > + size_t iter_count, nr_segs; > + struct bio *bio; > + int ret; > + > + /* > + * Talk to io_uring to obtain BVEC iterator for the buffer. > + * And use that iterator to form bio/request. > + */ > + ret = io_uring_cmd_import_fixed(ubuf, len, rq_data_dir(rq), &iter, > + ioucmd); io_uring_cmd_import_fixed takes a non-__user pointer, so this will cause a sparse warning. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-09-07 7:50 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20210805125910epcas5p1100e7093dd2b1ac5bbb751331e2ded23@epcas5p1.samsung.com> 2021-08-05 12:55 ` [RFC PATCH 0/6] Fixed-buffers io_uring passthrough over nvme-char Kanchan Joshi 2021-08-05 12:55 ` Kanchan Joshi [not found] ` <CGME20210805125917epcas5p4f75c9423a7b886dc79500901cc8f55ab@epcas5p4.samsung.com> 2021-08-05 12:55 ` [RFC PATCH 1/6] io_uring: add infra for uring_cmd completion in submitter-task Kanchan Joshi 2021-08-05 12:55 ` Kanchan Joshi [not found] ` <CGME20210805125923epcas5p10e6c1b95475440be68f58244d5a3cb9a@epcas5p1.samsung.com> 2021-08-05 12:55 ` [RFC PATCH 2/6] nvme: wire-up support for async-passthru on char-device Kanchan Joshi 2021-08-05 12:55 ` Kanchan Joshi 2021-09-07 7:46 ` Christoph Hellwig 2021-09-07 7:46 ` Christoph Hellwig 2021-09-07 16:20 ` Kanchan Joshi 2021-09-07 16:20 ` Kanchan Joshi 2021-09-08 6:15 ` Christoph Hellwig 2021-09-08 6:15 ` Christoph Hellwig 2021-09-22 7:19 ` Kanchan Joshi 2021-09-22 7:19 ` Kanchan Joshi [not found] ` <CGME20210805125927epcas5p28f3413fe3d0a2baed37a05453df0d482@epcas5p2.samsung.com> 2021-08-05 12:55 ` [RFC PATCH 3/6] io_uring: mark iopoll not supported for uring-cmd Kanchan Joshi 2021-08-05 12:55 ` Kanchan Joshi [not found] ` <CGME20210805125931epcas5p259fec172085ea34fdbf5a1c1f8da5e90@epcas5p2.samsung.com> 2021-08-05 12:55 ` [RFC PATCH 4/6] io_uring: add helper for fixed-buffer uring-cmd Kanchan Joshi 2021-08-05 12:55 ` Kanchan Joshi 2021-09-07 7:47 ` Christoph Hellwig 2021-09-07 7:47 ` Christoph Hellwig [not found] ` <CGME20210805125934epcas5p4ff88e95d558ad9f65d77a888a4211b18@epcas5p4.samsung.com> 2021-08-05 12:55 ` [RFC PATCH 5/6] io_uring: add support for uring_cmd with fixed-buffer Kanchan Joshi 2021-08-05 12:55 ` Kanchan Joshi 2021-09-07 7:48 ` Christoph Hellwig 2021-09-07 7:48 ` Christoph Hellwig 2021-09-07 16:29 ` Kanchan Joshi 2021-09-07 16:29 ` Kanchan Joshi [not found] ` <CGME20210805125937epcas5p15667b460e28d87bd40400f69005aafe3@epcas5p1.samsung.com> 2021-08-05 12:55 ` [RFC PATCH 6/6] nvme: enable passthrough " Kanchan Joshi 2021-08-05 12:55 ` Kanchan Joshi 2021-09-07 7:50 ` Christoph Hellwig [this message] 2021-09-07 7:50 ` Christoph Hellwig 2021-09-07 16:47 ` Kanchan Joshi 2021-09-07 16:47 ` Kanchan Joshi 2021-09-08 6:16 ` Christoph Hellwig 2021-09-08 6:16 ` Christoph Hellwig 2021-09-07 7:10 ` [RFC PATCH 0/6] Fixed-buffers io_uring passthrough over nvme-char Christoph Hellwig 2021-09-07 7:10 ` Christoph Hellwig 2021-09-07 12:38 ` Jens Axboe 2021-09-07 12:38 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210907075055.GE29874@lst.de \ --to=hch@lst.de \ --cc=anuj20.g@samsung.com \ --cc=axboe@kernel.dk \ --cc=hare@suse.de \ --cc=io-uring@vger.kernel.org \ --cc=javier.gonz@samsung.com \ --cc=joshi.k@samsung.com \ --cc=kbusch@kernel.org \ --cc=linux-nvme@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.