All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Krzysztof Opasiak <k.opasiak@samsung.com>,
	Mark Greer <mgreer@animalcreek.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-nfc@lists.01.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [linux-nfc] [PATCH 13/15] nfc: microread: drop unneeded debug prints
Date: Tue,  7 Sep 2021 14:18:14 +0200	[thread overview]
Message-ID: <20210907121816.37750-14-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210907121816.37750-1-krzysztof.kozlowski@canonical.com>

ftrace is a preferred and standard way to debug entering and exiting
functions so drop useless debug prints.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/nfc/microread/i2c.c | 4 ----
 drivers/nfc/microread/mei.c | 2 --
 2 files changed, 6 deletions(-)

diff --git a/drivers/nfc/microread/i2c.c b/drivers/nfc/microread/i2c.c
index 86f593c73ed6..067295124eb9 100644
--- a/drivers/nfc/microread/i2c.c
+++ b/drivers/nfc/microread/i2c.c
@@ -237,8 +237,6 @@ static int microread_i2c_probe(struct i2c_client *client,
 	struct microread_i2c_phy *phy;
 	int r;
 
-	dev_dbg(&client->dev, "client %p\n", client);
-
 	phy = devm_kzalloc(&client->dev, sizeof(struct microread_i2c_phy),
 			   GFP_KERNEL);
 	if (!phy)
@@ -262,8 +260,6 @@ static int microread_i2c_probe(struct i2c_client *client,
 	if (r < 0)
 		goto err_irq;
 
-	nfc_info(&client->dev, "Probed\n");
-
 	return 0;
 
 err_irq:
diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c
index 8edf761a6b2a..686be3381727 100644
--- a/drivers/nfc/microread/mei.c
+++ b/drivers/nfc/microread/mei.c
@@ -23,8 +23,6 @@ static int microread_mei_probe(struct mei_cl_device *cldev,
 	struct nfc_mei_phy *phy;
 	int r;
 
-	pr_info("Probing NFC microread\n");
-
 	phy = nfc_mei_phy_alloc(cldev);
 	if (!phy) {
 		pr_err("Cannot allocate memory for microread mei phy.\n");
-- 
2.30.2
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Krzysztof Opasiak <k.opasiak@samsung.com>,
	Mark Greer <mgreer@animalcreek.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-nfc@lists.01.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [PATCH 13/15] nfc: microread: drop unneeded debug prints
Date: Tue,  7 Sep 2021 14:18:14 +0200	[thread overview]
Message-ID: <20210907121816.37750-14-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210907121816.37750-1-krzysztof.kozlowski@canonical.com>

ftrace is a preferred and standard way to debug entering and exiting
functions so drop useless debug prints.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/nfc/microread/i2c.c | 4 ----
 drivers/nfc/microread/mei.c | 2 --
 2 files changed, 6 deletions(-)

diff --git a/drivers/nfc/microread/i2c.c b/drivers/nfc/microread/i2c.c
index 86f593c73ed6..067295124eb9 100644
--- a/drivers/nfc/microread/i2c.c
+++ b/drivers/nfc/microread/i2c.c
@@ -237,8 +237,6 @@ static int microread_i2c_probe(struct i2c_client *client,
 	struct microread_i2c_phy *phy;
 	int r;
 
-	dev_dbg(&client->dev, "client %p\n", client);
-
 	phy = devm_kzalloc(&client->dev, sizeof(struct microread_i2c_phy),
 			   GFP_KERNEL);
 	if (!phy)
@@ -262,8 +260,6 @@ static int microread_i2c_probe(struct i2c_client *client,
 	if (r < 0)
 		goto err_irq;
 
-	nfc_info(&client->dev, "Probed\n");
-
 	return 0;
 
 err_irq:
diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c
index 8edf761a6b2a..686be3381727 100644
--- a/drivers/nfc/microread/mei.c
+++ b/drivers/nfc/microread/mei.c
@@ -23,8 +23,6 @@ static int microread_mei_probe(struct mei_cl_device *cldev,
 	struct nfc_mei_phy *phy;
 	int r;
 
-	pr_info("Probing NFC microread\n");
-
 	phy = nfc_mei_phy_alloc(cldev);
 	if (!phy) {
 		pr_err("Cannot allocate memory for microread mei phy.\n");
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: linux-nfc@lists.01.org
Subject: [PATCH 13/15] nfc: microread: drop unneeded debug prints
Date: Tue, 07 Sep 2021 14:18:14 +0200	[thread overview]
Message-ID: <20210907121816.37750-14-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210907121816.37750-1-krzysztof.kozlowski@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

ftrace is a preferred and standard way to debug entering and exiting
functions so drop useless debug prints.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/nfc/microread/i2c.c | 4 ----
 drivers/nfc/microread/mei.c | 2 --
 2 files changed, 6 deletions(-)

diff --git a/drivers/nfc/microread/i2c.c b/drivers/nfc/microread/i2c.c
index 86f593c73ed6..067295124eb9 100644
--- a/drivers/nfc/microread/i2c.c
+++ b/drivers/nfc/microread/i2c.c
@@ -237,8 +237,6 @@ static int microread_i2c_probe(struct i2c_client *client,
 	struct microread_i2c_phy *phy;
 	int r;
 
-	dev_dbg(&client->dev, "client %p\n", client);
-
 	phy = devm_kzalloc(&client->dev, sizeof(struct microread_i2c_phy),
 			   GFP_KERNEL);
 	if (!phy)
@@ -262,8 +260,6 @@ static int microread_i2c_probe(struct i2c_client *client,
 	if (r < 0)
 		goto err_irq;
 
-	nfc_info(&client->dev, "Probed\n");
-
 	return 0;
 
 err_irq:
diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c
index 8edf761a6b2a..686be3381727 100644
--- a/drivers/nfc/microread/mei.c
+++ b/drivers/nfc/microread/mei.c
@@ -23,8 +23,6 @@ static int microread_mei_probe(struct mei_cl_device *cldev,
 	struct nfc_mei_phy *phy;
 	int r;
 
-	pr_info("Probing NFC microread\n");
-
 	phy = nfc_mei_phy_alloc(cldev);
 	if (!phy) {
 		pr_err("Cannot allocate memory for microread mei phy.\n");
-- 
2.30.2

  parent reply	other threads:[~2021-09-07 12:18 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 12:18 [PATCH 00/15] nfc: minor printk cleanup Krzysztof Kozlowski
2021-09-07 12:18 ` Krzysztof Kozlowski
2021-09-07 12:18 ` [linux-nfc] " Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 01/15] nfc: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` [linux-nfc] " Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 02/15] nfc: do not break pr_debug() call into separate lines Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` [linux-nfc] " Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 03/15] nfc: nci: replace GPLv2 boilerplate with SPDX Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` [linux-nfc] " Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 04/15] nfc: fdp: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` [linux-nfc] " Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 05/15] nfc: pn533: " Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` [linux-nfc] " Krzysztof Kozlowski
2021-09-07 16:05   ` Krzysztof Kozlowski
2021-09-07 16:05     ` Krzysztof Kozlowski
2021-09-07 16:05     ` [linux-nfc] " Krzysztof Kozlowski
2021-09-07 17:03     ` Jakub Kicinski
2021-09-07 17:06       ` Krzysztof Kozlowski
2021-09-07 17:06         ` Krzysztof Kozlowski
2021-09-07 17:06         ` [linux-nfc] " Krzysztof Kozlowski
2021-09-07 17:14   ` kernel test robot
2021-09-07 17:25   ` kernel test robot
2021-09-07 17:25     ` kernel test robot
2021-09-07 12:18 ` [linux-nfc] [PATCH 06/15] nfc: pn533: use dev_err() instead of pr_err() Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18 ` [linux-nfc] [PATCH 07/15] nfc: pn544: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18 ` [linux-nfc] [PATCH 08/15] nfc: pn544: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 09/15] nfc: s3fwrn5: simplify dereferencing pointer to struct device Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` [linux-nfc] " Krzysztof Kozlowski
2021-09-07 12:18 ` [linux-nfc] [PATCH 10/15] nfc: st-nci: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18 ` [linux-nfc] [PATCH 11/15] nfc: st21nfca: " Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18 ` [linux-nfc] [PATCH 12/15] nfc: trf7970a: " Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18 ` Krzysztof Kozlowski [this message]
2021-09-07 12:18   ` [PATCH 13/15] nfc: microread: " Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18 ` [linux-nfc] [PATCH 14/15] nfc: microread: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18 ` [linux-nfc] [PATCH 15/15] nfc: mrvl: " Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski
2021-09-07 12:18   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907121816.37750-14-krzysztof.kozlowski@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=davem@davemloft.net \
    --cc=k.opasiak@samsung.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfc@lists.01.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mgreer@animalcreek.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.