From: Nishanth Menon <nm@ti.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Bao Cheng Su <baocheng.su@siemens.com>,
Chao Zeng <chao.zeng@siemens.com>
Subject: Re: [PATCH 1/3] arm64: dts: ti: iot2050: Flip mmc device ordering on Advanced devices
Date: Tue, 7 Sep 2021 10:27:46 -0500 [thread overview]
Message-ID: <20210907152746.fbddtkktvx6hb5ti@cattishly> (raw)
In-Reply-To: <35e0cadf-526c-6402-fb8e-8cdb8b7a0bfe@siemens.com>
On 17:20-20210907, Jan Kiszka wrote:
> On 07.09.21 17:13, Nishanth Menon wrote:
> > On 16:22-20210907, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> This ensures that the SD card will remain mmc0 across Basic and Advanced
> >> devices, also avoiding surprises for users coming from the downstream
> >> kernels.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts
> >> index ec9617c13cdb..d1d5278e0b94 100644
> >> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts
> >> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts
> >> @@ -18,6 +18,11 @@ / {
> >> compatible = "siemens,iot2050-advanced", "ti,am654";
> >> model = "SIMATIC IOT2050 Advanced";
> >>
> >> + aliases {
> >> + mmc0 = &sdhci1;
> >> + mmc1 = &sdhci0;
> >> + };
> >
> >
> > Should we do this at SoC level?
> >
>
> Well, I wouldn't mind - but that would also impact your EVMs. For us,
> this is fine as we are coming from that ordering above with our
> downstream kernel/dts.
>
I think it'd probably be a welcome change. overall we've standardized on
partuuid.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Bao Cheng Su <baocheng.su@siemens.com>,
Chao Zeng <chao.zeng@siemens.com>
Subject: Re: [PATCH 1/3] arm64: dts: ti: iot2050: Flip mmc device ordering on Advanced devices
Date: Tue, 7 Sep 2021 10:27:46 -0500 [thread overview]
Message-ID: <20210907152746.fbddtkktvx6hb5ti@cattishly> (raw)
In-Reply-To: <35e0cadf-526c-6402-fb8e-8cdb8b7a0bfe@siemens.com>
On 17:20-20210907, Jan Kiszka wrote:
> On 07.09.21 17:13, Nishanth Menon wrote:
> > On 16:22-20210907, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> This ensures that the SD card will remain mmc0 across Basic and Advanced
> >> devices, also avoiding surprises for users coming from the downstream
> >> kernels.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts
> >> index ec9617c13cdb..d1d5278e0b94 100644
> >> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts
> >> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts
> >> @@ -18,6 +18,11 @@ / {
> >> compatible = "siemens,iot2050-advanced", "ti,am654";
> >> model = "SIMATIC IOT2050 Advanced";
> >>
> >> + aliases {
> >> + mmc0 = &sdhci1;
> >> + mmc1 = &sdhci0;
> >> + };
> >
> >
> > Should we do this at SoC level?
> >
>
> Well, I wouldn't mind - but that would also impact your EVMs. For us,
> this is fine as we are coming from that ordering above with our
> downstream kernel/dts.
>
I think it'd probably be a welcome change. overall we've standardized on
partuuid.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-07 15:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 14:22 [PATCH 0/3] arm64: dts: Update IOT2050 boards Jan Kiszka
2021-09-07 14:22 ` Jan Kiszka
2021-09-07 14:22 ` [PATCH 1/3] arm64: dts: ti: iot2050: Flip mmc device ordering on Advanced devices Jan Kiszka
2021-09-07 14:22 ` Jan Kiszka
2021-09-07 15:13 ` Nishanth Menon
2021-09-07 15:13 ` Nishanth Menon
2021-09-07 15:20 ` Jan Kiszka
2021-09-07 15:20 ` Jan Kiszka
2021-09-07 15:27 ` Nishanth Menon [this message]
2021-09-07 15:27 ` Nishanth Menon
2021-09-07 15:30 ` Jan Kiszka
2021-09-07 15:30 ` Jan Kiszka
2021-09-07 15:35 ` Nishanth Menon
2021-09-07 15:35 ` Nishanth Menon
2021-09-07 16:47 ` Aswath Govindraju
2021-09-07 16:47 ` Aswath Govindraju
2021-09-07 16:53 ` Nishanth Menon
2021-09-07 16:53 ` Nishanth Menon
2021-09-07 17:01 ` Aswath Govindraju
2021-09-07 17:01 ` Aswath Govindraju
2021-09-07 20:28 ` Jan Kiszka
2021-09-07 20:28 ` Jan Kiszka
2021-09-08 2:47 ` Nishanth Menon
2021-09-08 2:47 ` Nishanth Menon
2021-09-07 14:22 ` [PATCH 2/3] arm64: dts: ti: iot2050: Disable SR2.0-only PRUs Jan Kiszka
2021-09-07 14:22 ` Jan Kiszka
2021-09-07 14:22 ` [PATCH 3/3] arm64: dts: ti: iot2050: Add support for product generation 2 boards Jan Kiszka
2021-09-07 14:22 ` Jan Kiszka
2021-09-07 15:16 ` Nishanth Menon
2021-09-07 15:16 ` Nishanth Menon
2021-09-07 15:27 ` Jan Kiszka
2021-09-07 15:27 ` Jan Kiszka
2021-09-07 15:37 ` Nishanth Menon
2021-09-07 15:37 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907152746.fbddtkktvx6hb5ti@cattishly \
--to=nm@ti.com \
--cc=baocheng.su@siemens.com \
--cc=chao.zeng@siemens.com \
--cc=devicetree@vger.kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.