From: kernel test robot <lkp@intel.com> To: Krzysztof Adamski <krzysztof.adamski@nokia.com>, Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com> Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Rob Herring <robh+dt@kernel.org>, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 4/8] hwmon: (tmp421) add support for defining labels from DT Date: Wed, 8 Sep 2021 02:28:48 +0800 [thread overview] Message-ID: <202109080211.FT4fZ6YM-lkp@intel.com> (raw) In-Reply-To: <22639314543a98b4c24e55b7e5a803325ad9e568.1631021349.git.krzysztof.adamski@nokia.com> [-- Attachment #1: Type: text/plain, Size: 3806 bytes --] Hi Krzysztof, I love your patch! Perhaps something to improve: [auto build test WARNING on hwmon/hwmon-next] [also build test WARNING on robh/for-next v5.14 next-20210907] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20210907-214724 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: mips-randconfig-c004-20210907 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9c476172b93367d2cb88d7d3f4b1b5b456fa6020) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/0day-ci/linux/commit/50e1eb6bf222a2fb0df304033f2aaed075fd76b2 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20210907-214724 git checkout 50e1eb6bf222a2fb0df304033f2aaed075fd76b2 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> drivers/hwmon/tmp421.c:295:6: warning: no previous prototype for function 'tmp421_probe_child_from_dt' [-Wmissing-prototypes] void tmp421_probe_child_from_dt(struct i2c_client *client, ^ drivers/hwmon/tmp421.c:295:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void tmp421_probe_child_from_dt(struct i2c_client *client, ^ static >> drivers/hwmon/tmp421.c:319:6: warning: no previous prototype for function 'tmp421_probe_from_dt' [-Wmissing-prototypes] void tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *data) ^ drivers/hwmon/tmp421.c:319:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *data) ^ static 2 warnings generated. vim +/tmp421_probe_child_from_dt +295 drivers/hwmon/tmp421.c 294 > 295 void tmp421_probe_child_from_dt(struct i2c_client *client, 296 struct device_node *child, 297 struct tmp421_data *data) 298 299 { 300 struct device *dev = &client->dev; 301 u32 i; 302 int err; 303 304 err = of_property_read_u32(child, "reg", &i); 305 if (err) { 306 dev_err(dev, "missing reg property of %pOFn\n", child); 307 return; 308 } else if (i > MAX_CHANNELS) { 309 dev_err(dev, "invalid reg %d of %pOFn\n", i, child); 310 return; 311 } 312 313 of_property_read_string(child, "label", &data->channel[i].label); 314 if (data->channel[i].label) 315 data->temp_config[i] |= HWMON_T_LABEL; 316 317 } 318 > 319 void tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *data) 320 { 321 struct device *dev = &client->dev; 322 const struct device_node *np = dev->of_node; 323 struct device_node *child; 324 325 for_each_child_of_node(np, child) { 326 tmp421_probe_child_from_dt(client, child, data); 327 } 328 } 329 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 32497 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 4/8] hwmon: (tmp421) add support for defining labels from DT Date: Wed, 08 Sep 2021 02:28:48 +0800 [thread overview] Message-ID: <202109080211.FT4fZ6YM-lkp@intel.com> (raw) In-Reply-To: <22639314543a98b4c24e55b7e5a803325ad9e568.1631021349.git.krzysztof.adamski@nokia.com> [-- Attachment #1: Type: text/plain, Size: 3898 bytes --] Hi Krzysztof, I love your patch! Perhaps something to improve: [auto build test WARNING on hwmon/hwmon-next] [also build test WARNING on robh/for-next v5.14 next-20210907] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20210907-214724 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: mips-randconfig-c004-20210907 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9c476172b93367d2cb88d7d3f4b1b5b456fa6020) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/0day-ci/linux/commit/50e1eb6bf222a2fb0df304033f2aaed075fd76b2 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20210907-214724 git checkout 50e1eb6bf222a2fb0df304033f2aaed075fd76b2 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> drivers/hwmon/tmp421.c:295:6: warning: no previous prototype for function 'tmp421_probe_child_from_dt' [-Wmissing-prototypes] void tmp421_probe_child_from_dt(struct i2c_client *client, ^ drivers/hwmon/tmp421.c:295:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void tmp421_probe_child_from_dt(struct i2c_client *client, ^ static >> drivers/hwmon/tmp421.c:319:6: warning: no previous prototype for function 'tmp421_probe_from_dt' [-Wmissing-prototypes] void tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *data) ^ drivers/hwmon/tmp421.c:319:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *data) ^ static 2 warnings generated. vim +/tmp421_probe_child_from_dt +295 drivers/hwmon/tmp421.c 294 > 295 void tmp421_probe_child_from_dt(struct i2c_client *client, 296 struct device_node *child, 297 struct tmp421_data *data) 298 299 { 300 struct device *dev = &client->dev; 301 u32 i; 302 int err; 303 304 err = of_property_read_u32(child, "reg", &i); 305 if (err) { 306 dev_err(dev, "missing reg property of %pOFn\n", child); 307 return; 308 } else if (i > MAX_CHANNELS) { 309 dev_err(dev, "invalid reg %d of %pOFn\n", i, child); 310 return; 311 } 312 313 of_property_read_string(child, "label", &data->channel[i].label); 314 if (data->channel[i].label) 315 data->temp_config[i] |= HWMON_T_LABEL; 316 317 } 318 > 319 void tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *data) 320 { 321 struct device *dev = &client->dev; 322 const struct device_node *np = dev->of_node; 323 struct device_node *child; 324 325 for_each_child_of_node(np, child) { 326 tmp421_probe_child_from_dt(client, child, data); 327 } 328 } 329 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 32497 bytes --]
next prev parent reply other threads:[~2021-09-07 18:29 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-07 13:41 [PATCH 0/8] Add per channel properies support in tmp421 Krzysztof Adamski 2021-09-07 13:42 ` [PATCH 1/8] dt-bindings: hwmon: add missing tmp421 binding Krzysztof Adamski 2021-09-20 22:21 ` Rob Herring 2021-09-07 13:42 ` [PATCH 2/8] hwmon: (tmp421) introduce MAX_CHANNELS define Krzysztof Adamski 2021-09-07 13:43 ` [PATCH 3/8] hwmon: (tmp421) introduce a channel struct Krzysztof Adamski 2021-09-07 13:43 ` [PATCH 4/8] hwmon: (tmp421) add support for defining labels from DT Krzysztof Adamski 2021-09-07 15:46 ` Guenter Roeck 2021-09-07 17:49 ` Krzysztof Adamski 2021-09-07 17:55 ` Guenter Roeck 2021-09-07 18:08 ` Krzysztof Adamski 2021-09-07 18:28 ` kernel test robot [this message] 2021-09-07 18:28 ` kernel test robot 2021-09-09 17:29 ` kernel test robot 2021-09-09 17:29 ` kernel test robot 2021-09-09 17:29 ` [RFC PATCH] hwmon: tmp421_probe_child_from_dt() can be static kernel test robot 2021-09-09 17:29 ` kernel test robot 2021-09-07 13:43 ` [PATCH 5/8] hwmon: (tmp421) support disabling channels from DT Krzysztof Adamski 2021-09-07 15:33 ` Guenter Roeck 2021-09-07 13:45 ` [PATCH 6/8] hwmon: (tmp421) support specifying n-factor via DT Krzysztof Adamski 2021-09-07 15:42 ` Guenter Roeck 2021-09-07 13:46 ` [PATCH 7/8] hwmon: (tmp421) really disable channels Krzysztof Adamski 2021-09-07 15:37 ` Guenter Roeck 2021-09-07 19:52 ` kernel test robot 2021-09-07 19:52 ` kernel test robot 2021-09-09 20:40 ` kernel test robot 2021-09-09 20:40 ` kernel test robot 2021-09-09 20:40 ` [RFC PATCH] hwmon: tmp421_disable_channels() can be static kernel test robot 2021-09-09 20:40 ` kernel test robot 2021-09-07 13:46 ` [PATCH 8/8] dt-bindings: hwmon: allow specifying channels for tmp421 Krzysztof Adamski 2021-09-07 15:46 ` Guenter Roeck 2021-09-07 18:04 ` Krzysztof Adamski 2021-09-20 22:24 ` Rob Herring 2021-09-21 12:58 ` Guenter Roeck 2021-09-21 19:06 ` Rob Herring 2021-09-21 20:52 ` Guenter Roeck 2021-09-21 21:21 ` Oskar Senft 2021-09-21 22:03 ` Oskar Senft 2021-09-23 15:30 ` Rob Herring 2021-09-24 0:29 ` Guenter Roeck 2021-09-24 7:53 ` Krzysztof Adamski 2021-09-24 11:46 ` Guenter Roeck 2021-09-24 15:37 ` Oskar Senft 2021-09-25 13:26 ` Guenter Roeck 2021-10-08 12:55 ` Oskar Senft 2021-10-08 13:11 ` Guenter Roeck 2021-09-22 7:22 ` Krzysztof Adamski 2021-09-22 12:39 ` Guenter Roeck 2021-09-22 18:32 ` Krzysztof Adamski 2021-09-23 0:38 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202109080211.FT4fZ6YM-lkp@intel.com \ --to=lkp@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=jdelvare@suse.com \ --cc=kbuild-all@lists.01.org \ --cc=krzysztof.adamski@nokia.com \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=llvm@lists.linux.dev \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.