From: kernel test robot <lkp@intel.com> To: Nicolas Dichtel <nicolas.dichtel@6wind.com>, steffen.klassert@secunet.com, davem@davemloft.net, kuba@kernel.org, antony.antony@secunet.com Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, netdev@vger.kernel.org, Nicolas Dichtel <nicolas.dichtel@6wind.com> Subject: Re: [PATCH ipsec 2/2] xfrm: notify default policy on update Date: Wed, 8 Sep 2021 09:35:19 +0800 [thread overview] Message-ID: <202109080912.cNYfj6Ho-lkp@intel.com> (raw) In-Reply-To: <20210907193510.16487-3-nicolas.dichtel@6wind.com> [-- Attachment #1: Type: text/plain, Size: 3514 bytes --] Hi Nicolas, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipsec-next/master] [also build test ERROR on net-next/master net/master next-20210907] [cannot apply to ipsec/master v5.14] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nicolas-Dichtel/xfrm-make-user-policy-API-complete/20210908-043604 base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master config: x86_64-randconfig-a011-20210906 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9c476172b93367d2cb88d7d3f4b1b5b456fa6020) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/6f3af39482e7fa1c873b3e6ee460a03feb7b796a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nicolas-Dichtel/xfrm-make-user-policy-API-complete/20210908-043604 git checkout 6f3af39482e7fa1c873b3e6ee460a03feb7b796a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> net/xfrm/xfrm_user.c:1991:30: error: passing 'const struct net *' to parameter of type 'struct net *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] return xfrm_nlmsg_multicast(net, skb, 0, XFRMNLGRP_POLICY); ^~~ net/xfrm/xfrm_user.c:1154:52: note: passing argument to parameter 'net' here static inline int xfrm_nlmsg_multicast(struct net *net, struct sk_buff *skb, ^ net/xfrm/xfrm_user.c:2027:41: warning: variable 'up' set but not used [-Wunused-but-set-variable] struct xfrm_userpolicy_default *r_up, *up; ^ 1 warning and 1 error generated. vim +1991 net/xfrm/xfrm_user.c 1963 1964 static int xfrm_notify_userpolicy(const struct net *net) 1965 { 1966 struct xfrm_userpolicy_default *up; 1967 int len = NLMSG_ALIGN(sizeof(*up)); 1968 struct nlmsghdr *nlh; 1969 struct sk_buff *skb; 1970 1971 skb = nlmsg_new(len, GFP_ATOMIC); 1972 if (skb == NULL) 1973 return -ENOMEM; 1974 1975 nlh = nlmsg_put(skb, 0, 0, XFRM_MSG_GETDEFAULT, sizeof(*up), 0); 1976 if (nlh == NULL) { 1977 kfree_skb(skb); 1978 return -EMSGSIZE; 1979 } 1980 1981 up = nlmsg_data(nlh); 1982 up->in = net->xfrm.policy_default & XFRM_POL_DEFAULT_IN ? 1983 XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT; 1984 up->fwd = net->xfrm.policy_default & XFRM_POL_DEFAULT_FWD ? 1985 XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT; 1986 up->out = net->xfrm.policy_default & XFRM_POL_DEFAULT_OUT ? 1987 XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT; 1988 1989 nlmsg_end(skb, nlh); 1990 > 1991 return xfrm_nlmsg_multicast(net, skb, 0, XFRMNLGRP_POLICY); 1992 } 1993 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 37256 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH ipsec 2/2] xfrm: notify default policy on update Date: Wed, 08 Sep 2021 09:35:19 +0800 [thread overview] Message-ID: <202109080912.cNYfj6Ho-lkp@intel.com> (raw) In-Reply-To: <20210907193510.16487-3-nicolas.dichtel@6wind.com> [-- Attachment #1: Type: text/plain, Size: 3595 bytes --] Hi Nicolas, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipsec-next/master] [also build test ERROR on net-next/master net/master next-20210907] [cannot apply to ipsec/master v5.14] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nicolas-Dichtel/xfrm-make-user-policy-API-complete/20210908-043604 base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master config: x86_64-randconfig-a011-20210906 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9c476172b93367d2cb88d7d3f4b1b5b456fa6020) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/6f3af39482e7fa1c873b3e6ee460a03feb7b796a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nicolas-Dichtel/xfrm-make-user-policy-API-complete/20210908-043604 git checkout 6f3af39482e7fa1c873b3e6ee460a03feb7b796a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> net/xfrm/xfrm_user.c:1991:30: error: passing 'const struct net *' to parameter of type 'struct net *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] return xfrm_nlmsg_multicast(net, skb, 0, XFRMNLGRP_POLICY); ^~~ net/xfrm/xfrm_user.c:1154:52: note: passing argument to parameter 'net' here static inline int xfrm_nlmsg_multicast(struct net *net, struct sk_buff *skb, ^ net/xfrm/xfrm_user.c:2027:41: warning: variable 'up' set but not used [-Wunused-but-set-variable] struct xfrm_userpolicy_default *r_up, *up; ^ 1 warning and 1 error generated. vim +1991 net/xfrm/xfrm_user.c 1963 1964 static int xfrm_notify_userpolicy(const struct net *net) 1965 { 1966 struct xfrm_userpolicy_default *up; 1967 int len = NLMSG_ALIGN(sizeof(*up)); 1968 struct nlmsghdr *nlh; 1969 struct sk_buff *skb; 1970 1971 skb = nlmsg_new(len, GFP_ATOMIC); 1972 if (skb == NULL) 1973 return -ENOMEM; 1974 1975 nlh = nlmsg_put(skb, 0, 0, XFRM_MSG_GETDEFAULT, sizeof(*up), 0); 1976 if (nlh == NULL) { 1977 kfree_skb(skb); 1978 return -EMSGSIZE; 1979 } 1980 1981 up = nlmsg_data(nlh); 1982 up->in = net->xfrm.policy_default & XFRM_POL_DEFAULT_IN ? 1983 XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT; 1984 up->fwd = net->xfrm.policy_default & XFRM_POL_DEFAULT_FWD ? 1985 XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT; 1986 up->out = net->xfrm.policy_default & XFRM_POL_DEFAULT_OUT ? 1987 XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT; 1988 1989 nlmsg_end(skb, nlh); 1990 > 1991 return xfrm_nlmsg_multicast(net, skb, 0, XFRMNLGRP_POLICY); 1992 } 1993 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 37256 bytes --]
next prev parent reply other threads:[~2021-09-08 1:36 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20210331144843.GA25749@moon.secunet.de> 2021-07-16 9:15 ` [PATCH ipsec-next] xfrm: Add possibility to set the default to block if we have no policy Antony Antony 2021-07-18 3:26 ` kernel test robot 2021-07-18 3:26 ` kernel test robot 2021-07-18 7:11 ` [PATCH v2 " Antony Antony 2021-07-22 9:43 ` Steffen Klassert 2021-08-11 16:14 ` Nicolas Dichtel 2021-08-17 11:19 ` Antony Antony 2021-08-25 10:01 ` Nicolas Dichtel 2021-09-07 19:35 ` [PATCH ipsec 0/2] xfrm: fix uapi for the default policy Nicolas Dichtel 2021-09-07 19:35 ` [PATCH ipsec 1/2] xfrm: make user policy API complete Nicolas Dichtel 2021-09-07 19:35 ` [PATCH ipsec 2/2] xfrm: notify default policy on update Nicolas Dichtel 2021-09-08 1:35 ` kernel test robot [this message] 2021-09-08 1:35 ` kernel test robot 2021-09-08 7:23 ` [PATCH ipsec v2 0/2] xfrm: fix uapi for the default policy Nicolas Dichtel 2021-09-08 7:23 ` [PATCH ipsec v2 1/2] xfrm: make user policy API complete Nicolas Dichtel 2021-09-08 7:23 ` [PATCH ipsec v2 2/2] xfrm: notify default policy on update Nicolas Dichtel 2021-09-08 7:23 ` [RFC PATCH iproute2 v2] xfrm: enable to manage default policies Nicolas Dichtel 2021-09-14 14:46 ` [PATCH ipsec v3 0/2] xfrm: fix uapi for the default policy Nicolas Dichtel 2021-09-14 14:46 ` [PATCH ipsec v3 1/2] xfrm: make user policy API complete Nicolas Dichtel 2021-09-14 14:46 ` [PATCH ipsec v3 2/2] xfrm: notify default policy on update Nicolas Dichtel 2021-09-14 14:46 ` [RFC PATCH iproute2 v2] xfrm: enable to manage default policies Nicolas Dichtel 2021-09-15 9:19 ` [PATCH ipsec v3 0/2] xfrm: fix uapi for the default policy Antony Antony 2021-09-15 9:55 ` Nicolas Dichtel 2021-09-17 7:06 ` Steffen Klassert 2021-09-17 7:54 ` Nicolas Dichtel 2021-09-07 19:35 ` [RFC PATCH iproute2] xfrm: enable to manage default policies Nicolas Dichtel 2021-09-01 15:14 ` [PATCH v2 ipsec-next] xfrm: Add possibility to set the default to block if we have no policy Dmitry V. Levin 2021-09-02 9:05 ` Steffen Klassert 2021-09-19 22:40 ` Paul Cercueil 2021-09-21 6:33 ` Steffen Klassert
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202109080912.cNYfj6Ho-lkp@intel.com \ --to=lkp@intel.com \ --cc=antony.antony@secunet.com \ --cc=davem@davemloft.net \ --cc=kbuild-all@lists.01.org \ --cc=kuba@kernel.org \ --cc=llvm@lists.linux.dev \ --cc=netdev@vger.kernel.org \ --cc=nicolas.dichtel@6wind.com \ --cc=steffen.klassert@secunet.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.