All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 09/11] tests/kms_big_fb: Check whether the rotation is supposed in the async flip test
Date: Thu,  9 Sep 2021 18:30:45 +0300	[thread overview]
Message-ID: <20210909153047.16729-10-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20210909153047.16729-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Don't corrupt the plane state with some totally unsupported
rotation. Doing so causes subseuqenct subtests to just fail
on account of that bad rotation state leaking between the
subtests.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_big_fb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index 6be3062bd335..d38c24a70d2b 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -489,6 +489,7 @@ max_hw_stride_async_flip_test(data_t *data)
 
 	primary = igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_PRIMARY);
 
+	igt_require(igt_plane_has_rotation(primary, data->rotation));
 	igt_plane_set_rotation(primary, data->rotation);
 
 	igt_require_f(igt_display_try_commit2(&data->display, COMMIT_ATOMIC) == 0,
-- 
2.31.1

  parent reply	other threads:[~2021-09-09 15:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09 15:30 [igt-dev] [PATCH i-g-t v2 00/11] kms: Clean up the supported rotations mess Ville Syrjala
2021-09-09 15:30 ` [igt-dev] [PATCH i-g-t v2 01/11] lib/kms: Add igt_plane_has_rotation() Ville Syrjala
2021-09-20  7:37   ` Karthik B S
2021-09-09 15:30 ` [igt-dev] [PATCH i-g-t v2 02/11] tests/kms_rotation_crc: Use igt_plane_has_rotation() Ville Syrjala
2021-09-20  7:42   ` Karthik B S
2021-09-09 15:30 ` [igt-dev] [PATCH i-g-t v2 03/11] tests/kms_plane_scaling: " Ville Syrjala
2021-09-20  7:45   ` Karthik B S
2021-09-09 15:30 ` [igt-dev] [PATCH i-g-t v2 04/11] tests/kms_big_fb: " Ville Syrjala
2021-09-20  7:46   ` Karthik B S
2021-09-09 15:30 ` [igt-dev] [PATCH i-g-t v2 05/11] tests/kms_big_fb: Use igt_has_drm_cap() Ville Syrjala
2021-09-20  7:48   ` Karthik B S
2021-09-09 15:30 ` [igt-dev] [PATCH i-g-t v2 06/11] tests/kms_big_fb: Move batch creation into lower level functions Ville Syrjala
2021-09-09 15:30 ` [igt-dev] [PATCH i-g-t v2 07/11] tests/kms_big_fb: Move format/modifier checks lower Ville Syrjala
2021-09-09 15:30 ` [igt-dev] [PATCH i-g-t v2 08/11] tests/kms_big_fb: Nuke the stride/format overrides Ville Syrjala
2021-09-09 15:30 ` Ville Syrjala [this message]
2021-09-09 15:30 ` [igt-dev] [PATCH i-g-t v2 10/11] tests/kms_plane: Abstract single vs. multiple crsc better Ville Syrjala
2021-09-09 15:30 ` [igt-dev] [PATCH i-g-t v2 11/11] tests/kms_plane: Use single colors during extended test Ville Syrjala
2021-09-09 16:32 ` [igt-dev] ✓ Fi.CI.BAT: success for kms: Clean up the supported rotations mess (rev3) Patchwork
2021-09-09 17:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-11-10 18:03 ` [igt-dev] [PATCH i-g-t v2 00/11] kms: Clean up the supported rotations mess Juha-Pekka Heikkila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210909153047.16729-10-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.