Re: [igt-dev] [PATCH i-g-t v2 04/11] tests/kms_big_fb: Use igt_plane_has_rotation()

[Karthik B S <karthik.b.s@intel.com>]

On 9/9/2021 9:00 PM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Use igt_plane_has_rotation() instead of the manual
> "if there's no rotation prop -> only 0 dgree is supported"
> conclusion.
>
> And let's also get rid of the atomic vs. 0/270 degree rotation
> check. I think I added this to avoid the test failing since
> we can't do the TEST_ONLY probe withoiut atomic. With the
> unsupported rotations filtered out ahead of time we should
> never get into that situation.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Looks good to me.

Reviewed-by: Karthik B S <karthik.b.s@intel.com>

> ---
>   tests/kms_big_fb.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
> index b988a092771a..092cbc6846fe 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -323,14 +323,7 @@ static bool test_plane(data_t *data)
>   	if (!igt_plane_has_format_mod(plane, data->format, data->modifier))
>   		return false;
>   
> -	if (data->rotation != IGT_ROTATION_0 &&
> -	    !igt_plane_has_prop(plane, IGT_PLANE_ROTATION))
> -		return false;
> -
> -	/* FIXME need atomic on i965/g4x */
> -	if (data->rotation != IGT_ROTATION_0 &&
> -	    data->rotation != IGT_ROTATION_180 &&
> -	    !data->display.is_atomic)
> +	if (!igt_plane_has_rotation(plane, data->rotation))
>   		return false;
>   
>   	if (igt_plane_has_prop(plane, IGT_PLANE_ROTATION))