* [Intel-wired-lan] [PATCH v1 1/1] igc: Update the device ID
@ 2021-09-09 17:49 Sasha Neftin
2021-09-10 7:28 ` Paul Menzel
2021-09-12 13:45 ` Kraus, NechamaX
0 siblings, 2 replies; 4+ messages in thread
From: Sasha Neftin @ 2021-09-09 17:49 UTC (permalink / raw)
To: intel-wired-lan
Update device ID for the I226_K part.
Fixes: bfa5e98c9de4 ("igc: Add new device ID")
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
drivers/net/ethernet/intel/igc/igc_hw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ethernet/intel/igc/igc_hw.h
index 772fd06e93ac..587db7483f25 100644
--- a/drivers/net/ethernet/intel/igc/igc_hw.h
+++ b/drivers/net/ethernet/intel/igc/igc_hw.h
@@ -22,9 +22,9 @@
#define IGC_DEV_ID_I220_V 0x15F7
#define IGC_DEV_ID_I225_K 0x3100
#define IGC_DEV_ID_I225_K2 0x3101
+#define IGC_DEV_ID_I226_K 0x3102
#define IGC_DEV_ID_I225_LMVP 0x5502
#define IGC_DEV_ID_I226_LMVP 0x5503
-#define IGC_DEV_ID_I226_K 0x5504
#define IGC_DEV_ID_I225_IT 0x0D9F
#define IGC_DEV_ID_I226_LM 0x125B
#define IGC_DEV_ID_I226_V 0x125C
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH v1 1/1] igc: Update the device ID
2021-09-09 17:49 [Intel-wired-lan] [PATCH v1 1/1] igc: Update the device ID Sasha Neftin
@ 2021-09-10 7:28 ` Paul Menzel
2021-09-22 7:15 ` Sasha Neftin
2021-09-12 13:45 ` Kraus, NechamaX
1 sibling, 1 reply; 4+ messages in thread
From: Paul Menzel @ 2021-09-10 7:28 UTC (permalink / raw)
To: intel-wired-lan
Dear Sasha,
Thank you for the patch.
Am 09.09.21 um 19:49 schrieb Sasha Neftin:
Please mention the device in the commit message summary:
> igc: Update I226_k device ID
> Update device ID for the I226_K part.
Some background would be nice, where the old/wrong(?) ID came from, and
where the new one is specified.
Kind regards,
Paul
> Fixes: bfa5e98c9de4 ("igc: Add new device ID")
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_hw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ethernet/intel/igc/igc_hw.h
> index 772fd06e93ac..587db7483f25 100644
> --- a/drivers/net/ethernet/intel/igc/igc_hw.h
> +++ b/drivers/net/ethernet/intel/igc/igc_hw.h
> @@ -22,9 +22,9 @@
> #define IGC_DEV_ID_I220_V 0x15F7
> #define IGC_DEV_ID_I225_K 0x3100
> #define IGC_DEV_ID_I225_K2 0x3101
> +#define IGC_DEV_ID_I226_K 0x3102
> #define IGC_DEV_ID_I225_LMVP 0x5502
> #define IGC_DEV_ID_I226_LMVP 0x5503
> -#define IGC_DEV_ID_I226_K 0x5504
> #define IGC_DEV_ID_I225_IT 0x0D9F
> #define IGC_DEV_ID_I226_LM 0x125B
> #define IGC_DEV_ID_I226_V 0x125C
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH v1 1/1] igc: Update the device ID
2021-09-09 17:49 [Intel-wired-lan] [PATCH v1 1/1] igc: Update the device ID Sasha Neftin
2021-09-10 7:28 ` Paul Menzel
@ 2021-09-12 13:45 ` Kraus, NechamaX
1 sibling, 0 replies; 4+ messages in thread
From: Kraus, NechamaX @ 2021-09-12 13:45 UTC (permalink / raw)
To: intel-wired-lan
On 9/9/2021 20:49, Sasha Neftin wrote:
> Update device ID for the I226_K part.
>
> Fixes: bfa5e98c9de4 ("igc: Add new device ID")
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_hw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Nechama Kraus <nechamax.kraus@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH v1 1/1] igc: Update the device ID
2021-09-10 7:28 ` Paul Menzel
@ 2021-09-22 7:15 ` Sasha Neftin
0 siblings, 0 replies; 4+ messages in thread
From: Sasha Neftin @ 2021-09-22 7:15 UTC (permalink / raw)
To: intel-wired-lan
On 9/10/2021 10:28, Paul Menzel wrote:
> Dear Sasha,
>
>
> Thank you for the patch.
>
>
> Am 09.09.21 um 19:49 schrieb Sasha Neftin:
>
> Please mention the device in the commit message summary:
>
>> igc: Update I226_k device ID
>
>
>> Update device ID for the I226_K part.
>
> Some background would be nice, where the old/wrong(?) ID came from, and
> where the new one is specified.
Align to the latest documentation comes from our HW architecture team.
>
>
> Kind regards,
>
> Paul
>
>
>> Fixes: bfa5e98c9de4 ("igc: Add new device ID")
>> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
>> ---
>> ? drivers/net/ethernet/intel/igc/igc_hw.h | 2 +-
>> ? 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h
>> b/drivers/net/ethernet/intel/igc/igc_hw.h
>> index 772fd06e93ac..587db7483f25 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_hw.h
>> +++ b/drivers/net/ethernet/intel/igc/igc_hw.h
>> @@ -22,9 +22,9 @@
>> ? #define IGC_DEV_ID_I220_V??????????? 0x15F7
>> ? #define IGC_DEV_ID_I225_K??????????? 0x3100
>> ? #define IGC_DEV_ID_I225_K2??????????? 0x3101
>> +#define IGC_DEV_ID_I226_K??????????? 0x3102
>> ? #define IGC_DEV_ID_I225_LMVP??????????? 0x5502
>> ? #define IGC_DEV_ID_I226_LMVP??????????? 0x5503
>> -#define IGC_DEV_ID_I226_K??????????? 0x5504
>> ? #define IGC_DEV_ID_I225_IT??????????? 0x0D9F
>> ? #define IGC_DEV_ID_I226_LM??????????? 0x125B
>> ? #define IGC_DEV_ID_I226_V??????????? 0x125C
>>
Thanks for the review.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-22 7:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-09 17:49 [Intel-wired-lan] [PATCH v1 1/1] igc: Update the device ID Sasha Neftin
2021-09-10 7:28 ` Paul Menzel
2021-09-22 7:15 ` Sasha Neftin
2021-09-12 13:45 ` Kraus, NechamaX
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.