All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH u-boot-marvell] arm: a37xx: pci: Don't spam about PIO Response Status
@ 2021-09-07 15:27 Marek Behún
  2021-09-09 22:10 ` Pali Rohár
  2021-09-10  6:58 ` Stefan Roese
  0 siblings, 2 replies; 3+ messages in thread
From: Marek Behún @ 2021-09-07 15:27 UTC (permalink / raw)
  To: Stefan Roese; +Cc: u-boot, pali, Marek Behún

Use dev_dbg() instead of dev_err() in pcie_advk_check_pio_status().

For example CRS is not an error status, it just says that the request
should be retried.

Without this, U-Boot spams the terminal with
  pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x100000
  pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x108000
  pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x110000
  pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x120000
  pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x128000
  pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x130000
  ...
when a device is not connected to a PCIe switch (Unsupported Request
from the switch).

Signed-off-by: Marek Behún <marek.behun@nic.cz>
---
 drivers/pci/pci-aardvark.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
index 74797e984c..cf6e30f936 100644
--- a/drivers/pci/pci-aardvark.c
+++ b/drivers/pci/pci-aardvark.c
@@ -327,7 +327,7 @@ static int pcie_advk_check_pio_status(struct pcie_advk *pcie,
 	else
 		str_posted = "Posted";
 
-	dev_err(pcie->dev, "%s PIO Response Status: %s, %#x @ %#x\n",
+	dev_dbg(pcie->dev, "%s PIO Response Status: %s, %#x @ %#x\n",
 		str_posted, strcomp_status, reg,
 		advk_readl(pcie, PIO_ADDR_LS));
 
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH u-boot-marvell] arm: a37xx: pci: Don't spam about PIO Response Status
  2021-09-07 15:27 [PATCH u-boot-marvell] arm: a37xx: pci: Don't spam about PIO Response Status Marek Behún
@ 2021-09-09 22:10 ` Pali Rohár
  2021-09-10  6:58 ` Stefan Roese
  1 sibling, 0 replies; 3+ messages in thread
From: Pali Rohár @ 2021-09-09 22:10 UTC (permalink / raw)
  To: Marek Behún; +Cc: Stefan Roese, u-boot

On Tuesday 07 September 2021 17:27:08 Marek Behún wrote:
> Use dev_dbg() instead of dev_err() in pcie_advk_check_pio_status().
> 
> For example CRS is not an error status, it just says that the request
> should be retried.
> 
> Without this, U-Boot spams the terminal with
>   pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x100000
>   pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x108000
>   pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x110000
>   pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x120000
>   pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x128000
>   pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x130000
>   ...
> when a device is not connected to a PCIe switch (Unsupported Request
> from the switch).
> 
> Signed-off-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Pali Rohár <pali@kernel.org>

> ---
>  drivers/pci/pci-aardvark.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
> index 74797e984c..cf6e30f936 100644
> --- a/drivers/pci/pci-aardvark.c
> +++ b/drivers/pci/pci-aardvark.c
> @@ -327,7 +327,7 @@ static int pcie_advk_check_pio_status(struct pcie_advk *pcie,
>  	else
>  		str_posted = "Posted";
>  
> -	dev_err(pcie->dev, "%s PIO Response Status: %s, %#x @ %#x\n",
> +	dev_dbg(pcie->dev, "%s PIO Response Status: %s, %#x @ %#x\n",
>  		str_posted, strcomp_status, reg,
>  		advk_readl(pcie, PIO_ADDR_LS));
>  
> -- 
> 2.32.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH u-boot-marvell] arm: a37xx: pci: Don't spam about PIO Response Status
  2021-09-07 15:27 [PATCH u-boot-marvell] arm: a37xx: pci: Don't spam about PIO Response Status Marek Behún
  2021-09-09 22:10 ` Pali Rohár
@ 2021-09-10  6:58 ` Stefan Roese
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2021-09-10  6:58 UTC (permalink / raw)
  To: Marek Behún; +Cc: u-boot, pali

On 07.09.21 17:27, Marek Behún wrote:
> Use dev_dbg() instead of dev_err() in pcie_advk_check_pio_status().
> 
> For example CRS is not an error status, it just says that the request
> should be retried.
> 
> Without this, U-Boot spams the terminal with
>    pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x100000
>    pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x108000
>    pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x110000
>    pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x120000
>    pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x128000
>    pcie_advk pcie@d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x130000
>    ...
> when a device is not connected to a PCIe switch (Unsupported Request
> from the switch).
> 
> Signed-off-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   drivers/pci/pci-aardvark.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
> index 74797e984c..cf6e30f936 100644
> --- a/drivers/pci/pci-aardvark.c
> +++ b/drivers/pci/pci-aardvark.c
> @@ -327,7 +327,7 @@ static int pcie_advk_check_pio_status(struct pcie_advk *pcie,
>   	else
>   		str_posted = "Posted";
>   
> -	dev_err(pcie->dev, "%s PIO Response Status: %s, %#x @ %#x\n",
> +	dev_dbg(pcie->dev, "%s PIO Response Status: %s, %#x @ %#x\n",
>   		str_posted, strcomp_status, reg,
>   		advk_readl(pcie, PIO_ADDR_LS));
>   
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-10  6:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 15:27 [PATCH u-boot-marvell] arm: a37xx: pci: Don't spam about PIO Response Status Marek Behún
2021-09-09 22:10 ` Pali Rohár
2021-09-10  6:58 ` Stefan Roese

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.