All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Daniel Latypov <dlatypov@google.com>,
	brendanhiggins@google.com, davidgow@google.com
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
	skhan@linuxfoundation.org, Daniel Latypov <dlatypov@google.com>
Subject: Re: [PATCH v4 2/2] kunit: tool: allow filtering test cases via glob
Date: Fri, 10 Sep 2021 09:49:01 +0800	[thread overview]
Message-ID: <202109100923.n0VbigGb-lkp@intel.com> (raw)
In-Reply-To: <20210909171052.3192326-2-dlatypov@google.com>

[-- Attachment #1: Type: text/plain, Size: 1977 bytes --]

Hi Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on a3fa7a101dcff93791d1b1bdb3affcad1410c8c1]

url:    https://github.com/0day-ci/linux/commits/Daniel-Latypov/kunit-drop-assumption-in-kunit-log-test-about-current-suite/20210910-011213
base:   a3fa7a101dcff93791d1b1bdb3affcad1410c8c1
config: riscv-randconfig-s032-20210910 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/3d5c1af613421e9022fdf3523933c7c5fa3f7357
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Latypov/kunit-drop-assumption-in-kunit-log-test-about-current-suite/20210910-011213
        git checkout 3d5c1af613421e9022fdf3523933c7c5fa3f7357
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=riscv SHELL=/bin/bash lib/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
   lib/kunit/executor.c: note: in included file:
>> lib/kunit/executor_test.c:20:19: sparse: sparse: symbol 'dummy_test_cases' was not declared. Should it be static?

vim +/dummy_test_cases +20 lib/kunit/executor_test.c

    19	
  > 20	struct kunit_case dummy_test_cases[] = {
    21		/* .run_case is not important, just needs to be non-NULL */
    22		{ .name = "test1", .run_case = dummy_test },
    23		{ .name = "test2", .run_case = dummy_test },
    24		{},
    25	};
    26	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32329 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 2/2] kunit: tool: allow filtering test cases via glob
Date: Fri, 10 Sep 2021 09:49:01 +0800	[thread overview]
Message-ID: <202109100923.n0VbigGb-lkp@intel.com> (raw)
In-Reply-To: <20210909171052.3192326-2-dlatypov@google.com>

[-- Attachment #1: Type: text/plain, Size: 2023 bytes --]

Hi Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on a3fa7a101dcff93791d1b1bdb3affcad1410c8c1]

url:    https://github.com/0day-ci/linux/commits/Daniel-Latypov/kunit-drop-assumption-in-kunit-log-test-about-current-suite/20210910-011213
base:   a3fa7a101dcff93791d1b1bdb3affcad1410c8c1
config: riscv-randconfig-s032-20210910 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/3d5c1af613421e9022fdf3523933c7c5fa3f7357
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Latypov/kunit-drop-assumption-in-kunit-log-test-about-current-suite/20210910-011213
        git checkout 3d5c1af613421e9022fdf3523933c7c5fa3f7357
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=riscv SHELL=/bin/bash lib/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
   lib/kunit/executor.c: note: in included file:
>> lib/kunit/executor_test.c:20:19: sparse: sparse: symbol 'dummy_test_cases' was not declared. Should it be static?

vim +/dummy_test_cases +20 lib/kunit/executor_test.c

    19	
  > 20	struct kunit_case dummy_test_cases[] = {
    21		/* .run_case is not important, just needs to be non-NULL */
    22		{ .name = "test1", .run_case = dummy_test },
    23		{ .name = "test2", .run_case = dummy_test },
    24		{},
    25	};
    26	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32329 bytes --]

  reply	other threads:[~2021-09-10  1:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09 17:10 [PATCH v4 1/2] kunit: drop assumption in kunit-log-test about current suite Daniel Latypov
2021-09-09 17:10 ` [PATCH v4 2/2] kunit: tool: allow filtering test cases via glob Daniel Latypov
2021-09-10  1:49   ` kernel test robot [this message]
2021-09-10  1:49     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202109100923.n0VbigGb-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=dlatypov@google.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.