From: Palmer Dabbelt <palmer@dabbelt.com>
To: hjc@rock-chips.com, heiko@sntech.de, Arnd Bergmann <arnd@arndb.de>
Cc: airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-team@android.com,
Palmer Dabbelt <palmerdabbelt@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning
Date: Fri, 10 Sep 2021 20:43:18 -0700 [thread overview]
Message-ID: <20210911034317.1719619-1-palmer@dabbelt.com> (raw)
From: Palmer Dabbelt <palmerdabbelt@google.com>
cdn_dp_resume is only used under PM_SLEEP, and now that it's static an
unused function warning is triggered undner !PM_SLEEP. This marks the
function as possibly unused, to avoid triggering compiler warnings.
Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
This is breaking my builds and looks like it'll land after -rc1, so I've put it
on a shared tag for-rockchip-cdn_dp_resume-v2 which will let me pull it in to
my fixes. LMK if you guys want me to send this up on my own, but I'm assuming
that the drm/rockchip folks will handle it.
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index 8ab3247dbc4a..13c6b857158f 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1123,7 +1123,7 @@ static int cdn_dp_suspend(struct device *dev)
return ret;
}
-static int cdn_dp_resume(struct device *dev)
+static __maybe_unused int cdn_dp_resume(struct device *dev)
{
struct cdn_dp_device *dp = dev_get_drvdata(dev);
--
2.33.0.309.g3052b89438-goog
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@dabbelt.com>
To: hjc@rock-chips.com, heiko@sntech.de, Arnd Bergmann <arnd@arndb.de>
Cc: airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-team@android.com,
Palmer Dabbelt <palmerdabbelt@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning
Date: Fri, 10 Sep 2021 20:43:18 -0700 [thread overview]
Message-ID: <20210911034317.1719619-1-palmer@dabbelt.com> (raw)
From: Palmer Dabbelt <palmerdabbelt@google.com>
cdn_dp_resume is only used under PM_SLEEP, and now that it's static an
unused function warning is triggered undner !PM_SLEEP. This marks the
function as possibly unused, to avoid triggering compiler warnings.
Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
This is breaking my builds and looks like it'll land after -rc1, so I've put it
on a shared tag for-rockchip-cdn_dp_resume-v2 which will let me pull it in to
my fixes. LMK if you guys want me to send this up on my own, but I'm assuming
that the drm/rockchip folks will handle it.
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index 8ab3247dbc4a..13c6b857158f 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1123,7 +1123,7 @@ static int cdn_dp_suspend(struct device *dev)
return ret;
}
-static int cdn_dp_resume(struct device *dev)
+static __maybe_unused int cdn_dp_resume(struct device *dev)
{
struct cdn_dp_device *dp = dev_get_drvdata(dev);
--
2.33.0.309.g3052b89438-goog
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@dabbelt.com>
To: hjc@rock-chips.com, heiko@sntech.de, Arnd Bergmann <arnd@arndb.de>
Cc: airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-team@android.com,
Palmer Dabbelt <palmerdabbelt@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning
Date: Fri, 10 Sep 2021 20:43:18 -0700 [thread overview]
Message-ID: <20210911034317.1719619-1-palmer@dabbelt.com> (raw)
From: Palmer Dabbelt <palmerdabbelt@google.com>
cdn_dp_resume is only used under PM_SLEEP, and now that it's static an
unused function warning is triggered undner !PM_SLEEP. This marks the
function as possibly unused, to avoid triggering compiler warnings.
Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
This is breaking my builds and looks like it'll land after -rc1, so I've put it
on a shared tag for-rockchip-cdn_dp_resume-v2 which will let me pull it in to
my fixes. LMK if you guys want me to send this up on my own, but I'm assuming
that the drm/rockchip folks will handle it.
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index 8ab3247dbc4a..13c6b857158f 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1123,7 +1123,7 @@ static int cdn_dp_suspend(struct device *dev)
return ret;
}
-static int cdn_dp_resume(struct device *dev)
+static __maybe_unused int cdn_dp_resume(struct device *dev)
{
struct cdn_dp_device *dp = dev_get_drvdata(dev);
--
2.33.0.309.g3052b89438-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-09-11 3:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 3:43 Palmer Dabbelt [this message]
2021-09-11 3:43 ` [PATCH v2] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning Palmer Dabbelt
2021-09-11 3:43 ` Palmer Dabbelt
2021-09-11 3:43 ` Palmer Dabbelt
2021-09-21 9:12 ` Heiko Stuebner
2021-09-21 9:12 ` Heiko Stuebner
2021-09-21 9:12 ` Heiko Stuebner
2021-09-21 15:04 ` Palmer Dabbelt
2021-09-21 15:04 ` Palmer Dabbelt
2021-09-21 15:04 ` Palmer Dabbelt
2021-09-21 15:04 ` Palmer Dabbelt
2021-09-21 19:29 ` Heiko Stübner
2021-09-21 19:29 ` Heiko Stübner
2021-09-21 19:29 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210911034317.1719619-1-palmer@dabbelt.com \
--to=palmer@dabbelt.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=palmerdabbelt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.