* [PATCH v2] hw/i386/acpi-build: Fix a typo
@ 2021-09-11 8:20 Philippe Mathieu-Daudé
2021-09-15 12:48 ` Laurent Vivier
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-11 8:20 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Volker Rümelin, Richard Henderson, Paolo Bonzini, Ani Sinha,
Igor Mammedov, Philippe Mathieu-Daudé
Fix 'hotplugabble' -> 'hotpluggable' typo.
Reviewed-by: Ani Sinha <ani@anisinha.ca>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v1 still had a typo =) (Volker Rümelin)
---
hw/i386/acpi-build.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index d1f5fa3b5a5..dfaa47cdc20 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1916,7 +1916,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
PCMachineState *pcms = PC_MACHINE(machine);
int nb_numa_nodes = machine->numa_state->num_nodes;
NodeInfo *numa_info = machine->numa_state->nodes;
- ram_addr_t hotplugabble_address_space_size =
+ ram_addr_t hotpluggable_address_space_size =
object_property_get_int(OBJECT(pcms), PC_MACHINE_DEVMEM_REGION_SIZE,
NULL);
@@ -2022,10 +2022,10 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
* Memory devices may override proximity set by this entry,
* providing _PXM method if necessary.
*/
- if (hotplugabble_address_space_size) {
+ if (hotpluggable_address_space_size) {
numamem = acpi_data_push(table_data, sizeof *numamem);
build_srat_memory(numamem, machine->device_memory->base,
- hotplugabble_address_space_size, nb_numa_nodes - 1,
+ hotpluggable_address_space_size, nb_numa_nodes - 1,
MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
}
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] hw/i386/acpi-build: Fix a typo
2021-09-11 8:20 [PATCH v2] hw/i386/acpi-build: Fix a typo Philippe Mathieu-Daudé
@ 2021-09-15 12:48 ` Laurent Vivier
2021-09-15 12:48 ` Laurent Vivier
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Vivier @ 2021-09-15 12:48 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Volker Rümelin, Richard Henderson, Igor Mammedov, Ani Sinha,
Paolo Bonzini
Le 11/09/2021 à 10:20, Philippe Mathieu-Daudé a écrit :
> Fix 'hotplugabble' -> 'hotpluggable' typo.
>
> Reviewed-by: Ani Sinha <ani@anisinha.ca>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v1 still had a typo =) (Volker Rümelin)
> ---
> hw/i386/acpi-build.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index d1f5fa3b5a5..dfaa47cdc20 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1916,7 +1916,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
> PCMachineState *pcms = PC_MACHINE(machine);
> int nb_numa_nodes = machine->numa_state->num_nodes;
> NodeInfo *numa_info = machine->numa_state->nodes;
> - ram_addr_t hotplugabble_address_space_size =
> + ram_addr_t hotpluggable_address_space_size =
> object_property_get_int(OBJECT(pcms), PC_MACHINE_DEVMEM_REGION_SIZE,
> NULL);
>
> @@ -2022,10 +2022,10 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
> * Memory devices may override proximity set by this entry,
> * providing _PXM method if necessary.
> */
> - if (hotplugabble_address_space_size) {
> + if (hotpluggable_address_space_size) {
> numamem = acpi_data_push(table_data, sizeof *numamem);
> build_srat_memory(numamem, machine->device_memory->base,
> - hotplugabble_address_space_size, nb_numa_nodes - 1,
> + hotpluggable_address_space_size, nb_numa_nodes - 1,
> MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
> }
>
>
Applied to my linux-user-for-6.2 branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] hw/i386/acpi-build: Fix a typo
2021-09-15 12:48 ` Laurent Vivier
@ 2021-09-15 12:48 ` Laurent Vivier
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-09-15 12:48 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Volker Rümelin, Richard Henderson, Paolo Bonzini, Ani Sinha,
Igor Mammedov
Le 15/09/2021 à 14:48, Laurent Vivier a écrit :
> Le 11/09/2021 à 10:20, Philippe Mathieu-Daudé a écrit :
>> Fix 'hotplugabble' -> 'hotpluggable' typo.
>>
>> Reviewed-by: Ani Sinha <ani@anisinha.ca>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> v1 still had a typo =) (Volker Rümelin)
>> ---
>> hw/i386/acpi-build.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
>> index d1f5fa3b5a5..dfaa47cdc20 100644
>> --- a/hw/i386/acpi-build.c
>> +++ b/hw/i386/acpi-build.c
>> @@ -1916,7 +1916,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
>> PCMachineState *pcms = PC_MACHINE(machine);
>> int nb_numa_nodes = machine->numa_state->num_nodes;
>> NodeInfo *numa_info = machine->numa_state->nodes;
>> - ram_addr_t hotplugabble_address_space_size =
>> + ram_addr_t hotpluggable_address_space_size =
>> object_property_get_int(OBJECT(pcms), PC_MACHINE_DEVMEM_REGION_SIZE,
>> NULL);
>>
>> @@ -2022,10 +2022,10 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
>> * Memory devices may override proximity set by this entry,
>> * providing _PXM method if necessary.
>> */
>> - if (hotplugabble_address_space_size) {
>> + if (hotpluggable_address_space_size) {
>> numamem = acpi_data_push(table_data, sizeof *numamem);
>> build_srat_memory(numamem, machine->device_memory->base,
>> - hotplugabble_address_space_size, nb_numa_nodes - 1,
>> + hotpluggable_address_space_size, nb_numa_nodes - 1,
>> MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
>> }
>>
>>
>
> Applied to my linux-user-for-6.2 branch.
I mean "trivial-patches"
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-15 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-11 8:20 [PATCH v2] hw/i386/acpi-build: Fix a typo Philippe Mathieu-Daudé
2021-09-15 12:48 ` Laurent Vivier
2021-09-15 12:48 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.