All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M
@ 2021-09-11  8:37 Dagg Stompler
  0 siblings, 0 replies; 7+ messages in thread
From: Dagg Stompler @ 2021-09-11  8:37 UTC (permalink / raw)
  To: buildroot

following Commit 9f127cc4, the resulting image is bigger than possible.
so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.

Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1575071376

Signed-off-by: Dagg Stompler <daggs@gmx.com>
---
 configs/odroidc2_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/odroidc2_defconfig b/configs/odroidc2_defconfig
index 5f97fc3dd8..daa818e036 100644
--- a/configs/odroidc2_defconfig
+++ b/configs/odroidc2_defconfig
@@ -10,6 +10,7 @@ BR2_TARGET_GENERIC_GETTY_PORT="ttyAML0"
 BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200=y
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
 BR2_ROOTFS_OVERLAY="board/hardkernel/odroidc2/rootfs_overlay"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"

--
2.33.0

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M
  2021-09-11 14:29   ` daggs
@ 2021-09-11 15:23     ` Yann E. MORIN
  0 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2021-09-11 15:23 UTC (permalink / raw)
  To: daggs; +Cc: buildroot

Dagg, All,

On 2021-09-11 16:29 +0200, daggs spake thusly:
> > Sent: Saturday, September 11, 2021 at 12:27 PM
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > To: "Dagg Stompler" <daggs@gmx.com>
> > Cc: buildroot@buildroot.org
> > Subject: Re: [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M
> > On 2021-09-11 11:42 +0300, Dagg Stompler spake thusly:
> > > following Commit 9f127cc4, the resulting image is bigger than possible.
> >
> > I fail to see how commit 9f127cc4 can be the culprit:
> >
> >     9f127cc4 utils/getdeveloperlib.py: explicitly set devs document encoding
> >
> > > so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.
> >
> > The default is 60M; bumping to 256M is surely a big jump. Can't we
> > settle for something smaller, like 128M?
> >
> > Also, note that the default is 60M, as we consider a 64M SDCard, and
> > thus some space is reserved at the begining for the boot blobs; see
> > board/hardkernel/odroidc2/genimage.cfg
> >
> > And as a consequence, the size of the SDCard must also be updated in
> > board/hardkernel/odroidc2/genimage.cfg.
> >
> > So, maybe:
> >   - update board/hardkernel/odroidc2/genimage.cfg from 64M to 128M
> >   - update BR2_TARGET_ROOTFS_EXT2_SIZE to 124M
> >
> > Regards,
> > Yann E. MORIN.
> >
> 
> if you open the link stated in the commit msg and look at the right,
> you see the commit stated in it.
> I didn't thought I should verify if it is that commit.
> this is the first error the autobuild  finds which I can reproduce,
> so I assumed it is related to that commit.

Ah, the gitlab-ci job that tests the defconfigs only runs once a week,
so you'd get the commit that was current by that time.

Also, the e2fsprogs bump to 1.46.3, which had the regression, was
applied to the 'next' branch, which is not tested by the gitlab-ci
infra, and thus the first issue to be reported was when next was
eventually merged into master last week.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M
  2021-09-11  9:30   ` Yann E. MORIN
@ 2021-09-11 14:30     ` daggs
  0 siblings, 0 replies; 7+ messages in thread
From: daggs @ 2021-09-11 14:30 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: buildroot

Greetings Yann,

> Sent: Saturday, September 11, 2021 at 12:30 PM
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> To: "Dagg Stompler" <daggs@gmx.com>
> Cc: buildroot@buildroot.org
> Subject: Re: [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M
>
> Dagg, All,
>
> On 2021-09-11 11:27 +0200, Yann E. MORIN spake thusly:
> > On 2021-09-11 11:42 +0300, Dagg Stompler spake thusly:
> > > following Commit 9f127cc4, the resulting image is bigger than possible.
> > > so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.
> > >
> > > Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1575071376
>
> In fact, that error is about another issue that was recently fixed:
>
>     https://git.buildroot.org/buildroot/commit/?id=4ad23552c6
>
> Can you verify that the test still works with the current master, before
> increasing the fs size?
>
> Regards,
> Yann E. MORIN.
>

as said in previous mail it reproduced on my setup with today's master
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M
  2021-09-11  9:27 ` Yann E. MORIN
  2021-09-11  9:30   ` Yann E. MORIN
@ 2021-09-11 14:29   ` daggs
  2021-09-11 15:23     ` Yann E. MORIN
  1 sibling, 1 reply; 7+ messages in thread
From: daggs @ 2021-09-11 14:29 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: buildroot

Greeting Yann,

> Sent: Saturday, September 11, 2021 at 12:27 PM
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> To: "Dagg Stompler" <daggs@gmx.com>
> Cc: buildroot@buildroot.org
> Subject: Re: [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M
>
> Dagg, All,
>
> On 2021-09-11 11:42 +0300, Dagg Stompler spake thusly:
> > following Commit 9f127cc4, the resulting image is bigger than possible.
>
> I fail to see how commit 9f127cc4 can be the culprit:
>
>     9f127cc4 utils/getdeveloperlib.py: explicitly set devs document encoding
>
> > so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.
>
> The default is 60M; bumping to 256M is surely a big jump. Can't we
> settle for something smaller, like 128M?
>
> Also, note that the default is 60M, as we consider a 64M SDCard, and
> thus some space is reserved at the begining for the boot blobs; see
> board/hardkernel/odroidc2/genimage.cfg
>
> And as a consequence, the size of the SDCard must also be updated in
> board/hardkernel/odroidc2/genimage.cfg.
>
> So, maybe:
>   - update board/hardkernel/odroidc2/genimage.cfg from 64M to 128M
>   - update BR2_TARGET_ROOTFS_EXT2_SIZE to 124M
>
> Regards,
> Yann E. MORIN.
>

if you open the link stated in the commit msg and look at the right, you see the commit stated in it.
I didn't thought I should verify if it is that commit.
this is the first error the autobuild  finds which I can reproduce, so I assumed it is related to that commit.

I bumped it to 256M because I assumed the minimum is 60M, I'll test with 128M and report back

I'll adjust the commit based on our suggestions above.

Dagg.
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M
  2021-09-11  9:27 ` Yann E. MORIN
@ 2021-09-11  9:30   ` Yann E. MORIN
  2021-09-11 14:30     ` daggs
  2021-09-11 14:29   ` daggs
  1 sibling, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2021-09-11  9:30 UTC (permalink / raw)
  To: Dagg Stompler; +Cc: buildroot

Dagg, All,

On 2021-09-11 11:27 +0200, Yann E. MORIN spake thusly:
> On 2021-09-11 11:42 +0300, Dagg Stompler spake thusly:
> > following Commit 9f127cc4, the resulting image is bigger than possible.
> > so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.
> > 
> > Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1575071376

In fact, that error is about another issue that was recently fixed:

    https://git.buildroot.org/buildroot/commit/?id=4ad23552c6

Can you verify that the test still works with the current master, before
increasing the fs size?

Regards,
Yann E. MORIN.

> > Signed-off-by: Dagg Stompler <daggs@gmx.com>
> > ---
> >  configs/odroidc2_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/configs/odroidc2_defconfig b/configs/odroidc2_defconfig
> > index 5f97fc3dd8..daa818e036 100644
> > --- a/configs/odroidc2_defconfig
> > +++ b/configs/odroidc2_defconfig
> > @@ -10,6 +10,7 @@ BR2_TARGET_GENERIC_GETTY_PORT="ttyAML0"
> >  BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200=y
> >  BR2_TARGET_ROOTFS_EXT2=y
> >  BR2_TARGET_ROOTFS_EXT2_4=y
> > +BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
> >  BR2_ROOTFS_OVERLAY="board/hardkernel/odroidc2/rootfs_overlay"
> >  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"
> > 
> > --
> > 2.33.0
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@lists.buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M
  2021-09-11  8:42 Dagg Stompler
@ 2021-09-11  9:27 ` Yann E. MORIN
  2021-09-11  9:30   ` Yann E. MORIN
  2021-09-11 14:29   ` daggs
  0 siblings, 2 replies; 7+ messages in thread
From: Yann E. MORIN @ 2021-09-11  9:27 UTC (permalink / raw)
  To: Dagg Stompler; +Cc: buildroot

Dagg, All,

On 2021-09-11 11:42 +0300, Dagg Stompler spake thusly:
> following Commit 9f127cc4, the resulting image is bigger than possible.

I fail to see how commit 9f127cc4 can be the culprit:

    9f127cc4 utils/getdeveloperlib.py: explicitly set devs document encoding

> so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.

The default is 60M; bumping to 256M is surely a big jump. Can't we
settle for something smaller, like 128M?

Also, note that the default is 60M, as we consider a 64M SDCard, and
thus some space is reserved at the begining for the boot blobs; see
board/hardkernel/odroidc2/genimage.cfg

And as a consequence, the size of the SDCard must also be updated in
board/hardkernel/odroidc2/genimage.cfg.

So, maybe:
  - update board/hardkernel/odroidc2/genimage.cfg from 64M to 128M
  - update BR2_TARGET_ROOTFS_EXT2_SIZE to 124M

Regards,
Yann E. MORIN.

> Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1575071376
> 
> Signed-off-by: Dagg Stompler <daggs@gmx.com>
> ---
>  configs/odroidc2_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/odroidc2_defconfig b/configs/odroidc2_defconfig
> index 5f97fc3dd8..daa818e036 100644
> --- a/configs/odroidc2_defconfig
> +++ b/configs/odroidc2_defconfig
> @@ -10,6 +10,7 @@ BR2_TARGET_GENERIC_GETTY_PORT="ttyAML0"
>  BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200=y
>  BR2_TARGET_ROOTFS_EXT2=y
>  BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
>  BR2_ROOTFS_OVERLAY="board/hardkernel/odroidc2/rootfs_overlay"
>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"
> 
> --
> 2.33.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M
@ 2021-09-11  8:42 Dagg Stompler
  2021-09-11  9:27 ` Yann E. MORIN
  0 siblings, 1 reply; 7+ messages in thread
From: Dagg Stompler @ 2021-09-11  8:42 UTC (permalink / raw)
  To: buildroot

following Commit 9f127cc4, the resulting image is bigger than possible.
so BR2_TARGET_ROOTFS_EXT2_SIZE set to 256M is required.

Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1575071376

Signed-off-by: Dagg Stompler <daggs@gmx.com>
---
 configs/odroidc2_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/odroidc2_defconfig b/configs/odroidc2_defconfig
index 5f97fc3dd8..daa818e036 100644
--- a/configs/odroidc2_defconfig
+++ b/configs/odroidc2_defconfig
@@ -10,6 +10,7 @@ BR2_TARGET_GENERIC_GETTY_PORT="ttyAML0"
 BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200=y
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
 BR2_ROOTFS_OVERLAY="board/hardkernel/odroidc2/rootfs_overlay"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/hardkernel/odroidc2/post-image.sh"

--
2.33.0

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-09-11 15:24 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-11  8:37 [Buildroot] [PATCH] configs/ordeidc2: increase image size to 256M Dagg Stompler
2021-09-11  8:42 Dagg Stompler
2021-09-11  9:27 ` Yann E. MORIN
2021-09-11  9:30   ` Yann E. MORIN
2021-09-11 14:30     ` daggs
2021-09-11 14:29   ` daggs
2021-09-11 15:23     ` Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.