All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huacai Chen <chenhuacai@loongson.cn>
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Xuefeng Li <lixuefeng@loongson.cn>,
	Huacai Chen <chenhuacai@gmail.com>,
	Huacai Chen <chenhuacai@loongson.cn>
Subject: [PATCH V5 09/11] PCI/VGA: Log bridge control messages when adding devices
Date: Sat, 11 Sep 2021 17:30:54 +0800	[thread overview]
Message-ID: <20210911093056.1555274-10-chenhuacai@loongson.cn> (raw)
In-Reply-To: <20210911093056.1555274-1-chenhuacai@loongson.cn>

Previously vga_arb_device_init() iterated through all VGA devices and
indicated whether legacy VGA routing to each could be controlled by an
upstream bridge.

But we determine that information in vga_arbiter_add_pci_device(), which we
call for every device, so we can log it there without iterating through the
VGA devices again.

Note that we call vga_arbiter_check_bridge_sharing() before adding the
device to vga_list, so we have to handle the very first device separately.

Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/vgaarb.c | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
index 1a829cbacbc8..5a042f9ac82c 100644
--- a/drivers/pci/vgaarb.c
+++ b/drivers/pci/vgaarb.c
@@ -672,8 +672,10 @@ static void vga_arbiter_check_bridge_sharing(struct vga_device *vgadev)
 
 	vgadev->bridge_has_one_vga = true;
 
-	if (list_empty(&vga_list))
+	if (list_empty(&vga_list)) {
+		vgaarb_info(&vgadev->pdev->dev, "bridge control possible\n");
 		return;
+	}
 
 	/* okay iterate the new devices bridge hierarachy */
 	new_bus = vgadev->pdev->bus;
@@ -712,6 +714,11 @@ static void vga_arbiter_check_bridge_sharing(struct vga_device *vgadev)
 		}
 		new_bus = new_bus->parent;
 	}
+
+	if (vgadev->bridge_has_one_vga)
+		vgaarb_info(&vgadev->pdev->dev, "bridge control possible\n");
+	else
+		vgaarb_info(&vgadev->pdev->dev, "no bridge control possible\n");
 }
 
 /*
@@ -1504,7 +1511,6 @@ static int __init vga_arb_device_init(void)
 {
 	int rc;
 	struct pci_dev *pdev;
-	struct vga_device *vgadev;
 
 	rc = misc_register(&vga_arb_device);
 	if (rc < 0)
@@ -1520,15 +1526,6 @@ static int __init vga_arb_device_init(void)
 			       PCI_ANY_ID, pdev)) != NULL)
 		vga_arbiter_add_pci_device(pdev);
 
-	list_for_each_entry(vgadev, &vga_list, list) {
-		struct device *dev = &vgadev->pdev->dev;
-
-		if (vgadev->bridge_has_one_vga)
-			vgaarb_info(dev, "bridge control possible\n");
-		else
-			vgaarb_info(dev, "no bridge control possible\n");
-	}
-
 	return rc;
 }
 subsys_initcall(vga_arb_device_init);
-- 
2.27.0


  parent reply	other threads:[~2021-09-11  9:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11  9:30 [PATCH V5 00/11] PCI/VGA: Rework default VGA device selection Huacai Chen
2021-09-11  9:30 ` [PATCH V5 01/11] PCI/VGA: Move vgaarb to drivers/pci Huacai Chen
2021-09-11  9:30 ` [PATCH V5 02/11] PCI/VGA: Prefer vga_default_device() Huacai Chen
2021-09-11  9:30 ` [PATCH V5 03/11] PCI/VGA: Move vga_arb_integrated_gpu() earlier in file Huacai Chen
2021-09-11  9:30 ` [PATCH V5 04/11] PCI/VGA: Split out vga_arb_update_default_device() Huacai Chen
2021-09-11  9:30 ` [PATCH V5 05/11] PCI/VGA: Update default VGA device if a better one found Huacai Chen
2021-09-11  9:30 ` [PATCH V5 06/11] PCI/VGA: Update default VGA device again for X86/IA64 Huacai Chen
2021-09-11  9:30 ` [PATCH V5 07/11] PCI/VGA: Remove vga_arb_select_default_device() Huacai Chen
2021-09-11  9:30 ` [PATCH V5 08/11] PCI/VGA: Remove empty vga_arb_device_card_gone() Huacai Chen
2021-09-11  9:30 ` Huacai Chen [this message]
2021-09-11  9:30 ` [PATCH V5 10/11] PCI/VGA: Use unsigned format string to print lock counts Huacai Chen
2021-09-11  9:30 ` [PATCH V5 11/11] PCI/VGA: Replace full MIT license text with SPDX identifier Huacai Chen
2021-09-14 19:18 ` [PATCH V5 00/11] PCI/VGA: Rework default VGA device selection Bjorn Helgaas
2021-09-16  8:28   ` Huacai Chen
2021-09-16  8:28     ` Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210911093056.1555274-10-chenhuacai@loongson.cn \
    --to=chenhuacai@loongson.cn \
    --cc=airlied@linux.ie \
    --cc=bhelgaas@google.com \
    --cc=chenhuacai@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.