All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huacai Chen <chenhuacai@loongson.cn>
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Xuefeng Li <lixuefeng@loongson.cn>,
	Huacai Chen <chenhuacai@gmail.com>
Subject: [PATCH V5 08/11] PCI/VGA: Remove empty vga_arb_device_card_gone()
Date: Sat, 11 Sep 2021 17:30:53 +0800	[thread overview]
Message-ID: <20210911093056.1555274-9-chenhuacai@loongson.cn> (raw)
In-Reply-To: <20210911093056.1555274-1-chenhuacai@loongson.cn>

From: Bjorn Helgaas <bhelgaas@google.com>

vga_arb_device_card_gone() has always been empty.  Remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/vgaarb.c | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
index 5a008d190ed8..1a829cbacbc8 100644
--- a/drivers/pci/vgaarb.c
+++ b/drivers/pci/vgaarb.c
@@ -122,8 +122,6 @@ static int vga_str_to_iostate(char *buf, int str_size, int *io_state)
 /* this is only used a cookie - it should not be dereferenced */
 static struct pci_dev *vga_default;
 
-static void vga_arb_device_card_gone(struct pci_dev *pdev);
-
 /* Find somebody in our list */
 static struct vga_device *vgadev_find(struct pci_dev *pdev)
 {
@@ -825,10 +823,6 @@ static bool vga_arbiter_del_pci_device(struct pci_dev *pdev)
 	/* Remove entry from list */
 	list_del(&vgadev->list);
 	vga_count--;
-	/* Notify userland driver that the device is gone so it discards
-	 * it's copies of the pci_dev pointer
-	 */
-	vga_arb_device_card_gone(pdev);
 
 	/* Wake up all possible waiters */
 	wake_up_all(&vga_wait_queue);
@@ -1078,9 +1072,7 @@ static ssize_t vga_arb_read(struct file *file, char __user *buf,
 	if (lbuf == NULL)
 		return -ENOMEM;
 
-	/* Shields against vga_arb_device_card_gone (pci_dev going
-	 * away), and allows access to vga list
-	 */
+	/* Protects vga_list */
 	spin_lock_irqsave(&vga_lock, flags);
 
 	/* If we are targeting the default, use it */
@@ -1097,8 +1089,6 @@ static ssize_t vga_arb_read(struct file *file, char __user *buf,
 		/* Wow, it's not in the list, that shouldn't happen,
 		 * let's fix us up and return invalid card
 		 */
-		if (pdev == priv->target)
-			vga_arb_device_card_gone(pdev);
 		spin_unlock_irqrestore(&vga_lock, flags);
 		len = sprintf(lbuf, "invalid");
 		goto done;
@@ -1442,10 +1432,6 @@ static int vga_arb_release(struct inode *inode, struct file *file)
 	return 0;
 }
 
-static void vga_arb_device_card_gone(struct pci_dev *pdev)
-{
-}
-
 /*
  * callback any registered clients to let them know we have a
  * change in VGA cards
-- 
2.27.0


  parent reply	other threads:[~2021-09-11  9:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11  9:30 [PATCH V5 00/11] PCI/VGA: Rework default VGA device selection Huacai Chen
2021-09-11  9:30 ` [PATCH V5 01/11] PCI/VGA: Move vgaarb to drivers/pci Huacai Chen
2021-09-11  9:30 ` [PATCH V5 02/11] PCI/VGA: Prefer vga_default_device() Huacai Chen
2021-09-11  9:30 ` [PATCH V5 03/11] PCI/VGA: Move vga_arb_integrated_gpu() earlier in file Huacai Chen
2021-09-11  9:30 ` [PATCH V5 04/11] PCI/VGA: Split out vga_arb_update_default_device() Huacai Chen
2021-09-11  9:30 ` [PATCH V5 05/11] PCI/VGA: Update default VGA device if a better one found Huacai Chen
2021-09-11  9:30 ` [PATCH V5 06/11] PCI/VGA: Update default VGA device again for X86/IA64 Huacai Chen
2021-09-11  9:30 ` [PATCH V5 07/11] PCI/VGA: Remove vga_arb_select_default_device() Huacai Chen
2021-09-11  9:30 ` Huacai Chen [this message]
2021-09-11  9:30 ` [PATCH V5 09/11] PCI/VGA: Log bridge control messages when adding devices Huacai Chen
2021-09-11  9:30 ` [PATCH V5 10/11] PCI/VGA: Use unsigned format string to print lock counts Huacai Chen
2021-09-11  9:30 ` [PATCH V5 11/11] PCI/VGA: Replace full MIT license text with SPDX identifier Huacai Chen
2021-09-14 19:18 ` [PATCH V5 00/11] PCI/VGA: Rework default VGA device selection Bjorn Helgaas
2021-09-16  8:28   ` Huacai Chen
2021-09-16  8:28     ` Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210911093056.1555274-9-chenhuacai@loongson.cn \
    --to=chenhuacai@loongson.cn \
    --cc=airlied@linux.ie \
    --cc=bhelgaas@google.com \
    --cc=chenhuacai@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.