All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH peterz-queue:sched/core] sched: fix build warning with W=1
Date: Sat, 11 Sep 2021 14:22:16 +0200	[thread overview]
Message-ID: <20210911122216.GX4323@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20210911082505.115758-1-laoar.shao@gmail.com>

On Sat, Sep 11, 2021 at 08:25:05AM +0000, Yafang Shao wrote:
> kernel test robot reported some build warnings with W=1 as below,
> 
> kernel/sched/fair.c:892:34: warning: variable 'stats' set but not used
> kernel/sched/core.c:10238:42: warning: variable 'stats' set but not used
> kernel/sched/fair.c:893:29: warning: variable 'p' set but not used
> kernel/sched/rt.c:1292:29: warning: variable 'p' set but not used
> kernel/sched/deadline.c:1486:34: warning: variable 'stats' set but not used
> arch/nds32/include/asm/current.h:10:13: warning: variable '$r25' set but not used
> 
> These warnings happen when CONFIG_SCHEDSTATS is not set, in which
> case the schedstat_* functions will be none. We should add
> '__maybe_unused' to fix it

I really hate all of this, I think the compiler is just being unhelpful
in the extreme. Also, I spupose the warning is in W=1 for a reason,
let's just completely ignore all of this.

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH peterz-queue:sched/core] sched: fix build warning with W=1
Date: Sat, 11 Sep 2021 14:22:16 +0200	[thread overview]
Message-ID: <20210911122216.GX4323@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20210911082505.115758-1-laoar.shao@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 938 bytes --]

On Sat, Sep 11, 2021 at 08:25:05AM +0000, Yafang Shao wrote:
> kernel test robot reported some build warnings with W=1 as below,
> 
> kernel/sched/fair.c:892:34: warning: variable 'stats' set but not used
> kernel/sched/core.c:10238:42: warning: variable 'stats' set but not used
> kernel/sched/fair.c:893:29: warning: variable 'p' set but not used
> kernel/sched/rt.c:1292:29: warning: variable 'p' set but not used
> kernel/sched/deadline.c:1486:34: warning: variable 'stats' set but not used
> arch/nds32/include/asm/current.h:10:13: warning: variable '$r25' set but not used
> 
> These warnings happen when CONFIG_SCHEDSTATS is not set, in which
> case the schedstat_* functions will be none. We should add
> '__maybe_unused' to fix it

I really hate all of this, I think the compiler is just being unhelpful
in the extreme. Also, I spupose the warning is in W=1 for a reason,
let's just completely ignore all of this.

  parent reply	other threads:[~2021-09-11 12:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11  8:25 [PATCH peterz-queue:sched/core] sched: fix build warning with W=1 Yafang Shao
2021-09-11  8:25 ` Yafang Shao
2021-09-11 11:57 ` Peter Zijlstra
2021-09-11 11:57   ` Peter Zijlstra
2021-09-11 12:22 ` Peter Zijlstra [this message]
2021-09-11 12:22   ` Peter Zijlstra
2021-09-11 14:47   ` Yafang Shao
2021-09-11 14:47     ` Yafang Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210911122216.GX4323@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=kbuild-all@lists.01.org \
    --cc=laoar.shao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.