All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cmd: tlv_eeprom
@ 2021-09-12  7:25 sven.auhagen
  2021-10-21  5:36 ` Stefan Roese
  0 siblings, 1 reply; 3+ messages in thread
From: sven.auhagen @ 2021-09-12  7:25 UTC (permalink / raw)
  To: u-boot

From: Sven Auhagen <Sven.Auhagen@voleatech.de>

The function show_eeprom is missing int i if debug is enabled.

Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
---
 cmd/tlv_eeprom.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/cmd/tlv_eeprom.c b/cmd/tlv_eeprom.c
index 745565f89c..520e5dc738 100644
--- a/cmd/tlv_eeprom.c
+++ b/cmd/tlv_eeprom.c
@@ -169,6 +169,9 @@ static void show_eeprom(u8 *eeprom)
 {
 	int tlv_end;
 	int curr_tlv;
+#ifdef DEBUG
+	int i;
+#endif
 	struct tlvinfo_header *eeprom_hdr = to_header(eeprom);
 	struct tlvinfo_tlv    *eeprom_tlv;
 
-- 
2.30.1 (Apple Git-130)


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] cmd: tlv_eeprom
  2021-09-12  7:25 [PATCH] cmd: tlv_eeprom sven.auhagen
@ 2021-10-21  5:36 ` Stefan Roese
  2021-10-21  7:46   ` Stefan Roese
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Roese @ 2021-10-21  5:36 UTC (permalink / raw)
  To: sven.auhagen, u-boot

On 12.09.21 09:25, sven.auhagen@voleatech.de wrote:
> From: Sven Auhagen <Sven.Auhagen@voleatech.de>
> 
> The function show_eeprom is missing int i if debug is enabled.
> 
> Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   cmd/tlv_eeprom.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/cmd/tlv_eeprom.c b/cmd/tlv_eeprom.c
> index 745565f89c..520e5dc738 100644
> --- a/cmd/tlv_eeprom.c
> +++ b/cmd/tlv_eeprom.c
> @@ -169,6 +169,9 @@ static void show_eeprom(u8 *eeprom)
>   {
>   	int tlv_end;
>   	int curr_tlv;
> +#ifdef DEBUG
> +	int i;
> +#endif
>   	struct tlvinfo_header *eeprom_hdr = to_header(eeprom);
>   	struct tlvinfo_tlv    *eeprom_tlv;
>   
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cmd: tlv_eeprom
  2021-10-21  5:36 ` Stefan Roese
@ 2021-10-21  7:46   ` Stefan Roese
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2021-10-21  7:46 UTC (permalink / raw)
  To: sven.auhagen, u-boot

On 21.10.21 07:36, Stefan Roese wrote:
> On 12.09.21 09:25, sven.auhagen@voleatech.de wrote:
>> From: Sven Auhagen <Sven.Auhagen@voleatech.de>
>>
>> The function show_eeprom is missing int i if debug is enabled.
>>
>> Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
> 
> Reviewed-by: Stefan Roese <sr@denx.de>

Applied to u-boot-marvell/master

Thanks,
Stefan

> Thanks,
> Stefan
> 
>> ---
>>   cmd/tlv_eeprom.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/cmd/tlv_eeprom.c b/cmd/tlv_eeprom.c
>> index 745565f89c..520e5dc738 100644
>> --- a/cmd/tlv_eeprom.c
>> +++ b/cmd/tlv_eeprom.c
>> @@ -169,6 +169,9 @@ static void show_eeprom(u8 *eeprom)
>>   {
>>       int tlv_end;
>>       int curr_tlv;
>> +#ifdef DEBUG
>> +    int i;
>> +#endif
>>       struct tlvinfo_header *eeprom_hdr = to_header(eeprom);
>>       struct tlvinfo_tlv    *eeprom_tlv;
>>
> 
> 
> Viele Grüße,
> Stefan
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-21  7:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-12  7:25 [PATCH] cmd: tlv_eeprom sven.auhagen
2021-10-21  5:36 ` Stefan Roese
2021-10-21  7:46   ` Stefan Roese

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.